Skip to content

Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.

Don't rely on Mix.env check in runtime (#2703)

Adam Rutkowski7dec454a23f5
diff --git a/lib/plausible_web/controllers/stats_controller.ex b/lib/plausible_web/controllers/stats_controller.ex
index 7607d75bad..e80bff9e3c 100644
--- a/lib/plausible_web/controllers/stats_controller.ex
+++ b/lib/plausible_web/controllers/stats_controller.ex
@@ -96,8 +96,7 @@ defmodule PlausibleWeb.StatsController do
query = Query.from(site, params) |> Filters.add_prefix()
visits_metric_enabled =
- FunWithFlags.enabled?(:visits_metric, for: conn.assigns[:current_user]) ||
- Mix.env() == :test
+ FunWithFlags.enabled?(:visits_metric, for: conn.assigns[:current_user])
metrics =
if visits_metric_enabled && !query.filters["event:goal"] do
diff --git a/test/test_helper.exs b/test/test_helper.exs
index 85358b3dff..62161c24ab 100644
--- a/test/test_helper.exs
+++ b/test/test_helper.exs
@@ -1,6 +1,7 @@
{:ok, _} = Application.ensure_all_started(:ex_machina)
Plausible.Test.ClickhouseSetup.run()
Mox.defmock(Plausible.HTTPClient.Mock, for: Plausible.HTTPClient.Interface)
+FunWithFlags.enable(:visits_metric)
ExUnit.start(exclude: :slow)
Application.ensure_all_started(:double)
Ecto.Adapters.SQL.Sandbox.mode(Plausible.Repo, :manual)