Skip to content

Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.

Don't render external links for WP search_query property (#5649)

Adam Rutkowski82941c93dd8f
diff --git a/assets/js/dashboard/stats/behaviours/goal-conversions.js b/assets/js/dashboard/stats/behaviours/goal-conversions.js
index d2dda5cc92..2c65f710f5 100644
--- a/assets/js/dashboard/stats/behaviours/goal-conversions.js
+++ b/assets/js/dashboard/stats/behaviours/goal-conversions.js
@@ -52,6 +52,8 @@ function SpecialPropBreakdown({ prop, afterFetchData }) {
function getExternalLinkUrlFactory() {
if (prop === 'path') {
return (listItem) => url.externalLinkForPage(site.domain, listItem.name)
+ } else if (prop === 'search_query') {
+ return null // WP Search Queries should not become external links
} else {
return (listItem) => listItem.name
}
diff --git a/assets/js/dashboard/stats/reports/list.tsx b/assets/js/dashboard/stats/reports/list.tsx
index b440403726..b558de2285 100644
--- a/assets/js/dashboard/stats/reports/list.tsx
+++ b/assets/js/dashboard/stats/reports/list.tsx
@@ -38,7 +38,7 @@ function ExternalLink<T>({
target="_blank"
rel="noreferrer"
href={dest}
- className="w-4 h-4 hidden group-hover:block"
+ className="w-4 h-4 invisible group-hover:visible"
>
<svg
className="inline w-full h-full ml-1 -mt-1 text-gray-600 dark:text-gray-400"