Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.
TypeScript analyticsanalytics-dashboardclickhouseelixirgoogle-analyticsmarketingopen-source-analyticsphoenixplausible-analyticspostgresqlprivacyprivacy-friendlyself-hostedsimple-analyticsstatisticstailwindcssweb-analyticswebsite-analyticswebsite-statswebsite-tracking
Fix people invitation token disclosure (#6829)
Cenk Kücük8ade52cb1f3b
diff --git a/lib/plausible_web/templates/site/settings_people.html.heex b/lib/plausible_web/templates/site/settings_people.html.heexindex 34c22fcd37..1bb4370c58 100644--- a/lib/plausible_web/templates/site/settings_people.html.heex+++ b/lib/plausible_web/templates/site/settings_people.html.heex@@ -109,10 +109,7 @@<:title>Pending invitations</:title><:subtitle>Waiting for new members to accept their invitations.</:subtitle>- <.table- rows={@invitations}- row_attrs={fn invitation -> %{id: "invitation-#{invitation.invitation_id}"} end}- >+ <.table rows={@invitations}><:thead><.th>Email</.th><.th hide_on_mobile>Role</.th>diff --git a/test/plausible_web/controllers/site_controller_test.exs b/test/plausible_web/controllers/site_controller_test.exsindex e2efc74e52..7669a09686 100644--- a/test/plausible_web/controllers/site_controller_test.exs+++ b/test/plausible_web/controllers/site_controller_test.exs@@ -888,11 +888,13 @@ defmodule PlausibleWeb.SiteControllerTest doconn = get(conn, "/#{site.domain}/settings/people")resp = html_response(conn, 200)- assert text_of_element(resp, "#invitation-#{i1.invitation_id}") ==- "[email protected] Editor"-- assert text_of_element(resp, "#invitation-#{i2.invitation_id}") ==+ assert resp |> find("tbody tr") |> Enum.map(&text/1) |> Enum.sort() == [+ "[email protected] Editor","[email protected] Viewer"+ ]++ assert resp =~ i1.invitation_id+ assert resp =~ i2.invitation_idendtest "lists pending site transfer", %{conn: conn, user: user} do@@ -904,8 +906,25 @@ defmodule PlausibleWeb.SiteControllerTest doconn = get(conn, "/#{site.domain}/settings/people")resp = html_response(conn, 200)- assert text_of_element(resp, "#invitation-#{st.transfer_id}") ==- "#{new_owner.email} Owner"+ assert text_of_element(resp, "tbody tr") == "#{new_owner.email} Owner"+ assert resp =~ st.transfer_id+ end++ test "does not expose pending invitation and transfer ids to editors", %{+ conn: conn,+ user: user+ } do+ owner = new_user()+ site = new_site(owner: owner)+ add_guest(site, user: user, role: :editor)+ invitation = invite_guest(site, "[email protected]", role: :viewer, inviter: owner)+ transfer = invite_transfer(site, new_user(), inviter: owner)++ resp = conn |> get("/#{site.domain}/settings/people") |> html_response(200)++ assert resp =~ "[email protected]"+ refute resp =~ invitation.invitation_id+ refute resp =~ transfer.transfer_idendtest "renders distinct team management notices to owner", %{conn: conn, user: user} do