Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.
TypeScript analyticsanalytics-dashboardclickhouseelixirgoogle-analyticsmarketingopen-source-analyticsphoenixplausible-analyticspostgresqlprivacyprivacy-friendlyself-hostedsimple-analyticsstatisticstailwindcssweb-analyticswebsite-analyticswebsite-statswebsite-tracking
Remove CTA to add goals when setting up funnels with no goals yet (#6818)
Adrian Gruntkowski91b1a20dd898
diff --git a/extra/lib/plausible_web/live/funnel_settings.ex b/extra/lib/plausible_web/live/funnel_settings.exindex 71b8c6b4a4..084f241a68 100644--- a/extra/lib/plausible_web/live/funnel_settings.ex+++ b/extra/lib/plausible_web/live/funnel_settings.ex@@ -6,7 +6,8 @@ defmodule PlausibleWeb.Live.FunnelSettings douse Plausible.Funnel- alias Plausible.{Goals, Funnels, Teams}+ alias Plausible.Funnels+ alias Plausible.Teamsdef mount(_params,@@ -28,9 +29,6 @@ defmodule PlausibleWeb.Live.FunnelSettings do|> assign_new(:all_funnels, fn %{site: %{id: ^site_id} = site} ->Funnels.list(site)end)- |> assign_new(:goal_count, fn %{site: site} ->- Goals.count(site)- end){:ok,assign(socket,@@ -88,7 +86,7 @@ defmodule PlausibleWeb.Live.FunnelSettings do})}<% end %>- <div :if={@goal_count >= Funnel.min_steps()}>+ <div><.live_componentmodule={PlausibleWeb.Live.FunnelSettings.List}id="funnels-list"@@ -96,26 +94,6 @@ defmodule PlausibleWeb.Live.FunnelSettings dofilter_text={@filter_text}/></div>-- <div- :if={@goal_count < Funnel.min_steps()}- class="flex flex-col items-center justify-center pt-5 pb-6 max-w-md mx-auto"- >- <h3 class="text-center text-base font-medium text-gray-900 dark:text-gray-100 leading-7">- Ready to dig into user flows?- </h3>- <p class="text-center text-sm mt-1 text-gray-500 dark:text-gray-400 leading-5 text-pretty">- Set up a few goals like <.highlighted>Signup</.highlighted>, <.highlighted>Visit /</.highlighted>, or- <.highlighted>Scroll 50% on /blog/*</.highlighted>- first, then return here to build your first funnel.- </p>- <.button_link- class="mt-6"- href={~p"/#{@domain}/settings/goals"}- >- Set up goals →- </.button_link>- </div></.tile></div>"""diff --git a/extra/lib/plausible_web/live/funnel_settings/list.ex b/extra/lib/plausible_web/live/funnel_settings/list.exindex f73b07bdc2..267bc590ab 100644--- a/extra/lib/plausible_web/live/funnel_settings/list.ex+++ b/extra/lib/plausible_web/live/funnel_settings/list.ex@@ -70,7 +70,7 @@ defmodule PlausibleWeb.Live.FunnelSettings.List doCreate your first funnel</h3><p class="text-center text-sm mt-1 text-gray-500 dark:text-gray-400 leading-5 text-pretty">- Compose goals into funnels to track user flows and conversion rates.+ Chain pages and events into a funnel to see where visitors drop off.<.styled_link href="https://plausible.io/docs/funnel-analysis" target="_blank">Learn more</.styled_link>diff --git a/test/plausible_web/live/funnel_settings_test.exs b/test/plausible_web/live/funnel_settings_test.exsindex a41091317a..c64548d2f5 100644--- a/test/plausible_web/live/funnel_settings_test.exs+++ b/test/plausible_web/live/funnel_settings_test.exs@@ -79,23 +79,6 @@ defmodule PlausibleWeb.Live.FunnelSettingsTest doresp = conn |> html_response(200)assert element_exists?(resp, ~S/button[phx-click="add-funnel"]/)end-- test "if not enough goals are present, renders a hint to create goals + no search", %{- conn: conn,- site: site- } do- {:ok, _} = Plausible.Goals.create(site, %{"page_path" => "/go/to/blog/**"})- conn = get(conn, "/#{site.domain}/settings/funnels")-- doc = conn |> html_response(200)- assert text(doc) =~ "Set up a few goals"-- add_goals_path = ~p"/#{site.domain}/settings/goals"- assert element_exists?(doc, ~s/a[href="#{add_goals_path}"]/)-- refute element_exists?(doc, ~s/input[type="text"]#filter-text/)- refute element_exists?(doc, ~s/form[phx-change="filter"]#filter-form/)- endenddescribe "FunnelSettings live view" do