Skip to content

Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.

Fix flaky breakdown test (#6510)

Artur Pata9384f5308795
diff --git a/assets/js/dashboard/components/drilldown-link.tsx b/assets/js/dashboard/components/drilldown-link.tsx
index 95295442f9..7082051944 100644
--- a/assets/js/dashboard/components/drilldown-link.tsx
+++ b/assets/js/dashboard/components/drilldown-link.tsx
@@ -58,6 +58,7 @@ export function DrilldownLink({
return (
<AppNavigationLink
+ data-testid="dimension-value"
title={`Add filter: ${title}`}
className={classNames(className, 'group')}
path={path}
@@ -76,7 +77,7 @@ export function DrilldownLink({
)
} else {
return (
- <span className={className}>
+ <span data-testid="dimension-value" className={className}>
{icon}
<span className={textClassName}>{children}</span>
</span>
diff --git a/assets/js/dashboard/stats/pages/external-link.tsx b/assets/js/dashboard/stats/pages/external-link.tsx
index 594a3b7869..c7ea59d003 100644
--- a/assets/js/dashboard/stats/pages/external-link.tsx
+++ b/assets/js/dashboard/stats/pages/external-link.tsx
@@ -15,6 +15,7 @@ export function DetailsExternalLink({
target="_blank"
rel="noreferrer"
href={href}
+ aria-label="Open page in a new tab"
className={isActive ? 'block' : 'hidden'}
>
<ExternalLinkIcon />
@@ -36,6 +37,7 @@ export function IndexExternalLink({
target="_blank"
rel="noreferrer"
href={href}
+ aria-label="Open page in a new tab"
className={
isActive
? 'visible md:invisible md:group-hover/row:visible'
diff --git a/e2e/tests/test-utils.ts b/e2e/tests/test-utils.ts
index 0f4a3705c4..d9cb86b04a 100644
--- a/e2e/tests/test-utils.ts
+++ b/e2e/tests/test-utils.ts
@@ -43,10 +43,15 @@ export const expectHeaders = async (report: Locator, headers: HaveTextArg) =>
expect(report.getByTestId('report-header')).toHaveText(headers)
export const expectRows = async (report: Locator, labels: HaveTextArg) =>
- expect(report.getByTestId('report-row').getByRole('link')).toHaveText(labels)
+ expect(
+ report.getByTestId('report-row').getByTestId('dimension-value')
+ ).toHaveText(labels)
export const rowLink = (report: Locator, label: HasTextArg) =>
- report.getByTestId('report-row').filter({ hasText: label }).getByRole('link')
+ report
+ .getByTestId('report-row')
+ .filter({ hasText: label })
+ .getByTestId('dimension-value')
export const expectMetricValues = async (
report: Locator,