Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.
TypeScript analyticsanalytics-dashboardclickhouseelixirgoogle-analyticsmarketingopen-source-analyticsphoenixplausible-analyticspostgresqlprivacyprivacy-friendlyself-hostedsimple-analyticsstatisticstailwindcssweb-analyticswebsite-analyticswebsite-statswebsite-tracking
fix: don't smear visitors when goal filter is present on time:hour graphs (#6229)
Uku Taht95e0cbec62ff
diff --git a/lib/plausible/stats/table_decider.ex b/lib/plausible/stats/table_decider.exindex e513385768..dcce1d8f5c 100644--- a/lib/plausible/stats/table_decider.ex+++ b/lib/plausible/stats/table_decider.ex@@ -126,7 +126,8 @@ defmodule Plausible.Stats.TableDecider do# See `time_slots` usage in `Plausible.Stats.SQL.Expression` to understand how this is done.@smearable_metrics [:visitors, :visits]defp smear_session_metrics({:sessions, metrics} = value, query) do- if "time:minute" in query.dimensions or "time:hour" in query.dimensions do+ if ("time:minute" in query.dimensions or "time:hour" in query.dimensions) and+ not filtering_on_dimension?(query, "event:goal") do# Split metrics into two groups: one with visitors and visits, and the remaining ones{smearable_metrics, session_metrics} = Enum.split_with(metrics, &(&1 in @smearable_metrics))diff --git a/test/plausible/stats/query/query_test.exs b/test/plausible/stats/query/query_test.exsindex fd9a6a8458..9394f5ce6d 100644--- a/test/plausible/stats/query/query_test.exs+++ b/test/plausible/stats/query/query_test.exs@@ -367,5 +367,32 @@ defmodule Plausible.Stats.QueryTest doassert [%{dimensions: ["2021-01-01 00:05:00"], metrics: [1, 50.0]}] = resultsend++ test "conversion_rate with time:hour and session filter does not crash",+ %{site: site} do+ insert(:goal, site: site, event_name: "Signup")++ populate_stats(site, [+ build(:pageview, user_id: 1, pathname: "/blog", timestamp: ~N[2021-01-01 00:00:00]),+ build(:event, name: "Signup", user_id: 1, timestamp: ~N[2021-01-01 00:05:00]),+ build(:pageview, user_id: 2, pathname: "/blog", timestamp: ~N[2021-01-01 00:10:00])+ ])++ {:ok, query} =+ QueryBuilder.build(site, %ParsedQueryParams{+ metrics: [:visitors, :conversion_rate],+ input_date_range: {:datetime_range, ~U[2021-01-01 00:00:00Z], ~U[2021-01-01 23:59:59Z]},+ dimensions: ["time:hour"],+ filters: [+ [:is, "event:goal", ["Signup"]],+ [:is, "visit:entry_page", ["/blog"]]+ ],+ skip_goal_existence_check: true+ })++ %Stats.QueryResult{results: results} = Stats.query(site, query)++ assert [%{dimensions: ["2021-01-01 00:00:00"], metrics: [1, 50.0]}] = results+ endendend