Skip to content

Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.

Remove empty filters from suggestions query (#2801)

Uku Taht9a4c4f46bb60
diff --git a/assets/js/dashboard/stats/modals/filter.js b/assets/js/dashboard/stats/modals/filter.js
index a9ea5013f1..a1690d28c7 100644
--- a/assets/js/dashboard/stats/modals/filter.js
+++ b/assets/js/dashboard/stats/modals/filter.js
@@ -121,7 +121,9 @@ class FilterModal extends React.Component {
if (formState[filter].type === FILTER_TYPES.contains) {return Promise.resolve([])}
const formFilters = Object.fromEntries(
- Object.entries(formState).map(([filter, {type, clauses}]) => [filter, toFilterQuery(type, clauses)])
+ Object.entries(formState)
+ .filter(([_filter, {_type, clauses}]) => clauses.length > 0)
+ .map(([filter, {type, clauses}]) => [filter, toFilterQuery(type, clauses)])
)
const updatedQuery = this.queryForSuggestions(query, formFilters, filter)
return api.get(apiPath(this.props.site, `/suggestions/${filter}`), updatedQuery, { q: input.trim() })