Skip to content

Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.

Fix flaky TableDeciderTest build(:site) ID colliding with IDs for sites inserted for other tests (#6530)

Artur Pata9e336922aaeb
diff --git a/test/plausible/stats/table_decider_test.exs b/test/plausible/stats/table_decider_test.exs
index e98db03576..2d16b691e9 100644
--- a/test/plausible/stats/table_decider_test.exs
+++ b/test/plausible/stats/table_decider_test.exs
@@ -255,7 +255,7 @@ defmodule Plausible.Stats.TableDeciderTest do
end
defp make_query(filter_dimensions \\ [], dimensions \\ []) do
- site = build(:site, id: :rand.uniform(100_000))
+ site = insert(:site)
QueryBuilder.build!(site,
metrics: [:visitors],
@@ -267,7 +267,7 @@ defmodule Plausible.Stats.TableDeciderTest do
end
defp make_query_full_filters(filters) do
- site = build(:site, id: :rand.uniform(100_000))
+ site = insert(:site)
QueryBuilder.build!(site,
metrics: [:visitors],