Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.
TypeScript analyticsanalytics-dashboardclickhouseelixirgoogle-analyticsmarketingopen-source-analyticsphoenixplausible-analyticspostgresqlprivacyprivacy-friendlyself-hostedsimple-analyticsstatisticstailwindcssweb-analyticswebsite-analyticswebsite-statswebsite-tracking
Fix dry run mode in `DataMigration.SiteImports` (#3965)
Adrian Gruntkowski9f27fa303cbe
diff --git a/lib/plausible/data_migration/site_imports.ex b/lib/plausible/data_migration/site_imports.exindex 9b832a59db..5c84b642a2 100644--- a/lib/plausible/data_migration/site_imports.ex+++ b/lib/plausible/data_migration/site_imports.ex@@ -141,7 +141,9 @@ defmodule Plausible.DataMigration.SiteImports dodefp insert!(changeset, true = _dry_run?) doif changeset.valid? do- Ecto.Changeset.apply_changes(changeset)+ changeset+ |> Ecto.Changeset.change(id: 0)+ |> Ecto.Changeset.apply_changes()elseraise "Invalid insert: #{inspect(changeset)}"enddiff --git a/test/plausible/data_migration/site_imports_test.exs b/test/plausible/data_migration/site_imports_test.exsindex 55b8059e89..c8e48d0d3a 100644--- a/test/plausible/data_migration/site_imports_test.exs+++ b/test/plausible/data_migration/site_imports_test.exs@@ -50,6 +50,24 @@ defmodule Plausible.DataMigration.SiteImportsTest doassert site_import.source == :universal_analyticsend+ test "runs in dry mode without making any persistent changes" do+ site =+ insert(:site)+ |> Site.start_import(~D[2021-01-02], ~D[2021-01-08], "Google Analytics", "ok")+ |> Repo.update!()++ populate_stats(site, 0, [+ build(:imported_visitors, date: ~D[2021-01-07])+ ])++ assert capture_io(fn ->+ assert :ok = SiteImports.run()+ end) =~ "Processing 1 sites"++ assert [%{id: id, legacy: true}] = Imported.list_all_imports(site)+ assert id == 0+ end+test "does not set end date to latter than the current one" dosite =insert(:site)