Skip to content

Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.

added a test and changed hashmode condition (#2082)

RobertJoonasa058cf624016
diff --git a/lib/plausible_web/controllers/api/external_controller.ex b/lib/plausible_web/controllers/api/external_controller.ex
index 871db3cb29..a6282fd95a 100644
--- a/lib/plausible_web/controllers/api/external_controller.ex
+++ b/lib/plausible_web/controllers/api/external_controller.ex
@@ -273,7 +273,7 @@ defmodule PlausibleWeb.Api.ExternalController do
|> URI.decode()
|> String.trim_trailing()
- if hash_mode && uri.fragment do
+ if hash_mode == 1 && uri.fragment do
pathname <> "#" <> URI.decode(uri.fragment)
else
pathname
diff --git a/test/plausible_web/controllers/api/external_controller_test.exs b/test/plausible_web/controllers/api/external_controller_test.exs
index 87e497a362..8a1b777f0f 100644
--- a/test/plausible_web/controllers/api/external_controller_test.exs
+++ b/test/plausible_web/controllers/api/external_controller_test.exs
@@ -842,6 +842,22 @@ defmodule PlausibleWeb.Api.ExternalControllerTest do
assert pageview.pathname == "/#page-a"
end
+ test "does not record hash when hash mode is 0", %{conn: conn} do
+ params = %{
+ n: "pageview",
+ u: "http://www.example.com/#page-a",
+ d: "external-controller-test-hash-0.com",
+ h: 0
+ }
+
+ conn
+ |> post("/api/event", params)
+
+ pageview = get_event("external-controller-test-hash-0.com")
+
+ assert pageview.pathname == "/"
+ end
+
test "decodes URL pathname, fragment and search", %{conn: conn} do
params = %{
n: "pageview",