Skip to content

Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.

Ignore `visit:channel` when transforming filters for GSC (#5678)

Adrian Gruntkowskia2c863b2cc9b
diff --git a/lib/plausible/google/search_console/filters.ex b/lib/plausible/google/search_console/filters.ex
index 1874e16403..1ea9c4a8fa 100644
--- a/lib/plausible/google/search_console/filters.ex
+++ b/lib/plausible/google/search_console/filters.ex
@@ -53,6 +53,8 @@ defmodule Plausible.Google.SearchConsole.Filters do
defp transform_filter(_, [_, "visit:source" | _rest]), do: :ignore
+ defp transform_filter(_, [_, "visit:channel" | _rest]), do: :ignore
+
defp transform_filter(_, _filter), do: :unsupported
defp property_url("sc-domain:" <> domain, page), do: "https://" <> domain <> page
diff --git a/test/plausible/google/search_console/filters_test.exs b/test/plausible/google/search_console/filters_test.exs
index d056dfb2e6..12924cf7ec 100644
--- a/test/plausible/google/search_console/filters_test.exs
+++ b/test/plausible/google/search_console/filters_test.exs
@@ -186,6 +186,24 @@ defmodule Plausible.Google.SearchConsole.FiltersTest do
]
end
+ test "visit:source and visit:channel filters are ignored" do
+ filters = [
+ [:is, "visit:source", ["Google"]],
+ [:is, "visit:channel", ["Organic search"]],
+ [:is, "visit:screen", ["Desktop"]]
+ ]
+
+ {:ok, transformed} = Filters.transform("sc-domain:plausible.io", filters, "")
+
+ assert transformed == [
+ %{
+ filters: [
+ %{dimension: "device", operator: "includingRegex", expression: "DESKTOP"}
+ ]
+ }
+ ]
+ end
+
test "when unsupported filter is included the whole set becomes invalid" do
filters = [
[:matches_wildcard, "visit:entry_page", "*web-analytics*"],