Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.
TypeScript analyticsanalytics-dashboardclickhouseelixirgoogle-analyticsmarketingopen-source-analyticsphoenixplausible-analyticspostgresqlprivacyprivacy-friendlyself-hostedsimple-analyticsstatisticstailwindcssweb-analyticswebsite-analyticswebsite-statswebsite-tracking
Don't crash ingesting >1M bytes payloads (#4872)
hq1a47a9adfbc50
diff --git a/lib/plausible/ingestion/request.ex b/lib/plausible/ingestion/request.exindex 7e48ae7e52..1cc18dd358 100644--- a/lib/plausible/ingestion/request.ex+++ b/lib/plausible/ingestion/request.ex@@ -112,10 +112,12 @@ defmodule Plausible.Ingestion.Request dodefp parse_body(conn) docase conn.body_params do%Plug.Conn.Unfetched{} ->- {:ok, body, _conn} = Plug.Conn.read_body(conn)-- case Jason.decode(body) do- {:ok, params} when is_map(params) -> {:ok, params}+ with max_length <- conn.assigns[:read_body_limit] || 1_000_000,+ {:ok, body, _conn} <-+ Plug.Conn.read_body(conn, length: max_length, read_length: max_length),+ {:ok, params} when is_map(params) <- Jason.decode(body) do+ {:ok, params}+ else_ -> {:error, :invalid_json}enddiff --git a/test/plausible/ingestion/request_test.exs b/test/plausible/ingestion/request_test.exsindex 23fd6c4d18..f4c02fa865 100644--- a/test/plausible/ingestion/request_test.exs+++ b/test/plausible/ingestion/request_test.exs@@ -429,6 +429,31 @@ defmodule Plausible.Ingestion.RequestTest doassert changeset.errors[:request]end+ test "long body length" do+ payload = """+ {+ "name": "pageview",+ "domain": "dummy.site",+ "url": "#{:binary.copy("a", 1_000)}"+ }+ """++ within_read_limit =+ :post+ |> build_conn("/api/events", payload)+ |> Request.build()++ assert {:ok, _} = within_read_limit++ exceeding_read_limit =+ :post+ |> build_conn("/api/events", payload)+ |> Plug.Conn.assign(:read_body_limit, 800)+ |> Request.build()++ assert {:error, _} = exceeding_read_limit+ end+@tag :ee_onlytest "encodable" doparams = %{