Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.
TypeScript analyticsanalytics-dashboardclickhouseelixirgoogle-analyticsmarketingopen-source-analyticsphoenixplausible-analyticspostgresqlprivacyprivacy-friendlyself-hostedsimple-analyticsstatisticstailwindcssweb-analyticswebsite-analyticswebsite-statswebsite-tracking
Inflate sampled results in Stats.Funnel.funnel/3 (#3270)
Uku Tahtab4eb7510984
diff --git a/lib/plausible/stats/funnel.ex b/lib/plausible/stats/funnel.exindex 34a5108303..d9c497cee6 100644--- a/lib/plausible/stats/funnel.ex+++ b/lib/plausible/stats/funnel.ex@@ -10,6 +10,7 @@ defmodule Plausible.Stats.Funnel doalias Plausible.Funnelsimport Ecto.Query+ import Plausible.Stats.Fragmentsalias Plausible.ClickhouseRepoalias Plausible.Stats.Base@@ -60,7 +61,7 @@ defmodule Plausible.Stats.Funnel dodefp query_funnel(query, funnel_definition) doq_events =from(e in query,- select: %{user_id: e.user_id},+ select: %{user_id: e.user_id, _sample_factor: fragment("any(_sample_factor)")},where: e.site_id == ^funnel_definition.site_id,group_by: e.user_id,order_by: [desc: fragment("step")]@@ -69,7 +70,7 @@ defmodule Plausible.Stats.Funnel doquery =from(f in subquery(q_events),- select: {f.step, count(1)},+ select: {f.step, total()},group_by: f.step)diff --git a/test/plausible/funnels_test.exs b/test/plausible/funnels_test.exsindex dbb0e0c763..ece96bf6cf 100644--- a/test/plausible/funnels_test.exs+++ b/test/plausible/funnels_test.exs@@ -321,5 +321,35 @@ defmodule Plausible.FunnelsTest do]}} = funnel_dataend++ @tag :slow+ test "sampling", %{site: site, steps: [g1, g2, g3 | _]} do+ {:ok, funnel} =+ Funnels.create(+ site,+ "From blog to signup and purchase",+ [g1, g2, g3]+ )++ stats =+ 1..50_000+ |> Enum.flat_map(fn _ ->+ user_id = SipHash.hash!("0123456789ABCDEF", :crypto.strong_rand_bytes(64))++ [+ build(:pageview, pathname: "/go/to/blog/foo", user_id: user_id),+ build(:event, name: "Signup", user_id: user_id),+ build(:pageview, pathname: "/checkout", user_id: user_id)+ ]+ end)++ populate_stats(site, stats)++ query =+ Plausible.Stats.Query.from(site, %{"period" => "all", "sample_threshold" => "10000"})++ {:ok, funnel_data} = Stats.funnel(site, query, funnel.id)+ assert_in_delta funnel_data[:all_visitors], 50_000, 1000+ endendend