Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.
TypeScript analyticsanalytics-dashboardclickhouseelixirgoogle-analyticsmarketingopen-source-analyticsphoenixplausible-analyticspostgresqlprivacyprivacy-friendlyself-hostedsimple-analyticsstatisticstailwindcssweb-analyticswebsite-analyticswebsite-statswebsite-tracking
CRM: implement basic SSO audit browser (#5586)
Adam Rutkowskiafbc350b8d42
diff --git a/extra/lib/plausible/audit/entry.ex b/extra/lib/plausible/audit/entry.exindex 3890176ac2..d978a8518d 100644--- a/extra/lib/plausible/audit/entry.ex+++ b/extra/lib/plausible/audit/entry.ex@@ -67,6 +67,13 @@ defmodule Plausible.Audit.Entry do|> put_change(:change, Plausible.Audit.encode(struct, raise_on_not_loaded?: false))end+ def include_change(audit_entry, map) when is_map(map) do+ # sometimes a hand-crafted map is passed; we don't need to encode then+ audit_entry+ |> change()+ |> put_change(:change, map)+ end+def persist!(entry) doPlausible.Repo.insert!(entry)enddiff --git a/extra/lib/plausible/auth/sso/domain.ex b/extra/lib/plausible/auth/sso/domain.exindex f681736e45..572026eba5 100644--- a/extra/lib/plausible/auth/sso/domain.ex+++ b/extra/lib/plausible/auth/sso/domain.ex@@ -11,7 +11,6 @@ defmodule Plausible.Auth.SSO.Domain dorecorded."""- use Plausibleuse Ecto.Schemaimport Ecto.Changeset@@ -28,11 +27,9 @@ defmodule Plausible.Auth.SSO.Domain douse Plausible.Auth.SSO.Domain.Status- on_ee do- @derive {Plausible.Audit.Encoder,- only: [:id, :identifier, :domain, :verified_via, :status, :sso_integration],- allow_not_loaded: [:sso_integration]}- end+ @derive {Plausible.Audit.Encoder,+ only: [:id, :identifier, :domain, :verified_via, :status, :sso_integration],+ allow_not_loaded: [:sso_integration]}schema "sso_domains" dofield :identifier, Ecto.UUIDdiff --git a/extra/lib/plausible/auth/sso/domains.ex b/extra/lib/plausible/auth/sso/domains.exindex b090fd3649..dee39c5c93 100644--- a/extra/lib/plausible/auth/sso/domains.ex+++ b/extra/lib/plausible/auth/sso/domains.ex@@ -128,6 +128,7 @@ defmodule Plausible.Auth.SSO.Domains do@spec remove(SSO.Domain.t(), Keyword.t()) :::ok | {:error, :force_sso_enabled | :sso_users_present}def remove(sso_domain, opts \\ []) do+ sso_domain = Repo.preload(sso_domain, :sso_integration)force_deprovision? = Keyword.get(opts, :force_deprovision?, false)check = check_can_remove(sso_domain)@@ -136,7 +137,10 @@ defmodule Plausible.Auth.SSO.Domains do{:ok, _} ->{:ok, :ok} =Repo.transaction(fn ->- Repo.delete!(sso_domain)+ Repo.delete_with_audit!(sso_domain, "sso_domain_removed", %{+ team_id: sso_domain.sso_integration.team_id+ })+:ok = cancel_verification(sso_domain.domain)end)@@ -147,7 +151,11 @@ defmodule Plausible.Auth.SSO.Domains doRepo.transaction(fn ->domain_users = users_by_domain(sso_domain)Enum.each(domain_users, &SSO.deprovision_user!/1)- Repo.delete!(sso_domain)++ Repo.delete_with_audit!(sso_domain, "sso_domain_removed", %{+ team_id: sso_domain.sso_integration.team_id+ })+cancel_verification(sso_domain.domain)end)diff --git a/extra/lib/plausible/auth/sso/identity.ex b/extra/lib/plausible/auth/sso/identity.exindex b663e61feb..1a0c3e538c 100644--- a/extra/lib/plausible/auth/sso/identity.ex+++ b/extra/lib/plausible/auth/sso/identity.ex@@ -5,6 +5,7 @@ defmodule Plausible.Auth.SSO.Identity do@type t() :: %__MODULE__{}+ @derive Plausible.Audit.Encoder@enforce_keys [:id, :integration_id, :name, :email, :expires_at]defstruct [:id, :integration_id, :name, :email, :expires_at]enddiff --git a/extra/lib/plausible/auth/sso/integration.ex b/extra/lib/plausible/auth/sso/integration.exindex 853f5da0fe..885e31af81 100644--- a/extra/lib/plausible/auth/sso/integration.ex+++ b/extra/lib/plausible/auth/sso/integration.ex@@ -10,7 +10,6 @@ defmodule Plausible.Auth.SSO.Integration dowhen configuring external services like IdPs."""- use Plausibleuse Ecto.Schemaimport Ecto.Changeset@@ -21,9 +20,7 @@ defmodule Plausible.Auth.SSO.Integration do@type t() :: %__MODULE__{}- on_ee do- @derive {Plausible.Audit.Encoder, only: [:id, :identifier]}- end+ @derive {Plausible.Audit.Encoder, only: [:id, :identifier]}schema "sso_integrations" dofield :identifier, Ecto.UUIDdiff --git a/extra/lib/plausible/auth/sso/saml_config.ex b/extra/lib/plausible/auth/sso/saml_config.exindex 634fb8aa57..07071660d8 100644--- a/extra/lib/plausible/auth/sso/saml_config.ex+++ b/extra/lib/plausible/auth/sso/saml_config.ex@@ -10,7 +10,6 @@ defmodule Plausible.Auth.SSO.SAMLConfig dofrom IdP again."""- use Plausibleuse Ecto.Schemaalias Plausible.Auth.SSO@@ -22,10 +21,8 @@ defmodule Plausible.Auth.SSO.SAMLConfig do@fields [:idp_signin_url, :idp_entity_id, :idp_cert_pem, :idp_metadata]@required_fields @fields -- [:idp_metadata]- on_ee do- @derive {Plausible.Audit.Encoder,- only: [:id, :idp_signin_url, :idp_entity_id, :idp_cert_pem, :idp_metadata]}- end+ @derive {Plausible.Audit.Encoder,+ only: [:id, :idp_signin_url, :idp_entity_id, :idp_cert_pem, :idp_metadata]}embedded_schema dofield :idp_signin_url, :stringdiff --git a/extra/lib/plausible_web/live/customer_support/live/team.ex b/extra/lib/plausible_web/live/customer_support/live/team.exindex 35da3130a2..8ebc4a50bc 100644--- a/extra/lib/plausible_web/live/customer_support/live/team.ex+++ b/extra/lib/plausible_web/live/customer_support/live/team.ex@@ -43,6 +43,36 @@ defmodule PlausibleWeb.CustomerSupport.Live.Team do{:ok, assign(socket, tab: "sso")}end+ def update(%{tab: "audit"}, %{assigns: %{team: team}} = socket) do+ audit_entries = Plausible.Audit.list_entries(team_id: team.id)++ audit_entries =+ Enum.map(audit_entries, fn entry ->+ meta = entry.meta++ meta =+ if entry.user_id && entry.user_id > 0 do+ user = Plausible.Repo.get!(Plausible.Auth.User, entry.user_id)+ Map.put(meta, :user, user)+ else+ meta+ end++ meta =+ if entry.entity == "Plausible.Auth.User" do+ user = Plausible.Repo.get!(Plausible.Auth.User, String.to_integer(entry.entity_id))+ Map.put(meta, :entity, user)+ else+ meta+ end++ Map.put(entry, :meta, meta)+ end)++ {:ok,+ assign(socket, tab: "audit", audit_entries: audit_entries, revealed_audit_entry_id: nil)}+ end+def update(%{tab: "sites"}, %{assigns: %{team: team}} = socket) dosites = Teams.owned_sites(team, 100)sites_count = Teams.owned_sites_count(team)@@ -179,6 +209,9 @@ defmodule PlausibleWeb.CustomerSupport.Live.Team do<.tab to="billing" tab={@tab}>Billing</.tab>+ <.tab to="audit" tab={@tab}>+ Audit+ </.tab></nav></div></div>@@ -295,6 +328,87 @@ defmodule PlausibleWeb.CustomerSupport.Live.Team do</.table></div>+ <div :if={@tab == "audit"} class="mt-4 mb-4 text-gray-900 dark:text-gray-400 relative">+ <div :if={Enum.empty?(@audit_entries)} class="flex justify-center items-center">+ No audit logs yet+ </div>+ <div :if={@revealed_audit_entry_id}>+ <.input_with_clipboard+ id="audit-entry-identifier"+ name="audit-entry-identifier"+ label="Audit Entry Identifier"+ value={@revealed_audit_entry_id}+ />+ <div class="relative">+ <.input+ rows="16"+ type="textarea"+ id="audit-entry-change"+ name="audit-entry-change"+ value={+ Jason.encode!(+ Enum.find(@audit_entries, &(&1.id == @revealed_audit_entry_id)).change,+ pretty: true+ )+ }+ >+ </.input>+ <.styled_link+ class="text-sm float-right"+ onclick="var textarea = document.getElementById('audit-entry-change'); textarea.focus(); textarea.select(); document.execCommand('copy');"+ href="#"+ >+ <div class="flex items-center absolute top-4 right-4 text-xs gap-x-1">+ <Heroicons.document_duplicate class="h-4 w-4 text-indigo-700" /> COPY+ </div>+ </.styled_link>++ <.styled_link+ phx-click="reveal-audit-entry"+ phx-target={@myself}+ class="float-right pt-4 text-sm"+ >+ ← Return+ </.styled_link>+ </div>+ </div>+ <.table :if={is_nil(@revealed_audit_entry_id)} rows={@audit_entries}>+ <:thead>+ <.th invisible></.th>+ <.th invisible></.th>+ <.th>Name</.th>+ <.th>Entity</.th>+ <.th>Actor</.th>+ <.th invisible>Actions</.th>+ </:thead>+ <:tbody :let={entry}>+ <.td>{Calendar.strftime(entry.datetime, "%Y-%m-%d")}</.td>+ <.td>{Calendar.strftime(entry.datetime, "%H:%M:%S")}</.td>+ <.td class="font-mono">{entry.name}</.td>+ <.td truncate>+ <.audit_entity entry={entry} />+ </.td>+ <.td :if={entry.actor_type == :system}>+ <div class="flex items-center gap-x-1">+ <Heroicons.cog_6_tooth class="size-4" /> SYSTEM+ </div>+ </.td>+ <.td :if={entry.actor_type == :user} truncate>+ <.audit_user user={entry.meta.user} />+ </.td>++ <.td actions>+ <.edit_button+ phx-click="reveal-audit-entry"+ icon={:magnifying_glass_plus}+ phx-value-id={entry.id}+ phx-target={@myself}+ />+ </.td>+ </:tbody>+ </.table>+ </div>+<div :if={@tab == "billing"} class="mt-4 mb-4 text-gray-900 dark:text-gray-400"><h1 class="text-xs font-semibold">Usage</h1><.table rows={monthly_pageviews_usage(@usage.monthly_pageviews, @limits.monthly_pageviews)}>@@ -653,6 +767,14 @@ defmodule PlausibleWeb.CustomerSupport.Live.Team do"""end+ def handle_event("reveal-audit-entry", %{"id" => id}, socket) do+ {:noreply, assign(socket, revealed_audit_entry_id: id)}+ end++ def handle_event("reveal-audit-entry", _, socket) do+ {:noreply, assign(socket, revealed_audit_entry_id: nil)}+ end+def handle_event("show-plan-form", _, socket) do{:noreply, assign(socket, show_plan_form?: true, editing_plan: nil)}end@@ -1092,4 +1214,40 @@ defmodule PlausibleWeb.CustomerSupport.Live.Team doassign(socket, team_layout: team_layout, session_counts: session_counts, tab: "members")end++ attr :entry, Plausible.Audit.Entry++ defp audit_entity(assigns) do+ ~H"""+ <%= if @entry.entity == "Plausible.Auth.User" do %>+ <.audit_user user={@entry.meta.entity} />+ <% else %>+ {@entry.entity |> String.split(".") |> List.last()} #{String.slice(@entry.entity_id, 0, 8)}+ <% end %>+ """+ end++ attr :user, Plausible.Auth.User++ defp audit_user(assigns) do+ ~H"""+ <div class="flex items-center gap-x-1">+ <img+ class="w-4"+ src={+ Plausible.Auth.User.profile_img_url(%Plausible.Auth.User{+ email: @user.email+ })+ }+ />++ <.styled_link+ patch={"/cs/users/user/#{@user.id}"}+ class="cursor-pointer flex block items-center"+ >+ {@user.name}+ </.styled_link>+ </div>+ """+ endenddiff --git a/extra/lib/plausible_web/live/customer_support/live/user.ex b/extra/lib/plausible_web/live/customer_support/live/user.exindex ef7c0d0690..a70480110e 100644--- a/extra/lib/plausible_web/live/customer_support/live/user.ex+++ b/extra/lib/plausible_web/live/customer_support/live/user.ex@@ -44,7 +44,12 @@ defmodule PlausibleWeb.CustomerSupport.Live.User do</div><div class="mt-4 text-center sm:mt-0 sm:pt-1 sm:text-left"><p class="text-xl font-bold sm:text-2xl">- {@user.name}+ <div class="flex items-center gap-x-2">+ {@user.name}+ <span :if={@user.type == :sso} class="bg-green-700 text-gray-100 text-xs p-1 rounded">+ SSO+ </span>+ </div></p><p class="text-sm font-medium"><span>{@user.email}</span>diff --git a/extra/lib/plausible_web/sso/fake_saml_adapter.ex b/extra/lib/plausible_web/sso/fake_saml_adapter.exindex 4bdb99f82f..6a3569b15e 100644--- a/extra/lib/plausible_web/sso/fake_saml_adapter.ex+++ b/extra/lib/plausible_web/sso/fake_saml_adapter.ex@@ -47,6 +47,11 @@ defmodule PlausibleWeb.SSO.FakeSAMLAdapter do}end+ "sso_login_success"+ |> Plausible.Audit.Entry.new(identity, %{team_id: integration.team.id})+ |> Plausible.Audit.Entry.include_change(identity)+ |> Plausible.Audit.Entry.persist!()+PlausibleWeb.UserAuth.log_in_user(conn, identity, params["return_to"]){:error, :not_found} ->diff --git a/extra/lib/plausible_web/sso/real_saml_adapter.ex b/extra/lib/plausible_web/sso/real_saml_adapter.exindex ac3fb00e2f..e81fa2d676 100644--- a/extra/lib/plausible_web/sso/real_saml_adapter.ex+++ b/extra/lib/plausible_web/sso/real_saml_adapter.ex@@ -100,20 +100,30 @@ defmodule PlausibleWeb.SSO.RealSAMLAdapter doexpires_at: expires_at}+ "sso_login_success"+ |> Plausible.Audit.Entry.new(identity, %{team_id: integration.team.id})+ |> Plausible.Audit.Entry.include_change(identity)+ |> Plausible.Audit.Entry.persist!()+PlausibleWeb.UserAuth.log_in_user(conn, identity, cookie.return_to)else+ {:error, :not_found} ->+ login_error(conn, cookie, "Wrong email")+{:error, reason} ->- conn- |> Phoenix.Controller.put_flash(:login_error, error_by_reason(reason))- |> Phoenix.Controller.redirect(- to: Routes.sso_path(conn, :login_form, return_to: cookie.return_to)- )+ with {:ok, integration} <- SSO.get_integration(integration_id) do+ "sso_login_failure"+ |> Plausible.Audit.Entry.new(integration, %{team_id: integration.team.id})+ |> Plausible.Audit.Entry.include_change(%{+ error: inspect(reason)+ })+ |> Plausible.Audit.Entry.persist!()+ end++ login_error(conn, cookie, "Authentication failed (reason: #{inspect(reason)})")endend- defp error_by_reason(:not_found), do: "Wrong email."- defp error_by_reason(reason), do: "Authentication failed (reason: #{inspect(reason)})."-defp convert_pem_cert(cert) docase X509.Certificate.from_pem(cert) do{:ok, cert} -> {:ok, cert}@@ -216,4 +226,12 @@ defmodule PlausibleWeb.SSO.RealSAMLAdapter dosame_site: "None")end++ defp login_error(conn, cookie, login_error) do+ conn+ |> Phoenix.Controller.put_flash(:login_error, login_error)+ |> Phoenix.Controller.redirect(+ to: Routes.sso_path(conn, :login_form, return_to: cookie.return_to)+ )+ endenddiff --git a/lib/plausible_web/live/components/form.ex b/lib/plausible_web/live/components/form.exindex 5b0d093920..2c99c15cb0 100644--- a/lib/plausible_web/live/components/form.ex+++ b/lib/plausible_web/live/components/form.ex@@ -155,7 +155,7 @@ defmodule PlausibleWeb.Live.Components.Form do<.label class="mb-2" for={@id}>{@label}</.label><textareaid={@id}- rows="6"+ rows={@rest[:rows] || "6"}name={@name}class="block w-full textarea border-1 border-gray-300 rounded-md p-4 text-sm text-gray-700 dark:border-gray-500 dark:bg-gray-900 dark:text-gray-300"{@rest}diff --git a/test/plausible/audit_test.exs b/test/plausible/audit_test.exsindex 589ac01bfa..445310bb86 100644--- a/test/plausible/audit_test.exs+++ b/test/plausible/audit_test.exs@@ -176,6 +176,14 @@ defmodule Plausible.AuditTest doentry = Entry.include_change(entry, changeset)assert entry.changes.change == %{after: %{name: "baz"}, before: %{name: "bar", id: 1}}end++ test "include_change/2 accepts raw map" do+ struct = %TestSchema{id: 1, name: "bar"}++ entry = Entry.new("update", struct)+ entry = Entry.include_change(entry, %{foo: :bar})+ assert entry.changes.change == %{foo: :bar}+ endenddescribe "Repo integration" dodiff --git a/test/plausible/auth/sso/domains_test.exs b/test/plausible/auth/sso/domains_test.exsindex 4b6c3929dc..854bbb5407 100644--- a/test/plausible/auth/sso/domains_test.exs+++ b/test/plausible/auth/sso/domains_test.exs@@ -250,12 +250,6 @@ defmodule Plausible.Auth.SSO.DomainsTest do{:ok, domain: domain, sso_domain: sso_domain}end- test "returns ok when all conditions met", %{sso_domain: sso_domain} do- assert :ok = SSO.Domains.remove(sso_domain)-- refute Repo.reload(sso_domain)- end-test "returns ok when force SSO enabled and SSO users on other domains present", %{team: team,integration: integration,@@ -312,6 +306,8 @@ defmodule Plausible.Auth.SSO.DomainsTest dotest "removes the domain if conditions met", %{sso_domain: sso_domain} doassert :ok = SSO.Domains.remove(sso_domain)refute Repo.reload(sso_domain)++ assert audited_entry("sso_domain_removed", team_id: sso_domain.sso_integration.team_id)endtest "fails to remove the domain whenSSO users present on it", %{@@ -346,6 +342,8 @@ defmodule Plausible.Auth.SSO.DomainsTest dorefute sso_user.sso_identity_idrefute sso_user.sso_integration_idrefute sso_user.sso_domain_id++ assert audited_entry("sso_domain_removed", team_id: sso_domain.sso_integration.team_id)endtest "fails to remove when force SSO enabled with SSO users only on that domain", %{diff --git a/test/plausible_web/controllers/sso_controller_sync_test.exs b/test/plausible_web/controllers/sso_controller_sync_test.exsindex e9a5d50c47..09d04f7ffa 100644--- a/test/plausible_web/controllers/sso_controller_sync_test.exs+++ b/test/plausible_web/controllers/sso_controller_sync_test.exs@@ -331,6 +331,11 @@ defmodule PlausibleWeb.SSOControllerSyncTest doassert NaiveDateTime.compare(user_session.timeout_at, timeout_threshold_lower) == :gtassert NaiveDateTime.compare(user_session.timeout_at, timeout_threshold_upper) == :lt++ assert entry = audited_entry("sso_login_success", team_id: integration.team_id)+ assert entry.change["email"] == "[email protected]"+ assert entry.change["name"] == "Jane Smith"+ assert entry.change["integration_id"] == integration.identifierendtest "redirects with error when no matching integration found", %{@@ -346,7 +351,7 @@ defmodule PlausibleWeb.SSOControllerSyncTest doassert redirected_to(conn, 302) == Routes.sso_path(conn, :login_form, return_to: "/sites")- assert Phoenix.Flash.get(conn.assigns.flash, :login_error) == "Wrong email."+ assert Phoenix.Flash.get(conn.assigns.flash, :login_error) == "Wrong email"endtest "redirects with error on mismatch of RelayState", %{@@ -363,7 +368,14 @@ defmodule PlausibleWeb.SSOControllerSyncTest doassert redirected_to(conn, 302) == Routes.sso_path(conn, :login_form, return_to: "/sites")assert Phoenix.Flash.get(conn.assigns.flash, :login_error) ==- "Authentication failed (reason: :invalid_relay_state)."+ "Authentication failed (reason: :invalid_relay_state)"++ assert audited_entry("sso_login_failure",+ team_id: integration.team_id,+ change: %{+ "error" => ":invalid_relay_state"+ }+ )endtest "redirects with error on missing relay state", %{@@ -377,7 +389,14 @@ defmodule PlausibleWeb.SSOControllerSyncTest doassert redirected_to(conn, 302) == Routes.sso_path(conn, :login_form, return_to: "/sites")assert Phoenix.Flash.get(conn.assigns.flash, :login_error) ==- "Authentication failed (reason: :invalid_relay_state)."+ "Authentication failed (reason: :invalid_relay_state)"++ assert audited_entry("sso_login_failure",+ team_id: integration.team_id,+ change: %{+ "error" => ":invalid_relay_state"+ }+ )endtest "redirects with error on malformed assertion", %{@@ -395,7 +414,14 @@ defmodule PlausibleWeb.SSOControllerSyncTest doassert redirected_to(conn, 302) == Routes.sso_path(conn, :login_form, return_to: "/sites")assert Phoenix.Flash.get(conn.assigns.flash, :login_error) ==- "Authentication failed (reason: :base64_decoding_failed)."+ "Authentication failed (reason: :base64_decoding_failed)"++ assert audited_entry("sso_login_failure",+ team_id: integration.team_id,+ change: %{+ "error" => ":base64_decoding_failed"+ }+ )endtest "redirects with error on malformed certificate in config (should not happen)", %{@@ -421,7 +447,14 @@ defmodule PlausibleWeb.SSOControllerSyncTest doassert redirected_to(conn, 302) == Routes.sso_path(conn, :login_form, return_to: "/sites")assert Phoenix.Flash.get(conn.assigns.flash, :login_error) ==- "Authentication failed (reason: :malformed_certificate)."+ "Authentication failed (reason: :malformed_certificate)"++ assert audited_entry("sso_login_failure",+ team_id: integration.team_id,+ change: %{+ "error" => ":malformed_certificate"+ }+ )endtest "redirects with error on mismatched certificate in config", %{@@ -441,7 +474,14 @@ defmodule PlausibleWeb.SSOControllerSyncTest doassert redirected_to(conn, 302) == Routes.sso_path(conn, :login_form, return_to: "/sites")assert Phoenix.Flash.get(conn.assigns.flash, :login_error) ==- "Authentication failed (reason: :digest_verification_failed)."+ "Authentication failed (reason: :digest_verification_failed)"++ assert audited_entry("sso_login_failure",+ team_id: integration.team_id,+ change: %{+ "error" => ":digest_verification_failed"+ }+ )endtest "redirects with error on missing email attribute in assertion", %{@@ -459,7 +499,14 @@ defmodule PlausibleWeb.SSOControllerSyncTest doassert redirected_to(conn, 302) == Routes.sso_path(conn, :login_form, return_to: "/sites")assert Phoenix.Flash.get(conn.assigns.flash, :login_error) ==- "Authentication failed (reason: :missing_email_attribute)."+ "Authentication failed (reason: :missing_email_attribute)"++ assert audited_entry("sso_login_failure",+ team_id: integration.team_id,+ change: %{+ "error" => ":missing_email_attribute"+ }+ )endtest "redirects with error on invalid email attribute in assertion", %{@@ -477,7 +524,14 @@ defmodule PlausibleWeb.SSOControllerSyncTest doassert redirected_to(conn, 302) == Routes.sso_path(conn, :login_form, return_to: "/sites")assert Phoenix.Flash.get(conn.assigns.flash, :login_error) ==- "Authentication failed (reason: :invalid_email_attribute)."+ "Authentication failed (reason: :invalid_email_attribute)"++ assert audited_entry("sso_login_failure",+ team_id: integration.team_id,+ change: %{+ "error" => ":invalid_email_attribute"+ }+ )endtest "redirects with error on missing name attributes in assertion", %{@@ -495,7 +549,14 @@ defmodule PlausibleWeb.SSOControllerSyncTest doassert redirected_to(conn, 302) == Routes.sso_path(conn, :login_form, return_to: "/sites")assert Phoenix.Flash.get(conn.assigns.flash, :login_error) ==- "Authentication failed (reason: :missing_name_attributes)."+ "Authentication failed (reason: :missing_name_attributes)"++ assert audited_entry("sso_login_failure",+ team_id: integration.team_id,+ change: %{+ "error" => ":missing_name_attributes"+ }+ )endenddiff --git a/test/plausible_web/live/customer_support/teams_test.exs b/test/plausible_web/live/customer_support/teams_test.exsindex c76bde5a57..866ebf2916 100644--- a/test/plausible_web/live/customer_support/teams_test.exs+++ b/test/plausible_web/live/customer_support/teams_test.exs@@ -616,5 +616,48 @@ defmodule PlausibleWeb.Live.CustomerSupport.TeamsTest doassert to == "/cs/teams/team/#{team.id}"endend++ describe "audit" do+ setup [:create_user, :log_in, :create_site]++ setup %{user: user} do+ patch_env(:super_admin_user_ids, [user.id])+ end++ test "audit tab is present", %{conn: conn, user: user} do+ team = team_of(user)+ {:ok, _lv, html} = live(conn, open_team(team.id))+ assert element_exists?(html, ~s|a[href="?tab=audit"]|)+ end++ test "shows audit entries", %{conn: conn, user: user} do+ team = team_of(user)++ entry =+ %Plausible.Audit.Entry{+ name: "Reveal Test",+ entity: "Plausible.Teams.Team",+ entity_id: to_string(team.id),+ change: %{"foo" => "bar"},+ team_id: team.id,+ datetime: NaiveDateTime.utc_now()+ }+ |> Plausible.Repo.insert!()++ {:ok, lv, _html} = live(conn, open_team(team.id, tab: :audit))++ html = render(lv)++ assert html =~ "Reveal Test"++ html =+ lv+ |> element(~s|button[phx-click="reveal-audit-entry"][phx-value-id="#{entry.id}"]|)+ |> render_click()++ assert text_of_element(html, ~s|textarea|) ==+ "{ &quot;foo&quot;: &quot;bar&quot; }"+ end+ endendenddiff --git a/test/support/teams/test.ex b/test/support/teams/test.exindex 5a98aa663c..7873019489 100644--- a/test/support/teams/test.ex+++ b/test/support/teams/test.ex@@ -414,8 +414,8 @@ defmodule Plausible.Teams.Test doattrs = Keyword.put(attrs, :name, name)case Plausible.Audit.list_entries(attrs) do- [_] ->- true+ [entry] ->+ entry_ ->raise "Expected audited entry #{inspect(attrs)} but only found #{inspect(Plausible.Audit.list_entries([]), pretty: true)}."@@ -426,8 +426,8 @@ defmodule Plausible.Teams.Test doattrs = Keyword.put(attrs, :name, name)case Plausible.Audit.list_entries(attrs) do- l when is_list(l) and length(l) == length ->- true+ entries when is_list(entries) and length(entries) == length ->+ entries_ ->raise "Expected audited entry #{inspect(attrs)} but only found #{inspect(Plausible.Audit.list_entries([]), pretty: true)}."