Skip to content

Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.

Fix flaky google import API tests due to hardcoded import ID (#3994)

Adrian Gruntkowskibb108450cb31
diff --git a/test/plausible/google/api_test.exs b/test/plausible/google/api_test.exs
index e91801a3c3..99bc350c6d 100644
--- a/test/plausible/google/api_test.exs
+++ b/test/plausible/google/api_test.exs
@@ -39,8 +39,10 @@ defmodule Plausible.Google.APITest do
{:ok, buffer} = Plausible.Imported.Buffer.start_link()
+ site_import = insert(:site_import)
+
persist_fn = fn table, rows ->
- records = UniversalAnalytics.from_report(rows, site.id, _import_id = 123, table)
+ records = UniversalAnalytics.from_report(rows, site.id, site_import.id, table)
Plausible.Imported.Buffer.insert_many(buffer, table, records)
end
@@ -81,8 +83,10 @@ defmodule Plausible.Google.APITest do
{:ok, buffer} = Plausible.Imported.Buffer.start_link()
+ site_import = insert(:site_import)
+
persist_fn = fn table, rows ->
- records = UniversalAnalytics.from_report(rows, site.id, _import_id = 123, table)
+ records = UniversalAnalytics.from_report(rows, site.id, site_import.id, table)
Plausible.Imported.Buffer.insert_many(buffer, table, records)
end