Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.
TypeScript analyticsanalytics-dashboardclickhouseelixirgoogle-analyticsmarketingopen-source-analyticsphoenixplausible-analyticspostgresqlprivacyprivacy-friendlyself-hostedsimple-analyticsstatisticstailwindcssweb-analyticswebsite-analyticswebsite-statswebsite-tracking
time-on-page-cutoff (#6763)
Marko Saricbc2c7b395cad
diff --git a/lib/plausible/stats/query_optimizer.ex b/lib/plausible/stats/query_optimizer.exindex 34b7762efa..8792bf04f1 100644--- a/lib/plausible/stats/query_optimizer.ex+++ b/lib/plausible/stats/query_optimizer.ex@@ -265,7 +265,7 @@ defmodule Plausible.Stats.QueryOptimizer dotime_on_page_data:Map.merge(query.time_on_page_data, %{include_new_metric: false,- include_legacy_metric: true,+ include_legacy_metric: Legacy.TimeOnPage.can_merge_legacy_time_on_page?(query),cutoff: nil}))diff --git a/test/plausible_web/controllers/api/stats_controller/dashboard_csv_export_test.exs b/test/plausible_web/controllers/api/stats_controller/dashboard_csv_export_test.exsindex 8b8fff10f2..a0029bacba 100644--- a/test/plausible_web/controllers/api/stats_controller/dashboard_csv_export_test.exs+++ b/test/plausible_web/controllers/api/stats_controller/dashboard_csv_export_test.exs@@ -876,6 +876,55 @@ defmodule PlausibleWeb.Api.StatsController.DashboardCsvExportTest do[""]]end++ test "exports visitors.csv when the site has no legacy time on page cutoff",+ %{conn: conn, site: site} do+ site = Plausible.Sites.update_legacy_time_on_page_cutoff!(site, nil)++ populate_stats(site, [+ build(:pageview, user_id: 12, pathname: "/blog", timestamp: ~N[2020-01-05 00:00:00]),+ build(:engagement,+ user_id: 12,+ pathname: "/blog",+ timestamp: ~N[2020-01-05 00:01:00],+ scroll_depth: 40+ ),+ build(:pageview, user_id: 34, pathname: "/blog", timestamp: ~N[2020-01-07 00:00:00])+ ])++ pages =+ conn+ |> do_export(site, %{+ @base_params+ | date_range: "7d",+ relative_date: "2020-01-08",+ filters: [["is", "event:page", ["/blog"]]],+ reports: @page_filtered_reports+ })+ |> response(200)+ |> unzip_and_parse_csv(~c"visitors.csv")++ assert [+ [+ "date",+ "visitors",+ "pageviews",+ "visits",+ "bounce_rate",+ "time_on_page",+ "scroll_depth"+ ]+ | rows+ ] = pages++ assert Enum.find(rows, &match?(["2020-01-05" | _], &1)) |> Enum.take(4) ==+ ["2020-01-05", "1", "1", "1"]++ assert Enum.find(rows, &match?(["2020-01-07" | _], &1)) |> Enum.take(4) ==+ ["2020-01-07", "1", "1", "1"]++ assert Enum.all?(rows, &(&1 == [""] or Enum.at(&1, 5) == ""))+ endenddescribe "POST /api/stats/:domain/export - with a custom prop filter" do