Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.
TypeScript analyticsanalytics-dashboardclickhouseelixirgoogle-analyticsmarketingopen-source-analyticsphoenixplausible-analyticspostgresqlprivacyprivacy-friendlyself-hostedsimple-analyticsstatisticstailwindcssweb-analyticswebsite-analyticswebsite-statswebsite-tracking
Rename dimensions script to pageview-props (#2786)
RobertJoonasbc835895a2d4
diff --git a/lib/plausible_web/plugs/tracker.ex b/lib/plausible_web/plugs/tracker.exindex cd10a955f4..4c5352cd47 100644--- a/lib/plausible_web/plugs/tracker.ex+++ b/lib/plausible_web/plugs/tracker.ex@@ -10,7 +10,7 @@ defmodule PlausibleWeb.Tracker do"local","manual","file-downloads",- "dimensions",+ "pageview-props","tagged-events"]diff --git a/lib/plausible_web/templates/layout/_tracking.html.eex b/lib/plausible_web/templates/layout/_tracking.html.eexindex 401ba02259..309e28354f 100644--- a/lib/plausible_web/templates/layout/_tracking.html.eex+++ b/lib/plausible_web/templates/layout/_tracking.html.eex@@ -1,11 +1,11 @@<%= if !Application.get_env(:plausible, :is_selfhost) && [email protected][:skip_plausible_tracking] do %><%= if Application.get_env(:plausible, :environment) in ["prod", "staging"] do %>- <script defer data-domain="<%= base_domain() %>" event-logged_in="<%= [email protected][:current_user] %>" src="<%="#{plausible_url()}/js/script.dimensions.js"%>"></script>+ <script defer data-domain="<%= base_domain() %>" event-logged_in="<%= [email protected][:current_user] %>" src="<%="#{plausible_url()}/js/script.pageview-props.js"%>"></script><script>window.plausible = window.plausible || function() { (window.plausible.q = window.plausible.q || []).push(arguments) }</script><% end %><%= if Application.get_env(:plausible, :environment) == "dev" do %>- <script defer data-domain="<%= base_domain() %>" event-logged_in="<%= [email protected][:current_user] %>" src="<%="#{plausible_url()}/js/plausible.local.dimensions.js"%>"></script>+ <script defer data-domain="<%= base_domain() %>" event-logged_in="<%= [email protected][:current_user] %>" src="<%="#{plausible_url()}/js/plausible.local.pageview-props.js"%>"></script><script>window.plausible = window.plausible || function() { (window.plausible.q = window.plausible.q || []).push(arguments) }</script><% end %><% end %>diff --git a/tracker/compile.js b/tracker/compile.jsindex 125cc835a5..31ff497119 100644--- a/tracker/compile.js+++ b/tracker/compile.js@@ -26,7 +26,7 @@ function compilefile(input, output, templateVars = {}) {}}-const base_variants = ["hash", "outbound-links", "exclusions", "compat", "local", "manual", "file-downloads", "dimensions", "tagged-events"]+const base_variants = ["hash", "outbound-links", "exclusions", "compat", "local", "manual", "file-downloads", "pageview-props", "tagged-events"]const variants = [...g.clone.powerSet(base_variants)].filter(a => a.length > 0).map(a => a.sort());compilefile(relPath('src/plausible.js'), relPath('../priv/tracker/js/plausible.js'))diff --git a/tracker/src/plausible.js b/tracker/src/plausible.jsindex 8a86cd75b9..4a0645a67c 100644--- a/tracker/src/plausible.js+++ b/tracker/src/plausible.js@@ -77,14 +77,14 @@payload.p = options.props}- {{#if dimensions}}- var dimensionAttributes = scriptEl.getAttributeNames().filter(function (name) {+ {{#if pageview_props}}+ var propAttributes = scriptEl.getAttributeNames().filter(function (name) {return name.substring(0, 6) === 'event-'})var props = payload.p || {}- dimensionAttributes.forEach(function(attribute) {+ propAttributes.forEach(function(attribute) {var propKey = attribute.replace('event-', '')var propValue = scriptEl.getAttribute(attribute)props[propKey] = props[propKey] || propValue