Skip to content

Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.

Search Terms dashboard report follow-up (#5223)

RobertJoonasc32cf24823f8
diff --git a/assets/js/dashboard/stats/sources/search-terms.tsx b/assets/js/dashboard/stats/sources/search-terms.tsx
index 258258ba4b..667e713fca 100644
--- a/assets/js/dashboard/stats/sources/search-terms.tsx
+++ b/assets/js/dashboard/stats/sources/search-terms.tsx
@@ -151,7 +151,7 @@ export function SearchTerms() {
path: referrersGoogleRoute.path,
search: (search: Record<string, unknown>) => search
}}
- className="w-full pb-4 absolute bottom-0 left-0"
+ className="w-full mt-2"
onClick={undefined}
/>
</React.Fragment>
diff --git a/lib/plausible_web/controllers/api/stats_controller.ex b/lib/plausible_web/controllers/api/stats_controller.ex
index f5af00a821..644690c4fb 100644
--- a/lib/plausible_web/controllers/api/stats_controller.ex
+++ b/lib/plausible_web/controllers/api/stats_controller.ex
@@ -789,22 +789,7 @@ defmodule PlausibleWeb.Api.StatsController do
search = params["search"] || ""
- # TODO: stop returning `error` and `reason` (not needed anymore)
- not_configured_error_payload =
- %{
- error_code: :not_configured,
- error: "The site is not connected to Google Search Keywords",
- reason: :not_configured,
- is_admin: is_admin
- }
-
- # TODO: stop returning `error` and `reason` (not needed anymore)
- unsupported_filters_error_payload = %{
- error_code: :unsupported_filters,
- error:
- "Unable to fetch keyword data from Search Console because it does not support the current set of filters",
- reason: :unsupported_filters
- }
+ not_configured_error_payload = %{error_code: :not_configured, is_admin: is_admin}
search_terms = google_api().fetch_stats(site, query, pagination, search)
period_too_recent? = DateTime.diff(query.now, query.utc_time_range.first, :hour) < 72
@@ -818,7 +803,7 @@ defmodule PlausibleWeb.Api.StatsController do
{{:error, :unsupported_filters}, _} ->
conn
|> put_status(422)
- |> json(unsupported_filters_error_payload)
+ |> json(%{error_code: :unsupported_filters})
{{:ok, []}, _period_too_recent? = true} ->
# We consider this an error case because Google Search Console