Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.
TypeScript analyticsanalytics-dashboardclickhouseelixirgoogle-analyticsmarketingopen-source-analyticsphoenixplausible-analyticspostgresqlprivacyprivacy-friendlyself-hostedsimple-analyticsstatisticstailwindcssweb-analyticswebsite-analyticswebsite-statswebsite-tracking
Handle non-string binary input before postgres (#4958)
Artur Patacbb80be1118e
diff --git a/lib/plausible_web/plugs/authorize_site_access.ex b/lib/plausible_web/plugs/authorize_site_access.exindex 4019fdfb9a..fefa92869d 100644--- a/lib/plausible_web/plugs/authorize_site_access.ex+++ b/lib/plausible_web/plugs/authorize_site_access.ex@@ -128,8 +128,12 @@ defmodule PlausibleWeb.Plugs.AuthorizeSiteAccess doendend+ defp valid_path_fragment?(fragment), do: is_binary(fragment) and String.valid?(fragment)+defp get_domain(conn, nil) do- if domain = conn.path_params["domain"] do+ domain = conn.path_params["domain"]++ if valid_path_fragment?(domain) do{:ok, domain}elseerror_not_found(conn)@@ -139,7 +143,7 @@ defmodule PlausibleWeb.Plugs.AuthorizeSiteAccess dodefp get_domain(conn, site_param) dodomain = conn.params[site_param]- if is_binary(domain) do+ if valid_path_fragment?(domain) do{:ok, domain}elseerror_not_found(conn)@@ -165,7 +169,7 @@ defmodule PlausibleWeb.Plugs.AuthorizeSiteAccess dodefp maybe_get_shared_link(conn, site) doslug = conn.path_params["slug"] || conn.params["auth"]- if is_binary(slug) do+ if valid_path_fragment?(slug) doif shared_link = Repo.get_by(Plausible.Site.SharedLink, slug: slug, site_id: site.id) do{:ok, shared_link}elsediff --git a/test/plausible_web/plugs/authorize_site_access_test.exs b/test/plausible_web/plugs/authorize_site_access_test.exsindex 2ceb61693a..05593d3158 100644--- a/test/plausible_web/plugs/authorize_site_access_test.exs+++ b/test/plausible_web/plugs/authorize_site_access_test.exs@@ -44,6 +44,19 @@ defmodule PlausibleWeb.Plugs.AuthorizeSiteAccessTest doassert html_response(conn, 404)end+ test "returns 404 on hacky :domain input", %{conn: conn} do+ opts = AuthorizeSiteAccess.init(:all_roles)++ conn =+ conn+ |> bypass_through(PlausibleWeb.Router)+ |> get("/plug-tests/%c0%ae/with-domain")+ |> AuthorizeSiteAccess.call(opts)++ assert conn.halted+ assert html_response(conn, 404)+ end+test "rejects user completely unrelated to the site", %{conn: conn} doopts = AuthorizeSiteAccess.init(:all_roles)