Skip to content

Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.

time-on-page: Dashboard tweaks (#5217)

Karl-Aksel Puulmanncbffaa205438
diff --git a/assets/js/dashboard/components/table.tsx b/assets/js/dashboard/components/table.tsx
index d3b204093c..01b8f52de3 100644
--- a/assets/js/dashboard/components/table.tsx
+++ b/assets/js/dashboard/components/table.tsx
@@ -119,7 +119,7 @@ export const Table = <T extends Record<string, string | number | ReactNode>>({
const warningSpan = (warning: string) => {
return (
<span className="text-xs font-normal whitespace-nowrap">
- {'*' + warning}
+ {'* ' + warning}
</span>
)
}
diff --git a/assets/js/dashboard/stats/reports/metrics.js b/assets/js/dashboard/stats/reports/metrics.js
index 473c64c58e..1c3f414f41 100644
--- a/assets/js/dashboard/stats/reports/metrics.js
+++ b/assets/js/dashboard/stats/reports/metrics.js
@@ -192,7 +192,7 @@ export const createPageviews = (props) => {
export const createTimeOnPage = (props) => {
const renderLabel = (_query) => 'Time on Page'
return new Metric({
- width: 'w-28',
+ width: 'w-32',
...props,
key: 'time_on_page',
renderLabel,
diff --git a/lib/plausible/stats/query_result.ex b/lib/plausible/stats/query_result.ex
index f272dd647c..75c8bed891 100644
--- a/lib/plausible/stats/query_result.ex
+++ b/lib/plausible/stats/query_result.ex
@@ -159,12 +159,13 @@ defmodule Plausible.Stats.QueryResult do
defp metric_warning(:time_on_page, %Query{} = query) do
case query.time_on_page_data do
%{include_legacy_metric: true, cutoff: cutoff} ->
- cutoff_time =
- cutoff |> DateTime.shift_zone!(query.timezone) |> Calendar.strftime("%Y-%m-%d %H:%M:%S")
+ cutoff_date =
+ cutoff |> DateTime.shift_zone!(query.timezone) |> Calendar.strftime("%Y-%m-%d")
%{
code: :legacy_time_on_page_used,
- message: "Contains less accurate legacy time-on-page data up to #{cutoff_time}"
+ message:
+ "This period includes data calculated with the legacy time on page method up to #{cutoff_date}"
}
_ ->
diff --git a/test/plausible_web/controllers/api/external_stats_controller/query_time_on_page_test.exs b/test/plausible_web/controllers/api/external_stats_controller/query_time_on_page_test.exs
index 8fcc054cca..cd5f568f74 100644
--- a/test/plausible_web/controllers/api/external_stats_controller/query_time_on_page_test.exs
+++ b/test/plausible_web/controllers/api/external_stats_controller/query_time_on_page_test.exs
@@ -275,7 +275,7 @@ defmodule PlausibleWeb.Api.ExternalStatsController.QueryTimeOnPageTest do
"time_on_page" => %{
"code" => "legacy_time_on_page_used",
"message" =>
- "Contains less accurate legacy time-on-page data up to 2021-01-05 00:00:00"
+ "This period includes data calculated with the legacy time on page method up to 2021-01-05"
}
}
})
@@ -308,7 +308,7 @@ defmodule PlausibleWeb.Api.ExternalStatsController.QueryTimeOnPageTest do
"time_on_page" => %{
"code" => "legacy_time_on_page_used",
"message" =>
- "Contains less accurate legacy time-on-page data up to 2021-01-02 00:00:00"
+ "This period includes data calculated with the legacy time on page method up to 2021-01-02"
}
}
})
@@ -342,7 +342,7 @@ defmodule PlausibleWeb.Api.ExternalStatsController.QueryTimeOnPageTest do
"time_on_page" => %{
"code" => "legacy_time_on_page_used",
"message" =>
- "Contains less accurate legacy time-on-page data up to 2021-01-02 00:00:00"
+ "This period includes data calculated with the legacy time on page method up to 2021-01-02"
}
}
})
@@ -373,7 +373,7 @@ defmodule PlausibleWeb.Api.ExternalStatsController.QueryTimeOnPageTest do
"time_on_page" => %{
"code" => "legacy_time_on_page_used",
"message" =>
- "Contains less accurate legacy time-on-page data up to 2021-01-05 00:00:00"
+ "This period includes data calculated with the legacy time on page method up to 2021-01-05"
}
}
})
@@ -404,7 +404,7 @@ defmodule PlausibleWeb.Api.ExternalStatsController.QueryTimeOnPageTest do
"time_on_page" => %{
"code" => "legacy_time_on_page_used",
"message" =>
- "Contains less accurate legacy time-on-page data up to 2021-01-02 00:00:00"
+ "This period includes data calculated with the legacy time on page method up to 2021-01-02"
}
}
})
@@ -436,7 +436,7 @@ defmodule PlausibleWeb.Api.ExternalStatsController.QueryTimeOnPageTest do
"time_on_page" => %{
"code" => "legacy_time_on_page_used",
"message" =>
- "Contains less accurate legacy time-on-page data up to 2021-01-02 00:00:00"
+ "This period includes data calculated with the legacy time on page method up to 2021-01-02"
}
}
})