Skip to content

Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.

Redirect to login on expired legacy session (#4523)

Adrian Gruntkowskid0619aaea04f
diff --git a/lib/plausible_web/plugs/session_timeout_plug.ex b/lib/plausible_web/plugs/session_timeout_plug.ex
index 7ba60f2263..0add19b18b 100644
--- a/lib/plausible_web/plugs/session_timeout_plug.ex
+++ b/lib/plausible_web/plugs/session_timeout_plug.ex
@@ -18,6 +18,7 @@ defmodule PlausibleWeb.SessionTimeoutPlug do
user_id && timeout_at && now() > timeout_at ->
conn
|> PlausibleWeb.UserAuth.log_out_user()
+ |> Phoenix.Controller.redirect(to: "/login")
|> halt()
user_id ->
diff --git a/test/plausible_web/plugs/session_timeout_plug_test.exs b/test/plausible_web/plugs/session_timeout_plug_test.exs
index ce8ee15630..8a95fc75b9 100644
--- a/test/plausible_web/plugs/session_timeout_plug_test.exs
+++ b/test/plausible_web/plugs/session_timeout_plug_test.exs
@@ -41,5 +41,7 @@ defmodule PlausibleWeb.SessionTimeoutPlugTest do
|> SessionTimeoutPlug.call(@opts)
assert conn.private[:plug_session_info] == :renew
+ assert conn.halted
+ assert Phoenix.ConnTest.redirected_to(conn, 302) == "/login"
end
end