Skip to content

Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.

Fix flaky test (#3626)

hq1d161ad7667d6
diff --git a/test/plausible/session/cache_store_test.exs b/test/plausible/session/cache_store_test.exs
index 2e7eeb5a10..aa4a43798f 100644
--- a/test/plausible/session/cache_store_test.exs
+++ b/test/plausible/session/cache_store_test.exs
@@ -118,13 +118,20 @@ defmodule Plausible.Session.CacheStoreTest do
end
describe "collapse order" do
+ defp new_site_id() do
+ [[site_id]] =
+ Plausible.ClickhouseRepo.query!("select max(site_id) + rand() from sessions_v2 FINAL").rows
+
+ site_id
+ end
+
defp flush(events) do
for e <- events, do: CacheStore.on_event(e, nil)
Plausible.Session.WriteBuffer.flush()
end
test "across parts" do
- e = build(:event, name: "pageview")
+ e = build(:event, name: "pageview", site_id: new_site_id())
flush([%{e | pathname: "/"}])
flush([%{e | pathname: "/exit"}])
@@ -138,7 +145,7 @@ defmodule Plausible.Session.CacheStoreTest do
end
test "within parts" do
- e = build(:event, name: "pageview")
+ e = build(:event, name: "pageview", site_id: new_site_id())
flush([
%{e | pathname: "/"},
@@ -154,7 +161,7 @@ defmodule Plausible.Session.CacheStoreTest do
end
test "across and within parts" do
- e = build(:event, name: "pageview")
+ e = build(:event, name: "pageview", site_id: new_site_id())
flush([
%{e | pathname: "/"},