Skip to content

Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.

Restrict public CSV export access (#5089)

Adrian Gruntkowskid3d054748488
diff --git a/assets/js/dashboard/stats/graph/stats-export.js b/assets/js/dashboard/stats/graph/stats-export.js
index 1b1dd5b3b0..e6972df676 100644
--- a/assets/js/dashboard/stats/graph/stats-export.js
+++ b/assets/js/dashboard/stats/graph/stats-export.js
@@ -3,11 +3,17 @@ import * as api from '../../api';
import { getCurrentInterval } from "./interval-picker";
import { useSiteContext } from "../../site-context";
import { useQueryContext } from "../../query-context";
+import { useUserContext } from '../../user-context';
export default function StatsExport() {
const site = useSiteContext();
const { query } = useQueryContext();
const [exporting, setExporting] = useState(false)
+ const user = useUserContext();
+
+ if (!user.loggedIn) {
+ return null;
+ }
function startExport() {
setExporting(true)
diff --git a/lib/plausible_web/controllers/stats_controller.ex b/lib/plausible_web/controllers/stats_controller.ex
index 4e273c189a..e46f6bbed0 100644
--- a/lib/plausible_web/controllers/stats_controller.ex
+++ b/lib/plausible_web/controllers/stats_controller.ex
@@ -48,7 +48,14 @@ defmodule PlausibleWeb.StatsController do
alias Plausible.Stats.{Filters, Query}
alias PlausibleWeb.Api
- plug(PlausibleWeb.Plugs.AuthorizeSiteAccess when action in [:stats, :csv_export])
+ @all_site_roles PlausibleWeb.Plugs.AuthorizeSiteAccess.all_roles()
+
+ plug(PlausibleWeb.Plugs.AuthorizeSiteAccess when action == :stats)
+
+ plug(
+ PlausibleWeb.Plugs.AuthorizeSiteAccess,
+ @all_site_roles -- [:public] when action == :csv_export
+ )
def stats(%{assigns: %{site: site}} = conn, _params) do
site = Plausible.Repo.preload(site, :owner)
diff --git a/lib/plausible_web/plugs/authorize_site_access.ex b/lib/plausible_web/plugs/authorize_site_access.ex
index 21b4af9a3b..53cb4c340c 100644
--- a/lib/plausible_web/plugs/authorize_site_access.ex
+++ b/lib/plausible_web/plugs/authorize_site_access.ex
@@ -40,6 +40,8 @@ defmodule PlausibleWeb.Plugs.AuthorizeSiteAccess do
@all_roles [:public, :viewer, :admin, :editor, :super_admin, :owner]
+ def all_roles(), do: @all_roles
+
def init([]), do: {@all_roles, nil}
def init(:all_roles), do: {@all_roles, nil}
diff --git a/test/plausible_web/controllers/stats_controller_test.exs b/test/plausible_web/controllers/stats_controller_test.exs
index f9b30d67f7..2cced7b9b2 100644
--- a/test/plausible_web/controllers/stats_controller_test.exs
+++ b/test/plausible_web/controllers/stats_controller_test.exs
@@ -667,9 +667,21 @@ defmodule PlausibleWeb.StatsControllerTest do
|> Enum.map(&String.split(&1, ","))
end
- describe "GET /:domain/export - via shared link" do
+ describe "GET /:domain/export - via shared link as anonymous user" do
setup [:create_user, :create_site, :set_scroll_depth_visible_at]
+ test "export is not allowed for anonymous users", %{conn: conn, site: site} do
+ link = insert(:shared_link, site: site)
+
+ populate_exported_stats(site)
+ conn = get(conn, "/" <> site.domain <> "/export?auth=#{link.slug}&date=2021-10-20")
+ assert response(conn, 404)
+ end
+ end
+
+ describe "GET /:domain/export - via shared link" do
+ setup [:create_user, :create_site, :set_scroll_depth_visible_at, :log_in]
+
test "exports data in zipped csvs", %{conn: conn, site: site} do
link = insert(:shared_link, site: site)