Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.
TypeScript analyticsanalytics-dashboardclickhouseelixirgoogle-analyticsmarketingopen-source-analyticsphoenixplausible-analyticspostgresqlprivacyprivacy-friendlyself-hostedsimple-analyticsstatisticstailwindcssweb-analyticswebsite-analyticswebsite-statswebsite-tracking
Update acquisition channel UDF to prioritize display over paid search (#4818)
Uku Tahtdaa42cbc9dc0
diff --git a/priv/data_migrations/AcquisitionChannel/sql/acquisition_channel_functions.sql.eex b/priv/data_migrations/AcquisitionChannel/sql/acquisition_channel_functions.sql.eexindex f324edf4de..742edca9fe 100644--- a/priv/data_migrations/AcquisitionChannel/sql/acquisition_channel_functions.sql.eex+++ b/priv/data_migrations/AcquisitionChannel/sql/acquisition_channel_functions.sql.eex@@ -207,11 +207,11 @@ CREATE OR REPLACE FUNCTION acquisition_channel_lowered <%= @on_cluster_statement(referrer_source, utm_medium, utm_campaign, utm_source, click_id_param) ->multiIf(acquisition_channel_cross_network(utm_campaign), 'Cross-network',+ acquisition_channel_display(utm_medium), 'Display',acquisition_channel_paid_shopping(referrer_source, utm_medium, utm_campaign), 'Paid Shopping',acquisition_channel_paid_search(referrer_source, utm_medium, utm_source, click_id_param), 'Paid Search',acquisition_channel_paid_social(referrer_source, utm_medium, utm_source), 'Paid Social',acquisition_channel_paid_video(referrer_source, utm_medium, utm_source), 'Paid Video',- acquisition_channel_display(utm_medium), 'Display',acquisition_channel_paid_medium(utm_medium), 'Paid Other',acquisition_channel_organic_shopping(referrer_source, utm_campaign), 'Organic Shopping',acquisition_channel_organic_social(referrer_source, utm_medium), 'Organic Social',diff --git a/test/plausible/ingestion/acquisition_test.exs b/test/plausible/ingestion/acquisition_test.exsindex 77ada66fd3..68d95a69cd 100644--- a/test/plausible/ingestion/acquisition_test.exs+++ b/test/plausible/ingestion/acquisition_test.exs@@ -103,7 +103,13 @@ defmodule Plausible.Ingestion.AcquisitionTest do%{referrer_source: "steamcommunity.com", expected: "Organic Social"},%{referrer_source: "Vkontakte", expected: "Organic Social"},%{referrer_source: "Threads", expected: "Organic Social"},- %{referrer_source: "Ecosia", expected: "Organic Search"}+ %{referrer_source: "Ecosia", expected: "Organic Search"},+ %{+ referrer_source: "Google",+ utm_medium: "display",+ click_id_param: "123identifier",+ expected: "Display"+ }]for {test_data, index} <- Enum.with_index(@static_tests, 1) dodiff --git a/test/plausible_web/controllers/api/external_controller_test.exs b/test/plausible_web/controllers/api/external_controller_test.exsindex 9def31b06d..81180b3928 100644--- a/test/plausible_web/controllers/api/external_controller_test.exs+++ b/test/plausible_web/controllers/api/external_controller_test.exs@@ -1554,6 +1554,24 @@ defmodule PlausibleWeb.Api.ExternalControllerTest doassert session.acquisition_channel == "Display"end+ test "display channel with gclid", %{conn: conn, site: site} do+ params = %{+ name: "pageview",+ url: "http://example.com?utm_medium=display&utm_source=google&gclid=123identifier",+ domain: site.domain+ }++ conn =+ conn+ |> put_req_header("user-agent", @user_agent)+ |> post("/api/event", params)++ session = get_created_session(site)++ assert response(conn, 202) == "ok"+ assert session.acquisition_channel == "Display"+ end+test "parses paid other channel", %{conn: conn, site: site} doparams = %{name: "pageview",