Skip to content

Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.

Feature/mobile graph (#1160)

Ru Singhe5a4b82db4ba
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 717bb5fbca..905c814f27 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -22,6 +22,7 @@ All notable changes to this project will be documented in this file.
- Sites listing page will paginate if the user has a lot of sites plausible/analytics#994
- Crash when changing theme on a loaded dashboard plausible/analytics#1123
- UI fix for details button overlapping content on mobile plausible/analytics#1114
+- UI fix for the main graph on mobile overlapping its tick items on both axis
### Removed
- Removes AppSignal monitoring package
diff --git a/assets/js/dashboard/stats/visitor-graph.js b/assets/js/dashboard/stats/visitor-graph.js
index 94b3700cf6..61e985dfa5 100644
--- a/assets/js/dashboard/stats/visitor-graph.js
+++ b/assets/js/dashboard/stats/visitor-graph.js
@@ -100,6 +100,7 @@ class LineGraph extends React.Component {
constructor(props) {
super(props);
this.regenerateChart = this.regenerateChart.bind(this);
+ this.updateWindowDimensions = this.updateWindowDimensions.bind(this);
}
regenerateChart() {
@@ -157,6 +158,7 @@ class LineGraph extends React.Component {
},
},
responsive: true,
+ onResize: this.updateWindowDimensions,
elements: {line: {tension: 0}, point: {radius: 0}},
onClick: this.onClick.bind(this),
scales: {
@@ -208,6 +210,16 @@ class LineGraph extends React.Component {
}
}
+ /**
+ * The current ticks' limits are set to treat iPad (regular/Mini/Pro) as a regular screen.
+ * @param {*} chart - The chart instance.
+ * @param {*} dimensions - An object containing the new dimensions *of the chart.*
+ */
+ updateWindowDimensions(chart, dimensions) {
+ chart.options.scales.x.ticks.maxTicksLimit = dimensions.width < 720 ? 5 : 8
+ chart.options.scales.y.ticks.maxTicksLimit = dimensions.height < 233 ? 3 : 8
+ }
+
onClick(e) {
const element = this.chart.getElementsAtEventForMode(e, 'index', {intersect: false})[0]
const date = this.chart.data.labels[element.index]