Skip to content

Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.

Enable superadmin access to funnel settings (#3104)

hq1e98a16141ef6
diff --git a/lib/plausible_web/live/funnel_settings.ex b/lib/plausible_web/live/funnel_settings.ex
index 695e34e09f..9de1f4b4a5 100644
--- a/lib/plausible_web/live/funnel_settings.ex
+++ b/lib/plausible_web/live/funnel_settings.ex
@@ -15,7 +15,13 @@ defmodule PlausibleWeb.Live.FunnelSettings do
socket
) do
true = Plausible.Funnels.enabled_for?("user:#{user_id}")
- site = Sites.get_for_user!(user_id, domain, [:owner, :admin])
+
+ site =
+ if Plausible.Auth.is_super_admin?(user_id) do
+ Sites.get_by_domain(domain)
+ else
+ Sites.get_for_user!(user_id, domain, [:owner, :admin])
+ end
funnels = Funnels.list(site)
goal_count = Goals.count(site)
diff --git a/lib/plausible_web/live/funnel_settings/form.ex b/lib/plausible_web/live/funnel_settings/form.ex
index dcb9b6f60c..589a0b2160 100644
--- a/lib/plausible_web/live/funnel_settings/form.ex
+++ b/lib/plausible_web/live/funnel_settings/form.ex
@@ -12,7 +12,12 @@ defmodule PlausibleWeb.Live.FunnelSettings.Form do
alias Plausible.{Sites, Goals}
def mount(_params, %{"current_user_id" => user_id, "domain" => domain}, socket) do
- site = Sites.get_for_user!(user_id, domain, [:owner, :admin])
+ site =
+ if Plausible.Auth.is_super_admin?(user_id) do
+ Sites.get_by_domain(domain)
+ else
+ Sites.get_for_user!(user_id, domain, [:owner, :admin])
+ end
# We'll have the options trimmed to only the data we care about, to keep
# it minimal at the socket assigns, yet, we want to retain specific %Goal{}