Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.
TypeScript analyticsanalytics-dashboardclickhouseelixirgoogle-analyticsmarketingopen-source-analyticsphoenixplausible-analyticspostgresqlprivacyprivacy-friendlyself-hostedsimple-analyticsstatisticstailwindcssweb-analyticswebsite-analyticswebsite-statswebsite-tracking
Require src attribute when seeking snippet for verification (#4290)
hq1f4e091452c08
diff --git a/lib/plausible/verification/checks/snippet.ex b/lib/plausible/verification/checks/snippet.exindex 9375a91122..c1fbcfc2e0 100644--- a/lib/plausible/verification/checks/snippet.ex+++ b/lib/plausible/verification/checks/snippet.ex@@ -11,8 +11,8 @@ defmodule Plausible.Verification.Checks.Snippet do@impl truedef perform(%State{assigns: %{document: document}} = state) do- in_head = Floki.find(document, "head script[data-domain]")- in_body = Floki.find(document, "body script[data-domain]")+ in_head = Floki.find(document, "head script[data-domain][src]")+ in_body = Floki.find(document, "body script[data-domain][src]")all = in_head ++ in_bodydiff --git a/test/plausible/site/verification/checks_test.exs b/test/plausible/site/verification/checks_test.exsindex 67a5802720..df4bb2b30c 100644--- a/test/plausible/site/verification/checks_test.exs+++ b/test/plausible/site/verification/checks_test.exs@@ -246,6 +246,26 @@ defmodule Plausible.Verification.ChecksTest do|> assert_error(@errors.multiple_snippets)end+ @no_src_scripts """+ <html>+ <head>+ <script defer data-domain="example.com"></script>+ </head>+ <body>+ Hello+ <script defer data-domain="example.com"></script>+ </body>+ </html>+ """+ test "no src attr doesn't count as snippet" do+ stub_fetch_body(200, @no_src_scripts)+ stub_installation(200, plausible_installed(false))++ run_checks()+ |> Checks.interpret_diagnostics()+ |> assert_error(@errors.no_snippet)+ end+@many_snippets_ok """<html><head>