An agent skill for creating detailed, interactive isometric illustrations of real-world machines and complex systems. Generates polished SVGs with optional WebGL shaders and 3D effects.
fix(react): preserve the first readout write
Rudy Celekli795b31262d07
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.ymlindex bf7b18d..3a73e80 100644--- a/.github/workflows/ci.yml+++ b/.github/workflows/ci.yml@@ -25,6 +25,11 @@ jobs:with:node-version: 22+ - name: React lifecycle regression+ run: |+ npm install --prefix "$RUNNER_TEMP/anatomy-react-tests" --no-package-lock --no-save [email protected] [email protected] [email protected]+ NODE_PATH="$RUNNER_TEMP/anatomy-react-tests/node_modules" node --test scripts/react-readout-first-write.test.mjs+- name: Dial indicatorrun: |node examples/dial-indicator/build.mjsdiff --git a/CHANGELOG.md b/CHANGELOG.mdindex 8152ae2..3a5db76 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -12,6 +12,8 @@ All notable changes to Anatomy are recorded here. The format follows [Keep a Cha### Fixed+- Write the first readout value even when empty or issued before passive binding.+- `examples/test-rig/` drew its glass button dark in the light theme. `stretch.css` now has light values for its own colours.### Changeddiff --git a/kit/react/live.tsx b/kit/react/live.tsxindex 68ddf0d..15fce2e 100644--- a/kit/react/live.tsx+++ b/kit/react/live.tsx@@ -45,14 +45,15 @@ export function Stage({ className, children }: { className: string; children: Reexport function useReadout<T extends Element>() {const anchor = React.useRef<T>(null);const slot = React.useRef<Element | null>(null);- const said = React.useRef("");+ const said = React.useRef<string | null>(null);React.useEffect(() => {slot.current = anchor.current?.closest(".iso-plate")?.querySelector("[data-readout]") ?? null;}, []);const say = React.useCallback((text: string) => {- if (text === said.current) return;+ slot.current ??= anchor.current?.closest(".iso-plate")?.querySelector("[data-readout]") ?? null;+ if (!slot.current || text === said.current) return;said.current = text;- if (slot.current) slot.current.textContent = text;+ slot.current.textContent = text;}, []);return { anchor, say };}diff --git a/scripts/react-readout-first-write.test.mjs b/scripts/react-readout-first-write.test.mjsnew file mode 100644index 0000000..7b89090--- /dev/null+++ b/scripts/react-readout-first-write.test.mjs@@ -0,0 +1,37 @@+import assert from "node:assert/strict";+import { execFile } from "node:child_process";+import { mkdtempSync, rmSync, writeFileSync } from "node:fs";+import { createRequire } from "node:module";+import { tmpdir } from "node:os";+import { dirname, join, resolve } from "node:path";+import { promisify } from "node:util";+import test from "node:test";+const require = createRequire(import.meta.url);+const { build } = require("esbuild");+const nodePaths = (process.env.NODE_PATH ?? "").split(":").filter(Boolean);+const alias = Object.fromEntries(["react", "react-dom"].map(name => [name, dirname(require.resolve(name+"/package.json", { paths: nodePaths }))]));+const directory = mkdtempSync(join(tmpdir(), "anatomy-react-readout-"));+let observed;+try {+ const entry = `import React,{useEffect,useLayoutEffect} from 'react';import {createRoot} from 'react-dom/client';import {flushSync} from 'react-dom';import {useReadout} from ${JSON.stringify(resolve("kit/react/live.tsx"))};+const changes={};function Probe({mode}){const{anchor,say}=useReadout();useLayoutEffect(()=>{const node=anchor.current.closest('.iso-plate').querySelector('[data-readout]');const observer=new MutationObserver(records=>changes[mode]=(changes[mode]??0)+records.length);observer.observe(node,{childList:true});if(mode==='layout')say('layout');return()=>observer.disconnect();},[]);useEffect(()=>{if(mode==='empty')say('');if(mode==='healthy'||mode==='repeat')say(mode);setTimeout(()=>{if(mode==='layout')say('layout');if(mode==='repeat')say('repeat');},20);},[]);return React.createElement('div',{className:'iso-plate',id:mode},React.createElement('span',{'data-readout':true},'rest'),React.createElement('div',{ref:anchor}));}+flushSync(()=>createRoot(document.getElementById('root')).render(React.createElement(React.Fragment,null,...['layout','empty','healthy','repeat'].map(mode=>React.createElement(Probe,{key:mode,mode})))));setTimeout(()=>{const values=Object.fromEntries(['layout','empty','healthy','repeat'].map(mode=>[mode,document.querySelector('#'+mode+' [data-readout]').textContent]));window.readoutObserved={values,changes};document.getElementById('results').textContent=JSON.stringify(window.readoutObserved);},100);`;+ await build({ stdin: { contents: entry, resolveDir: process.cwd(), loader: "jsx" }, bundle: true, outfile: join(directory, "fixture.js"), platform: "browser", nodePaths, alias });+ writeFileSync(join(directory, "fixture.html"), '<!doctype html><html><body><div id="root"></div><pre id="results"></pre><script src="fixture.js"></script></body></html>');+ const result = await promisify(execFile)(process.execPath, ["scripts/drive.mjs", join(directory, "fixture.html"), JSON.stringify([["eval", "({observed:window.readoutObserved,html:document.body.innerHTML})"]])], { timeout: 30000, maxBuffer: 16 * 1024 * 1024 });+ const payload = result.stdout.match(/eval: (.*)/);+ assert.ok(payload, "actual ReactDOM client must complete and publish its native DOM observations");+ const inspection = JSON.parse(payload[1]);+ observed = inspection.observed;+ console.log("actual client inspection:", JSON.stringify(inspection));+ assert.ok(observed?.values, `actual native observations are required: ${result.stdout}`);+} finally {+ rmSync(directory, { recursive: true, force: true });+}+test("native ReactDOM readout accepts its first empty text", () => assert.equal(observed.values.empty, ""));+test("native ReactDOM readout accepts layout-effect text before passive binding", () => assert.equal(observed.values.layout, "layout"));+test("native ReactDOM readout preserves ordinary passive-effect text", () => assert.equal(observed.values.healthy, "healthy"));+test("native ReactDOM readout preserves duplicate-write suppression", () => {+ assert.equal(observed.values.repeat, "repeat");+ assert.equal(observed.changes.repeat, 1);+});