Skip to content

armgit / anime

Public Imported from GitHub
0

JavaScript animation engine

Fix Cannot read property 'targets' of undefined When there are no TL parameters object and no 'targets' property

Julian Garnier40f58f6bdff2
diff --git a/anime.js b/anime.js
index 94a8bdc9..de217b9f 100644
--- a/anime.js
+++ b/anime.js
@@ -946,14 +946,15 @@
// Timeline
- function timeline(params) {
+ function timeline(parameters) {
+ let params = parameters || {};
let tl = anime(params);
tl.pause();
tl.duration = 0;
tl.add = function(instancesParams) {
tl.children.forEach(i => { i.began = true; i.completed = true; });
toArray(instancesParams).forEach(instanceParams => {
- let insParams = mergeObjects(instanceParams, replaceObjectProps(defaultTweenSettings, params || {}));
+ let insParams = mergeObjects(instanceParams, replaceObjectProps(defaultTweenSettings, params));
insParams.targets = insParams.targets || params.targets;
const tlDuration = tl.duration;
const insOffset = insParams.offset;
diff --git a/documentation/examples/anime-tests.html b/documentation/examples/anime-tests.html
index 91d3dec5..1a5e65ba 100644
--- a/documentation/examples/anime-tests.html
+++ b/documentation/examples/anime-tests.html
@@ -41,18 +41,10 @@
<div class="item color-02"></div>
<div class="item color-03"></div>
<script>
- var animation = anime({
- targets: '.item',
- translateX: 100,
- endDelay: function(el, i, t) { return (t - i) * 1000; },
- easing: 'linear',
- direction: 'reverse',
- complete: function() {
- console.log('complete');
- }
- });
-
- console.log(animation.animations);
+ var tl = anime.timeline();
+ tl.add({
+ translateX: 100
+ })
</script>
</body>
</html>
\ No newline at end of file