Open-source agentic AI Search Execution Platform. Track AI visibility, find opportunities, and let agents turn signals into prioritized actions and drafted fixes across ChatGPT, Claude, Gemini, Google AI Overviews, Google AI Mode, Perplexity, Grok, and Microsoft Copilot.
TypeScript aeoai-agentai-searchanswer-engine-optimizationbrand-monitoringchatgptclaudecopilotdockergeminigeogoogle-ai-overviewsgrokmcpnextjsopen-sourceperplexityseosupabasetypescript
feat(settings): let managers change menus and set a person's own sections (menu access, part 4) (#1705)
Cihan084340975511
diff --git a/web/messages/en.json b/web/messages/en.jsonindex 8cef04d8c..43650c114 100644--- a/web/messages/en.json+++ b/web/messages/en.json@@ -8015,6 +8015,32 @@"otherGroup": "Other","saveFailed": "Couldn't save the menu. Try again.","loadFailed": "Couldn't load menu access.",+ "managersTitle": "Who can change menus",+ "managersDescription": "Admins always can. Let a manager do it too: they see this page, and nothing else of the admins' settings.",+ "managersAdminOnly": "Only admins choose who can change menus.",+ "noManagers": "No managers yet. Give someone the Manager role in Team first.",+ "canChangeMenus": "Can change menus",+ "canChangeMenusLabel": "{name} can change menus",+ "peopleTitle": "People",+ "peopleDescription": "Each person's menu is their role's sections, with an exception you set here, narrowed by the work areas they picked themselves.",+ "noPeople": "Only admins so far. Invite people in Team.",+ "person": "Person",+ "workAreas": "Their work areas",+ "menu": "Menu",+ "allSections": "All sections",+ "roleMenu": "{role}'s menu",+ "custom": "Custom: {changes}",+ "sectionCount": "{count} of {total} sections",+ "customize": "Customize",+ "close": "Close",+ "personSections": "{name}'s sections",+ "personSectionsHint": "Ticked as their role has it; a change from the role is marked.",+ "shownForThem": "shown for them",+ "hiddenForThem": "hidden for them",+ "alwaysOnShort": "always on",+ "useRoleMenu": "Use {role}'s menu",+ "savedAsYouChange": "Saved as you change it.",+ "personSees": "{name} sees {section}","areas": {"leaders": {"title": "Founders & leaders",diff --git a/web/src/components/settings/menu-access-people.test.tsx b/web/src/components/settings/menu-access-people.test.tsxnew file mode 100644index 000000000..74aa88c2e--- /dev/null+++ b/web/src/components/settings/menu-access-people.test.tsx@@ -0,0 +1,218 @@+import { act, useState } from 'react';+import { createRoot, type Root } from 'react-dom/client';+import { NextIntlClientProvider } from 'next-intl';+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';+import messages from '../../../messages/en.json';+import type { MenuAccessSettings, MenuMember } from '@/lib/actions/menu-access';++/**+ * Settings › Menu access › Who can change menus and People: an admin lets a+ * manager change menus; each non-admin's exception to their role's menu is+ * saved as a box changes, and put back when the save fails.+ */++const toast = vi.hoisted(() => ({ error: vi.fn(), success: vi.fn() }));+vi.mock('sonner', () => ({ toast }));++const actions = vi.hoisted(() => ({ setMemberMenu: vi.fn(), setMenuManager: vi.fn() }));+vi.mock('@/lib/actions/menu-access', () => actions);++const { MenuManagersCard, MenuPeopleCard, memberMenuWith } = await import('./menu-access-people');++(globalThis as typeof globalThis & { IS_REACT_ACT_ENVIRONMENT: boolean }).IS_REACT_ACT_ENVIRONMENT =+ true;++const member = (over: Partial<MenuMember>): MenuMember => ({+ userId: 'u',+ email: '[email protected]',+ fullName: null,+ avatarUrl: null,+ role: 'analyst',+ workAreas: [],+ shown: [],+ hidden: [],+ canManageMenus: false,+ isCurrentUser: false,+ ...over,+});++let settings: MenuAccessSettings;+const onFailed = vi.fn();+let container: HTMLDivElement;+let root: Root;++beforeEach(() => {+ vi.clearAllMocks();+ actions.setMemberMenu.mockResolvedValue(undefined);+ actions.setMenuManager.mockResolvedValue(undefined);+ settings = {+ roles: { manager: ['content', 'audit'], analyst: ['content'], agency_partner: [] },+ viewerIsAdmin: true,+ members: [+ member({ userId: 'admin', role: 'admin', fullName: 'Cihan Geyik' }),+ member({+ userId: 'deniz',+ role: 'manager',+ fullName: 'Deniz Kaya',+ workAreas: ['brand'],+ canManageMenus: true,+ }),+ member({ userId: 'ece', role: 'manager', fullName: 'Ece Yılmaz', shown: ['audit'] }),+ member({ userId: 'mert', role: 'analyst', fullName: 'Mert Aydın' }),+ ],+ };+ container = document.createElement('div');+ document.body.appendChild(container);+ root = createRoot(container);+});++afterEach(() => {+ act(() => root.unmount());+ container.remove();+});++/**+ * The cards over settings that change as they save, as the section holds+ * them; a failed save reads them again (here: as they started).+ */+function Cards() {+ const [current, setCurrent] = useState(settings);+ const onChange = (update: (s: MenuAccessSettings) => MenuAccessSettings) => setCurrent(update);+ const reload = () => {+ onFailed();+ setCurrent(settings);+ };+ return (+ <>+ <MenuManagersCard settings={current} onChange={onChange} onFailed={reload} />+ <MenuPeopleCard settings={current} onChange={onChange} onFailed={reload} />+ </>+ );+}++async function render() {+ await act(async () => {+ root.render(+ <NextIntlClientProvider locale="en" messages={messages}>+ <Cards />+ </NextIntlClientProvider>,+ );+ });+}++const el = (selector: string) => container.querySelector(selector) as HTMLElement;+const row = (id: string) => el(`[data-member="${id}"]`);+const buttonIn = (scope: HTMLElement, text: string) =>+ [...scope.querySelectorAll('button')].find((b) => b.textContent === text) as HTMLButtonElement;++describe('memberMenuWith', () => {+ it('shows a section the role hides, and hides one it shows', () => {+ expect(memberMenuWith({ shown: [], hidden: [] }, ['content'], 'content', true)).toEqual({+ shown: ['content'],+ hidden: [],+ });+ expect(memberMenuWith({ shown: [], hidden: [] }, ['content'], 'reports', false)).toEqual({+ shown: [],+ hidden: ['reports'],+ });+ });++ it('drops the exception when the box goes back to the role’s', () => {+ expect(+ memberMenuWith({ shown: ['content'], hidden: [] }, ['content'], 'content', false),+ ).toEqual({ shown: [], hidden: [] });+ expect(memberMenuWith({ shown: [], hidden: ['reports'] }, [], 'reports', true)).toEqual({+ shown: [],+ hidden: [],+ });+ });+});++describe('MenuManagersCard', () => {+ it('lists managers only, and lets an admin switch one', async () => {+ await render();+ const deniz = el('[aria-label="Deniz Kaya can change menus"]');+ expect(deniz.getAttribute('aria-checked')).toBe('true');+ expect(el('[aria-label="Ece Yılmaz can change menus"]').getAttribute('aria-checked')).toBe(+ 'false',+ );+ expect(el('[aria-label="Mert Aydın can change menus"]')).toBeNull();++ await act(async () => deniz.click());+ expect(actions.setMenuManager).toHaveBeenCalledWith('deniz', false);+ expect(deniz.getAttribute('aria-checked')).toBe('false');+ expect(onFailed).not.toHaveBeenCalled();+ });++ it('reads the settings again when the save fails', async () => {+ actions.setMenuManager.mockRejectedValueOnce(new Error('nope'));+ await render();+ const ece = el('[aria-label="Ece Yılmaz can change menus"]');+ await act(async () => ece.click());+ expect(onFailed).toHaveBeenCalled();+ expect(ece.getAttribute('aria-checked')).toBe('false');+ expect(toast.error).toHaveBeenCalledWith("Couldn't save the menu. Try again.");+ });++ it('is read-only for a manager who changes menus', async () => {+ settings.viewerIsAdmin = false;+ await render();+ expect((el('[aria-label="Deniz Kaya can change menus"]') as HTMLButtonElement).disabled).toBe(+ true,+ );+ expect(container.textContent).toContain('Only admins choose who can change menus.');+ });+});++describe('MenuPeopleCard', () => {+ it('lists non-admins with their work areas and menu', async () => {+ await render();+ expect(row('admin')).toBeNull();+ expect(row('deniz').textContent).toContain('Brand & PR');+ expect(row('deniz').textContent).toContain("Manager's menu");+ // Manager's 9 sections narrowed to Brand & PR's: Action Center, Chat,+ // Brand Visibility, Mentions, Citations, Reports.+ expect(row('deniz').textContent).toContain('6 of 11 sections');+ expect(row('ece').textContent).toContain('Custom: +Audit');+ expect(row('ece').textContent).toContain('10 of 11 sections');+ expect(row('mert').textContent).toContain('All sections');+ });++ it('saves a person’s exception as a box changes', async () => {+ await render();+ await act(async () => buttonIn(row('mert'), 'Customize').click());+ expect(row('mert').textContent).toContain("Mert Aydın's sections");+ expect((el('[aria-label="Mert Aydın sees Action Center"]') as HTMLButtonElement).disabled).toBe(+ true,+ );++ await act(async () => el('[aria-label="Mert Aydın sees Content"]').click());+ expect(actions.setMemberMenu).toHaveBeenCalledWith('mert', { shown: ['content'], hidden: [] });+ expect(row('mert').textContent).toContain('shown for them');+ expect(row('mert').textContent).toContain('Custom: +Content');++ await act(async () => el('[aria-label="Mert Aydın sees Reports"]').click());+ expect(actions.setMemberMenu).toHaveBeenLastCalledWith('mert', {+ shown: ['content'],+ hidden: ['reports'],+ });+ });++ it('goes back to the role’s menu', async () => {+ await render();+ await act(async () => buttonIn(row('ece'), 'Customize').click());+ await act(async () => buttonIn(row('ece'), "Use Manager's menu").click());+ expect(actions.setMemberMenu).toHaveBeenCalledWith('ece', { shown: [], hidden: [] });+ expect(row('ece').textContent).toContain("Manager's menu");+ });++ it('reads the settings again when the save fails', async () => {+ actions.setMemberMenu.mockRejectedValueOnce(new Error('nope'));+ await render();+ await act(async () => buttonIn(row('mert'), 'Customize').click());+ await act(async () => el('[aria-label="Mert Aydın sees Content"]').click());+ expect(onFailed).toHaveBeenCalled();+ expect(el('[aria-label="Mert Aydın sees Content"]').getAttribute('aria-checked')).toBe('false');+ expect(toast.error).toHaveBeenCalled();+ });+});diff --git a/web/src/components/settings/menu-access-people.tsx b/web/src/components/settings/menu-access-people.tsxnew file mode 100644index 000000000..0d71faff6--- /dev/null+++ b/web/src/components/settings/menu-access-people.tsx@@ -0,0 +1,325 @@+'use client';++import { useState } from 'react';+import { useTranslations } from 'next-intl';+import { toast } from 'sonner';+import { Button } from '@/components/ui/button';+import { Badge } from '@/components/ui/badge';+import { Card, CardContent, CardDescription, CardHeader, CardTitle } from '@/components/ui/card';+import { Checkbox } from '@/components/ui/checkbox';+import { Avatar, AvatarFallback, AvatarImage } from '@/components/ui/avatar';+import { cn } from '@/lib/utils';+import { dashboardNav } from '@/config/dashboard';+import { getDashboardNavLabel } from '@/lib/dashboard-navigation';+import {+ ALWAYS_ON_SECTION,+ MENU_SECTIONS,+ hiddenMenuSections,+ menuSectionOf,+} from '@/lib/menu-access';+import {+ setMemberMenu,+ setMenuManager,+ type MenuAccessSettings,+ type MenuMember,+ type MenuRole,+} from '@/lib/actions/menu-access';++/** The menu's sections with their nav titles, in its order. */+const SECTION_TITLES = dashboardNav+ .flatMap((group) => group.items)+ .flatMap((item) => {+ const section = menuSectionOf(item.href);+ return section ? [{ section, title: item.title }] : [];+ });++function initials(member: MenuMember): string {+ const source = member.fullName?.trim() || member.email;+ return source+ .split(/\s+/)+ .map((part) => part[0] ?? '')+ .join('')+ .slice(0, 2)+ .toUpperCase();+}++function PersonCell({ member, sub }: { member: MenuMember; sub: string }) {+ return (+ <div className="flex min-w-0 items-center gap-2">+ <Avatar className="h-7 w-7 shrink-0">+ {member.avatarUrl && <AvatarImage src={member.avatarUrl} alt="" />}+ <AvatarFallback className="text-[10px]">{initials(member)}</AvatarFallback>+ </Avatar>+ <div className="min-w-0">+ <p className="truncate text-sm font-medium">{member.fullName || member.email}</p>+ <p className="truncate text-xs text-muted-foreground">{sub}</p>+ </div>+ </div>+ );+}++/** A person's change to their role's menu, applied to one section. */+export function memberMenuWith(+ member: Pick<MenuMember, 'shown' | 'hidden'>,+ roleHidden: readonly string[],+ section: string,+ sees: boolean,+): { shown: string[]; hidden: string[] } {+ const roleSees = !roleHidden.includes(section);+ const shown = member.shown.filter((s) => s !== section);+ const hidden = member.hidden.filter((s) => s !== section);+ if (sees && !roleSees) shown.push(section);+ if (!sees && roleSees) hidden.push(section);+ const inOrder = (list: string[]) => MENU_SECTIONS.filter((s) => list.includes(s));+ return { shown: inOrder(shown), hidden: inOrder(hidden) };+}++interface Props {+ settings: MenuAccessSettings;+ /** Updates the settings shown, as a change is saved. */+ onChange: (update: (current: MenuAccessSettings) => MenuAccessSettings) => void;+ /**+ * A save failed: the settings are read again, so a change saved meanwhile+ * stays, which putting back the state before it wouldn't.+ */+ onFailed: () => void;+}++const withMember = (+ settings: MenuAccessSettings,+ userId: string,+ change: Partial<MenuMember>,+): MenuAccessSettings => ({+ ...settings,+ members: settings.members.map((m) => (m.userId === userId ? { ...m, ...change } : m)),+});++/**+ * Settings › Menu access › Who can change menus: an admin lets a manager+ * change menus too (setMenuManager). Others see who can.+ */+export function MenuManagersCard({ settings, onChange, onFailed }: Props) {+ const t = useTranslations('settings.menuAccess');+ const managers = settings.members.filter((m) => m.role === 'manager');++ const toggle = async (member: MenuMember) => {+ const allowed = !member.canManageMenus;+ onChange((current) => withMember(current, member.userId, { canManageMenus: allowed }));+ try {+ await setMenuManager(member.userId, allowed);+ } catch {+ toast.error(t('saveFailed'));+ onFailed();+ }+ };++ return (+ <Card>+ <CardHeader>+ <CardTitle>{t('managersTitle')}</CardTitle>+ <CardDescription>+ {t('managersDescription')}+ {!settings.viewerIsAdmin && ` ${t('managersAdminOnly')}`}+ </CardDescription>+ </CardHeader>+ <CardContent>+ {managers.length === 0 ? (+ <p className="text-sm text-muted-foreground">{t('noManagers')}</p>+ ) : (+ <ul className="divide-y">+ {managers.map((member) => (+ <li key={member.userId} className="flex items-center gap-3 py-2">+ <div className="min-w-0 flex-1">+ <PersonCell member={member} sub={member.email} />+ </div>+ <span className="hidden text-xs text-muted-foreground sm:inline">+ {t('canChangeMenus')}+ </span>+ <button+ type="button"+ role="switch"+ aria-checked={member.canManageMenus}+ aria-label={t('canChangeMenusLabel', {+ name: member.fullName || member.email,+ })}+ disabled={!settings.viewerIsAdmin}+ onClick={() => void toggle(member)}+ className={cn(+ 'relative inline-flex h-5 w-9 shrink-0 cursor-pointer items-center rounded-full border-2 border-transparent transition-colors disabled:cursor-not-allowed disabled:opacity-50',+ member.canManageMenus ? 'bg-primary' : 'bg-muted',+ )}+ >+ <span+ className={cn(+ 'pointer-events-none block h-3.5 w-3.5 rounded-full bg-background shadow-lg transition-transform',+ member.canManageMenus ? 'translate-x-4' : 'translate-x-0.5',+ )}+ />+ </button>+ </li>+ ))}+ </ul>+ )}+ </CardContent>+ </Card>+ );+}++/**+ * Settings › Menu access › People: each non-admin's menu, and their exception+ * to their role's (setMemberMenu), saved as it changes.+ */+export function MenuPeopleCard({ settings, onChange, onFailed }: Props) {+ const t = useTranslations('settings.menuAccess');+ const tSettings = useTranslations('settings');+ const tNav = useTranslations('nav');+ const [editing, setEditing] = useState<string | null>(null);+ const people = settings.members.filter((m) => m.role !== 'admin');+ const label = (section: string) =>+ getDashboardNavLabel(SECTION_TITLES.find((s) => s.section === section)?.title ?? section, tNav);+ const roleName = (role: MenuRole) => tSettings(`team_role_${role}`);++ const save = async (member: MenuMember, menu: { shown: string[]; hidden: string[] }) => {+ onChange((current) => withMember(current, member.userId, menu));+ try {+ await setMemberMenu(member.userId, menu);+ } catch {+ toast.error(t('saveFailed'));+ onFailed();+ }+ };++ return (+ <Card>+ <CardHeader>+ <CardTitle>{t('peopleTitle')}</CardTitle>+ <CardDescription>{t('peopleDescription')}</CardDescription>+ </CardHeader>+ <CardContent>+ {people.length === 0 ? (+ <p className="text-sm text-muted-foreground">{t('noPeople')}</p>+ ) : (+ <ul className="divide-y">+ {people.map((member) => {+ const role = member.role as MenuRole;+ const roleHidden = settings.roles[role] ?? [];+ const off = hiddenMenuSections({ ...member, role, roleHidden });+ const changes = [+ ...member.shown.map((s) => `+${label(s)}`),+ ...member.hidden.map((s) => `−${label(s)}`),+ ];+ const open = editing === member.userId;+ return (+ <li key={member.userId} className="@container py-3" data-member={member.userId}>+ {/* One line when the card is wide; the person and Customize+ over their work areas and menu when it's narrow. */}+ <div className="grid grid-cols-[minmax(0,1fr)_auto] items-center gap-x-3 gap-y-2 [grid-template-areas:'person_edit'_'areas_areas'_'menu_menu'] @xl:grid-cols-[minmax(0,1.4fr)_minmax(0,1fr)_minmax(0,1.2fr)_auto] @xl:[grid-template-areas:'person_areas_menu_edit']">+ <div className="min-w-0 [grid-area:person]">+ <PersonCell member={member} sub={`${roleName(role)} · ${member.email}`} />+ </div>+ <div className="flex min-w-0 flex-wrap gap-1 pl-9 [grid-area:areas] @xl:pl-0">+ {member.workAreas.length ? (+ member.workAreas.map((area) => (+ <Badge key={area} variant="outline" className="font-normal">+ {t(`areas.${area}.title`)}+ </Badge>+ ))+ ) : (+ <span className="text-xs text-muted-foreground">{t('allSections')}</span>+ )}+ </div>+ <div className="min-w-0 pl-9 [grid-area:menu] @xl:pl-0">+ {changes.length ? (+ <Badge className="h-auto border-amber-200 bg-amber-50 text-left font-normal whitespace-normal text-amber-800 dark:border-amber-900/60 dark:bg-amber-950/40 dark:text-amber-300">+ {t('custom', { changes: changes.join(', ') })}+ </Badge>+ ) : (+ <Badge variant="outline" className="font-normal">+ {t('roleMenu', { role: roleName(role) })}+ </Badge>+ )}+ <p className="mt-1 text-xs text-muted-foreground">+ {t('sectionCount', {+ count: MENU_SECTIONS.length - off.size,+ total: MENU_SECTIONS.length,+ })}+ </p>+ </div>+ <Button+ variant="outline"+ size="sm"+ className="[grid-area:edit]"+ aria-expanded={open}+ onClick={() => setEditing(open ? null : member.userId)}+ >+ {open ? t('close') : t('customize')}+ </Button>+ </div>+ {open && (+ <div className="mt-3 rounded-md bg-muted/50 p-3">+ <p className="text-sm font-medium">+ {t('personSections', { name: member.fullName || member.email })}+ </p>+ <p className="text-xs text-muted-foreground">{t('personSectionsHint')}</p>+ <div className="my-3 grid grid-cols-1 gap-x-4 gap-y-1.5 sm:grid-cols-2">+ {MENU_SECTIONS.map((section) => {+ const always = section === ALWAYS_ON_SECTION;+ const roleSees = !roleHidden.includes(section);+ const sees =+ always ||+ member.shown.includes(section) ||+ (roleSees && !member.hidden.includes(section));+ return (+ <label key={section} className="flex items-center gap-2 text-sm">+ <Checkbox+ checked={sees}+ disabled={always}+ aria-label={t('personSees', {+ name: member.fullName || member.email,+ section: label(section),+ })}+ onCheckedChange={(checked) =>+ void save(+ member,+ memberMenuWith(member, roleHidden, section, checked === true),+ )+ }+ />+ {label(section)}+ {always ? (+ <span className="text-xs text-muted-foreground">+ {t('alwaysOnShort')}+ </span>+ ) : sees !== roleSees ? (+ <span className="text-xs text-amber-700 dark:text-amber-400">+ {sees ? t('shownForThem') : t('hiddenForThem')}+ </span>+ ) : null}+ </label>+ );+ })}+ </div>+ <div className="flex flex-wrap items-center gap-3">+ <Button+ variant="outline"+ size="sm"+ disabled={!changes.length}+ onClick={() => void save(member, { shown: [], hidden: [] })}+ >+ {t('useRoleMenu', { role: roleName(role) })}+ </Button>+ <span className="text-xs text-muted-foreground">+ {t('savedAsYouChange')}+ </span>+ </div>+ </div>+ )}+ </li>+ );+ })}+ </ul>+ )}+ </CardContent>+ </Card>+ );+}diff --git a/web/src/components/settings/menu-access-section.tsx b/web/src/components/settings/menu-access-section.tsxindex f6a71e1c3..dcab5d274 100644--- a/web/src/components/settings/menu-access-section.tsx+++ b/web/src/components/settings/menu-access-section.tsx@@ -38,6 +38,7 @@ import {type MenuRole,} from '@/lib/actions/menu-access';import { useCanManageMenus } from '@/components/providers/menu-access-provider';+import { MenuManagersCard, MenuPeopleCard } from '@/components/settings/menu-access-people';const MENU_ROLES: MenuRole[] = ['manager', 'analyst', 'agency_partner'];@@ -128,6 +129,8 @@ function MenuAccessSettingsView() {};const roleName = (role: MenuRole) => tSettings(`team_role_${role}`);+ const updateSettings = (update: (current: MenuAccessSettings) => MenuAccessSettings) =>+ setSettings((current) => (current ? update(current) : current));const setItems = [{ value: 'all', label: t('everything') },...WORK_AREAS.map((area) => ({ value: area.id, label: t(`areas.${area.id}.title`) })),@@ -261,6 +264,21 @@ function MenuAccessSettingsView() {)}</CardContent></Card>++ {settings && (+ <>+ <MenuManagersCard+ settings={settings}+ onChange={updateSettings}+ onFailed={() => void reload()}+ />+ <MenuPeopleCard+ settings={settings}+ onChange={updateSettings}+ onFailed={() => void reload()}+ />+ </>+ )}</div>);}