Open-source agentic AI Search Execution Platform. Track AI visibility, find opportunities, and let agents turn signals into prioritized actions and drafted fixes across ChatGPT, Claude, Gemini, Google AI Overviews, Google AI Mode, Perplexity, Grok, and Microsoft Copilot.
TypeScript aeoai-agentai-searchanswer-engine-optimizationbrand-monitoringchatgptclaudecopilotdockergeminigeogoogle-ai-overviewsgrokmcpnextjsopen-sourceperplexityseosupabasetypescript
fix(security): enforce org ownership on internal API routes (#246)
Gökhan Geyik783ed1a9d32b
diff --git a/server/src/lib/access.js b/server/src/lib/access.jsnew file mode 100644index 000000000..4568ba7df--- /dev/null+++ b/server/src/lib/access.js@@ -0,0 +1,128 @@+/**+ * Resource ownership guards for authenticated `/api` routes.+ *+ * All DB access in this server goes through `supabaseAdmin`, which bypasses+ * Row Level Security. That means a route that takes a `:brandId` / `:id` /+ * `:jobId` and queries by it directly will happily return (or mutate) another+ * organization's data unless it first checks that the resource belongs to the+ * caller's org. These helpers centralize that check.+ *+ * Each helper throws an Error tagged with `.status` (404 / 403) so route+ * handlers can do `const status = error.status || 500` in their catch block —+ * the same pattern already used in routes/prompts.js.+ *+ * Org comparison is intentionally a plain `!==` rather than rejecting a null+ * org. In self-hosted single-tenant setups there may be no organization row,+ * so both the profile and the resource carry `organization_id = null`; a strict+ * "reject when org is null" guard would lock those installs out. In cloud mode+ * every org has a non-null id, so cross-tenant access is still blocked.+ */+import supabaseAdmin from '../config/supabase.js';+import { getOrgIdForUser } from './plan-guard.js';++function accessError(message, status) {+ const err = new Error(message);+ err.status = status;+ return err;+}++/**+ * Assert that `brandId` belongs to the caller's organization.+ * @returns {Promise<{ brand: object, orgId: string|null }>}+ */+export async function assertBrandAccess(brandId, userId) {+ const { data: brand } = await supabaseAdmin+ .from('brands')+ .select('id, organization_id')+ .eq('id', brandId)+ .single();++ if (!brand) {+ throw accessError('Brand not found', 404);+ }++ const orgId = await getOrgIdForUser(userId);+ if (orgId !== brand.organization_id) {+ throw accessError('Unauthorized', 403);+ }++ return { brand, orgId };+}++/**+ * Assert that every content opportunity in `ids` belongs to the caller's org.+ * Ignores ids that don't exist (they simply aren't acted on); throws 403 if any+ * matched opportunity belongs to another org.+ * @returns {Promise<object[]>} the matched opportunity rows (`id`, `brand_id`)+ */+export async function assertOpportunitiesAccess(ids, userId) {+ const userOrg = await getOrgIdForUser(userId);++ const { data: opps } = await supabaseAdmin+ .from('content_opportunities')+ .select('id, brand_id')+ .in('id', ids);++ if (!opps || opps.length === 0) {+ throw accessError('No opportunities found', 404);+ }++ const brandIds = [...new Set(opps.map((o) => o.brand_id))];+ const { data: brands } = await supabaseAdmin+ .from('brands')+ .select('id, organization_id')+ .in('id', brandIds);++ const orgByBrand = new Map((brands || []).map((b) => [b.id, b.organization_id]));+ const allOwned = opps.every((o) => orgByBrand.get(o.brand_id) === userOrg);+ if (!allOwned) {+ throw accessError('Unauthorized', 403);+ }++ return opps;+}++/**+ * Assert that a single content opportunity belongs to the caller's org.+ * @returns {Promise<object>} the opportunity row (`select *`)+ */+export async function assertOpportunityAccess(id, userId) {+ const { data: opp } = await supabaseAdmin+ .from('content_opportunities')+ .select('*')+ .eq('id', id)+ .single();++ if (!opp) {+ throw accessError('Opportunity not found', 404);+ }++ await assertBrandAccess(opp.brand_id, userId);+ return opp;+}++/**+ * Assert that every prompt in `promptIds` belongs to the caller's org,+ * resolved through prompts -> prompt_sets -> brands.+ * @returns {Promise<object[]>} the matched prompt rows+ */+export async function assertPromptAccess(promptIds, userId) {+ const ids = Array.isArray(promptIds) ? promptIds : [promptIds];+ const userOrg = await getOrgIdForUser(userId);++ const { data: rows } = await supabaseAdmin+ .from('prompts')+ .select('id, prompt_sets!inner(brands!inner(organization_id))')+ .in('id', ids);++ if (!rows || rows.length < new Set(ids).size) {+ throw accessError('Prompt not found', 404);+ }++ const allOwned = rows.every((r) => r.prompt_sets?.brands?.organization_id === userOrg);+ if (!allOwned) {+ throw accessError('Unauthorized', 403);+ }++ return rows;+}diff --git a/server/src/routes/content.js b/server/src/routes/content.jsindex c0c7e4b03..2c78d5de9 100644--- a/server/src/routes/content.js+++ b/server/src/routes/content.js@@ -12,6 +12,11 @@ import { createJob, getJob } from '../lib/job-manager.js';import { runContentJob } from '../lib/job-runner.js';import { resolveModel } from '../lib/ai-provider.js';import supabaseAdmin from '../config/supabase.js';+import {+ assertBrandAccess,+ assertOpportunitiesAccess,+ assertOpportunityAccess,+} from '../lib/access.js';const router = Router();@@ -99,6 +104,8 @@ router.get('/job/:jobId', async (req, res) => {return res.json({ success: true, status: 'not_found' });}+ await assertBrandAccess(job.brand_id, req.user.id);+const progress = job.progress || {};return res.json({@@ -110,7 +117,7 @@ router.get('/job/:jobId', async (req, res) => {});} catch (error) {console.error('[content] Job status error:', error.message);- return res.status(500).json({ success: false, message: error.message });+ return res.status(error.status || 500).json({ success: false, message: error.message });}});@@ -176,6 +183,8 @@ router.post('/bulk/status', async (req, res) => {.json({ error: `Invalid status. Must be one of: ${validStatuses.join(', ')}` });}+ await assertOpportunitiesAccess(ids, req.user.id);+const { data, error } = await supabaseAdmin.from('content_opportunities').update({ status, updated_at: new Date().toISOString() })@@ -187,7 +196,7 @@ router.post('/bulk/status', async (req, res) => {return res.json({ updated: data?.length || 0 });} catch (error) {console.error('Bulk status update error:', error);- return res.status(500).json({+ return res.status(error.status || 500).json({error: 'Failed to bulk update status',details: error.message,});@@ -206,6 +215,8 @@ router.post('/bulk/send-webhook', async (req, res) => {return res.status(400).json({ error: 'ids must be a non-empty array' });}+ await assertOpportunitiesAccess(ids, req.user.id);+const { data: opportunities, error: oppErr } = await supabaseAdmin.from('content_opportunities').select('*')@@ -342,6 +353,8 @@ router.patch('/:id/status', async (req, res) => {.json({ error: `Invalid status. Must be one of: ${validStatuses.join(', ')}` });}+ await assertOpportunityAccess(id, req.user.id);+const { data, error } = await supabaseAdmin.from('content_opportunities').update({ status, updated_at: new Date().toISOString() })@@ -355,7 +368,7 @@ router.patch('/:id/status', async (req, res) => {return res.json(mapOpportunityRow(data));} catch (error) {console.error('Update opportunity status error:', error);- return res.status(500).json({+ return res.status(error.status || 500).json({error: 'Failed to update status',details: error.message,});@@ -370,15 +383,7 @@ router.post('/:id/send-webhook', async (req, res) => {try {const { id } = req.params;- const { data: opportunity, error: oppErr } = await supabaseAdmin- .from('content_opportunities')- .select('*')- .eq('id', id)- .single();-- if (oppErr || !opportunity) {- return res.status(404).json({ error: 'Opportunity not found' });- }+ const opportunity = await assertOpportunityAccess(id, req.user.id);const { data: webhookConfig } = await supabaseAdmin.from('webhook_configs')@@ -475,7 +480,7 @@ router.post('/:id/send-webhook', async (req, res) => {});} catch (error) {console.error('Send webhook error:', error);- return res.status(500).json({+ return res.status(error.status || 500).json({error: 'Failed to send webhook',details: error.message,});@@ -796,20 +801,12 @@ router.get('/:id', async (req, res) => {try {const { id } = req.params;- const { data, error } = await supabaseAdmin- .from('content_opportunities')- .select('*')- .eq('id', id)- .single();-- if (error || !data) {- return res.status(404).json({ error: 'Opportunity not found' });- }+ const opp = await assertOpportunityAccess(id, req.user.id);- return res.json(mapOpportunityRow(data));+ return res.json(mapOpportunityRow(opp));} catch (error) {console.error('Get opportunity error:', error);- return res.status(500).json({+ return res.status(error.status || 500).json({error: 'Failed to get opportunity',details: error.message,});diff --git a/server/src/routes/tracking.js b/server/src/routes/tracking.jsindex 9271282e8..7a1ee578d 100644--- a/server/src/routes/tracking.js+++ b/server/src/routes/tracking.js@@ -3,6 +3,7 @@ import { createJob, getJob, cancelJob } from '../lib/job-manager.js';import { runTrackingJob } from '../lib/job-runner.js';import supabaseAdmin from '../config/supabase.js';import { isCloud, getPlan, isSubscriptionActive } from '../config/plans.js';+import { assertBrandAccess } from '../lib/access.js';const router = Router();@@ -256,6 +257,7 @@ router.post('/analyze-new', async (req, res) => {router.get('/unanalyzed/:brandId', async (req, res) => {try {const { brandId } = req.params;+ await assertBrandAccess(brandId, req.user.id);const { data: promptSets } = await supabaseAdmin.from('prompt_sets')@@ -291,7 +293,7 @@ router.get('/unanalyzed/:brandId', async (req, res) => {return res.json({ success: true, count: unanalyzed.length, prompts: unanalyzed });} catch (error) {console.error('[tracking] unanalyzed error:', error.message);- return res.status(500).json({ success: false, message: error.message });+ return res.status(error.status || 500).json({ success: false, message: error.message });}});@@ -354,6 +356,7 @@ router.get('/results/:brandId', async (req, res) => {router.get('/status/:brandId', async (req, res) => {try {const { brandId } = req.params;+ await assertBrandAccess(brandId, req.user.id);const { data: platforms, error } = await supabaseAdmin.from('brand_platforms')@@ -366,7 +369,7 @@ router.get('/status/:brandId', async (req, res) => {return res.json({ success: true, platforms: platforms || [] });} catch (error) {console.error('[tracking] Status error:', error.message);- return res.status(500).json({ success: false, message: error.message });+ return res.status(error.status || 500).json({ success: false, message: error.message });}});@@ -381,6 +384,8 @@ router.get('/job/:jobId', async (req, res) => {return res.json({ success: true, status: 'not_found' });}+ await assertBrandAccess(job.brand_id, req.user.id);+return res.json({success: true,status: job.status,@@ -390,7 +395,7 @@ router.get('/job/:jobId', async (req, res) => {});} catch (error) {console.error('[tracking] Job status error:', error.message);- return res.status(500).json({ success: false, message: error.message });+ return res.status(error.status || 500).json({ success: false, message: error.message });}});@@ -400,11 +405,15 @@ router.get('/job/:jobId', async (req, res) => {*/router.delete('/job/:jobId', async (req, res) => {try {+ const job = await getJob(req.params.jobId);+ if (job) {+ await assertBrandAccess(job.brand_id, req.user.id);+ }await cancelJob(req.params.jobId);return res.json({ success: true, message: 'Job cancelled' });} catch (error) {console.error('[tracking] Job cancel error:', error.message);- return res.status(500).json({ success: false, message: error.message });+ return res.status(error.status || 500).json({ success: false, message: error.message });}});diff --git a/server/src/routes/volumes.js b/server/src/routes/volumes.jsindex 0b75299b7..881038724 100644--- a/server/src/routes/volumes.js+++ b/server/src/routes/volumes.js@@ -11,6 +11,7 @@ import {PlanLimitError,} from '../lib/plan-guard.js';import supabaseAdmin from '../config/supabase.js';+import { assertBrandAccess, assertPromptAccess } from '../lib/access.js';const router = Router();@@ -161,6 +162,8 @@ router.post('/analyze', requireFeature('prompt_volumes'), async (req, res) => {return res.status(400).json({ error: 'promptId and promptText are required' });}+ await assertPromptAccess(promptId, req.user.id);+let resolvedLocationCode = locationCode;let resolvedLanguageCode = languageCode;if (resolvedLocationCode == null || resolvedLanguageCode == null) {@@ -235,7 +238,7 @@ router.post('/analyze', requireFeature('prompt_volumes'), async (req, res) => {});}console.error('Volume analysis error:', error);- return res.status(500).json({+ return res.status(error.status || 500).json({error: 'Failed to analyze prompt volume',details: error.message,});@@ -263,6 +266,8 @@ router.post('/analyze-batch', requireFeature('prompt_volumes'), async (req, res)const promptIds = prompts.map((p) => p.promptId);+ await assertPromptAccess(promptIds, req.user.id);+// Resolve DataForSEO location/language from the brand the prompts belong to,// unless the caller explicitly passed an override in the request body.let resolvedLocationCode = locationCode;@@ -360,7 +365,7 @@ router.post('/analyze-batch', requireFeature('prompt_volumes'), async (req, res)});}console.error('Batch volume analysis error:', error);- return res.status(500).json({+ return res.status(error.status || 500).json({error: 'Failed to analyze prompt volumes',details: error.message,});@@ -383,6 +388,8 @@ router.post('/refresh', requireFeature('prompt_volumes'), async (req, res) => {return res.status(400).json({ error: 'brandId is required' });}+ await assertBrandAccess(brandId, req.user.id);+let resolvedLocationCode = locationCode;let resolvedLanguageCode = languageCode;if (resolvedLocationCode == null || resolvedLanguageCode == null) {@@ -474,7 +481,7 @@ router.post('/refresh', requireFeature('prompt_volumes'), async (req, res) => {});}console.error('Volume refresh error:', error);- return res.status(500).json({+ return res.status(error.status || 500).json({error: 'Failed to refresh volumes',details: error.message,});@@ -487,6 +494,7 @@ router.post('/refresh', requireFeature('prompt_volumes'), async (req, res) => {router.get('/brand/:brandId', async (req, res) => {try {const { brandId } = req.params;+ await assertBrandAccess(brandId, req.user.id);const { data: promptSets, error: psError } = await supabaseAdmin.from('prompt_sets')@@ -547,7 +555,7 @@ router.get('/brand/:brandId', async (req, res) => {return res.json({ volumes: enriched, quota });} catch (error) {console.error('Fetch volumes error:', error);- return res.status(500).json({+ return res.status(error.status || 500).json({error: 'Failed to fetch volume data',details: error.message,});