Skip to content

A Q&A platform software for teams at any scales. Whether it's a community forum, help center, or knowledge management platform, you can always count on Apache Answer.

1.5 KB
Raw Blame
/*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
 * to you under the Apache License, Version 2.0 (the
 * "License"); you may not use this file except in compliance
 * with the License.  You may obtain a copy of the License at
 *
 *   http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing,
 * software distributed under the License is distributed on an
 * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
 * KIND, either express or implied.  See the License for the
 * specific language governing permissions and limitations
 * under the License.
 */

package router

import (
	"path/filepath"
	"testing"

	"github.com/apache/answer/internal/base/constant"
)

func TestAttachmentFileLocalPathRejectsTraversal(t *testing.T) {
	uploadPath := t.TempDir()

	filePath, ok := attachmentFileLocalPath(uploadPath, "/hash/report.pdf", "report.pdf")
	if !ok {
		t.Fatal("valid attachment path was rejected")
	}
	want := filepath.Join(uploadPath, constant.FilesPostSubPath, "hash.pdf")
	if filePath != want {
		t.Fatalf("attachment path = %q, want %q", filePath, want)
	}

	for _, requestPath := range []string{"/../../outside/secret.txt", "/hash/../../../secret.txt"} {
		if _, ok := attachmentFileLocalPath(uploadPath, requestPath, filepath.Base(requestPath)); ok {
			t.Fatalf("traversal path %q was accepted", requestPath)
		}
	}
}