A Q&A platform software for teams at any scales. Whether it's a community forum, help center, or knowledge management platform, you can always count on Apache Answer.
fix(user): User reset password should not tell the user if the email exists.
LinkinStars1de3ec27e50b
diff --git a/internal/controller/user_controller.go b/internal/controller/user_controller.goindex c2cf25bf..f69bc16e 100644--- a/internal/controller/user_controller.go+++ b/internal/controller/user_controller.go@@ -157,7 +157,7 @@ func (uc *UserController) RetrievePassWord(ctx *gin.Context) {return}_, _ = uc.actionService.ActionRecordAdd(ctx, schema.ActionRecordTypeFindPass, ctx.ClientIP())- _, err := uc.userService.RetrievePassWord(ctx, req)+ err := uc.userService.RetrievePassWord(ctx, req)handler.HandleResponse(ctx, err, nil)}diff --git a/internal/service/user_service.go b/internal/service/user_service.goindex e7bd4374..5026690a 100644--- a/internal/service/user_service.go+++ b/internal/service/user_service.go@@ -149,13 +149,13 @@ func (us *UserService) EmailLogin(ctx context.Context, req *schema.UserEmailLogi}// RetrievePassWord .-func (us *UserService) RetrievePassWord(ctx context.Context, req *schema.UserRetrievePassWordRequest) (string, error) {+func (us *UserService) RetrievePassWord(ctx context.Context, req *schema.UserRetrievePassWordRequest) error {userInfo, has, err := us.userRepo.GetByEmail(ctx, req.Email)if err != nil {- return "", err+ return err}if !has {- return "", errors.BadRequest(reason.UserNotFound)+ return nil}// send email@@ -167,10 +167,10 @@ func (us *UserService) RetrievePassWord(ctx context.Context, req *schema.UserRetverifyEmailURL := fmt.Sprintf("%s/users/password-reset?code=%s", us.getSiteUrl(ctx), code)title, body, err := us.emailService.PassResetTemplate(ctx, verifyEmailURL)if err != nil {- return "", err+ return err}go us.emailService.SendAndSaveCode(ctx, req.Email, title, body, code, data.ToJSONString())- return code, nil+ return nil}// UseRePassword