A Q&A platform software for teams at any scales. Whether it's a community forum, help center, or knowledge management platform, you can always count on Apache Answer.
fix(permission): check object owner permission
LinkinStar2308bc9d0507
diff --git a/internal/controller/answer_controller.go b/internal/controller/answer_controller.goindex d3d1c478..7ca1f898 100644--- a/internal/controller/answer_controller.go+++ b/internal/controller/answer_controller.go@@ -162,13 +162,15 @@ func (ac *AnswerController) Update(ctx *gin.Context) {canList, err := ac.rankService.CheckOperationPermissions(ctx, req.UserID, []string{permission.AnswerEdit,permission.AnswerEditWithoutReview,- }, req.ID)+ })if err != nil {handler.HandleResponse(ctx, err, nil)return}- req.CanEdit = canList[0]- req.NoNeedReview = canList[1]++ objectOwner := ac.rankService.CheckOperationObjectOwner(ctx, req.UserID, req.ID)+ req.CanEdit = canList[0] || objectOwner+ req.NoNeedReview = canList[1] || objectOwnerif !req.CanEdit {handler.HandleResponse(ctx, errors.Forbidden(reason.RankFailToMeetTheCondition), nil)return@@ -211,7 +213,7 @@ func (ac *AnswerController) AnswerList(ctx *gin.Context) {canList, err := ac.rankService.CheckOperationPermissions(ctx, req.UserID, []string{permission.AnswerEdit,permission.AnswerDelete,- }, "")+ })if err != nil {handler.HandleResponse(ctx, err, nil)returndiff --git a/internal/controller/comment_controller.go b/internal/controller/comment_controller.goindex d7a2ba81..eb025139 100644--- a/internal/controller/comment_controller.go+++ b/internal/controller/comment_controller.go@@ -46,7 +46,7 @@ func (cc *CommentController) AddComment(ctx *gin.Context) {permission.CommentAdd,permission.CommentEdit,permission.CommentDelete,- }, "")+ })if err != nil {handler.HandleResponse(ctx, err, nil)return@@ -146,7 +146,7 @@ func (cc *CommentController) GetCommentWithPage(ctx *gin.Context) {canList, err := cc.rankService.CheckOperationPermissions(ctx, req.UserID, []string{permission.CommentEdit,permission.CommentDelete,- }, "")+ })if err != nil {handler.HandleResponse(ctx, err, nil)return@@ -198,7 +198,7 @@ func (cc *CommentController) GetComment(ctx *gin.Context) {canList, err := cc.rankService.CheckOperationPermissions(ctx, req.UserID, []string{permission.CommentEdit,permission.CommentDelete,- }, "")+ })if err != nil {handler.HandleResponse(ctx, err, nil)returndiff --git a/internal/controller/notification_controller.go b/internal/controller/notification_controller.goindex a6de7bb4..f5b88238 100644--- a/internal/controller/notification_controller.go+++ b/internal/controller/notification_controller.go@@ -47,7 +47,7 @@ func (nc *NotificationController) GetRedDot(ctx *gin.Context) {permission.QuestionAudit,permission.AnswerAudit,permission.TagAudit,- }, "")+ })if err != nil {handler.HandleResponse(ctx, err, nil)return@@ -80,7 +80,7 @@ func (nc *NotificationController) ClearRedDot(ctx *gin.Context) {permission.QuestionAudit,permission.AnswerAudit,permission.TagAudit,- }, "")+ })if err != nil {handler.HandleResponse(ctx, err, nil)returndiff --git a/internal/controller/question_controller.go b/internal/controller/question_controller.goindex e972ddac..ba5bce60 100644--- a/internal/controller/question_controller.go+++ b/internal/controller/question_controller.go@@ -138,12 +138,14 @@ func (qc *QuestionController) GetQuestion(ctx *gin.Context) {permission.QuestionDelete,permission.QuestionClose,permission.QuestionReopen,- }, id)+ })if err != nil {handler.HandleResponse(ctx, err, nil)return}- req.CanEdit = canList[0]+ objectOwner := qc.rankService.CheckOperationObjectOwner(ctx, userID, id)++ req.CanEdit = canList[0] || objectOwnerreq.CanDelete = canList[1]req.CanClose = canList[2]req.CanReopen = canList[3]@@ -257,7 +259,8 @@ func (qc *QuestionController) AddQuestion(ctx *gin.Context) {permission.QuestionDelete,permission.QuestionClose,permission.QuestionReopen,- }, "")+ permission.TagUseReservedTag,+ })if err != nil {handler.HandleResponse(ctx, err, nil)return@@ -267,6 +270,7 @@ func (qc *QuestionController) AddQuestion(ctx *gin.Context) {req.CanDelete = canList[2]req.CanClose = canList[3]req.CanReopen = canList[4]+ req.CanUseReservedTag = canList[5]if !req.CanAdd {handler.HandleResponse(ctx, errors.Forbidden(reason.RankFailToMeetTheCondition), nil)return@@ -299,14 +303,16 @@ func (qc *QuestionController) UpdateQuestion(ctx *gin.Context) {permission.QuestionDelete,permission.QuestionEditWithoutReview,permission.TagUseReservedTag,- }, req.ID)+ })if err != nil {handler.HandleResponse(ctx, err, nil)return}- req.CanEdit = canList[0]++ objectOwner := qc.rankService.CheckOperationObjectOwner(ctx, req.UserID, req.ID)+ req.CanEdit = canList[0] || objectOwnerreq.CanDelete = canList[1]- req.NoNeedReview = canList[2]+ req.NoNeedReview = canList[2] || objectOwnerreq.CanUseReservedTag = canList[3]if !req.CanEdit {handler.HandleResponse(ctx, errors.Forbidden(reason.RankFailToMeetTheCondition), nil)diff --git a/internal/controller/revision_controller.go b/internal/controller/revision_controller.goindex 56fcc5c0..1327cb80 100644--- a/internal/controller/revision_controller.go+++ b/internal/controller/revision_controller.go@@ -74,7 +74,7 @@ func (rc *RevisionController) GetUnreviewedRevisionList(ctx *gin.Context) {permission.QuestionAudit,permission.AnswerAudit,permission.TagAudit,- }, "")+ })if err != nil {handler.HandleResponse(ctx, err, nil)return@@ -106,7 +106,7 @@ func (rc *RevisionController) RevisionAudit(ctx *gin.Context) {permission.QuestionAudit,permission.AnswerAudit,permission.TagAudit,- }, "")+ })if err != nil {handler.HandleResponse(ctx, err, nil)returndiff --git a/internal/controller/tag_controller.go b/internal/controller/tag_controller.goindex bda60620..35b3f69f 100644--- a/internal/controller/tag_controller.go+++ b/internal/controller/tag_controller.go@@ -97,7 +97,7 @@ func (tc *TagController) UpdateTag(ctx *gin.Context) {canList, err := tc.rankService.CheckOperationPermissions(ctx, req.UserID, []string{permission.TagEdit,permission.TagEditWithoutReview,- }, "")+ })if err != nil {handler.HandleResponse(ctx, err, nil)return@@ -136,7 +136,7 @@ func (tc *TagController) GetTagInfo(ctx *gin.Context) {canList, err := tc.rankService.CheckOperationPermissions(ctx, req.UserID, []string{permission.TagEdit,permission.TagDelete,- }, "")+ })if err != nil {handler.HandleResponse(ctx, err, nil)return@@ -200,14 +200,12 @@ func (tc *TagController) GetTagSynonyms(ctx *gin.Context) {}req.UserID = middleware.GetLoginUserIDFromContext(ctx)- canList, err := tc.rankService.CheckOperationPermissions(ctx, req.UserID, []string{- permission.TagSynonym,- }, "")+ can, err := tc.rankService.CheckOperationPermission(ctx, req.UserID, permission.TagSynonym, "")if err != nil {handler.HandleResponse(ctx, err, nil)return}- req.CanEdit = canList[0]+ req.CanEdit = canresp, err := tc.tagService.GetTagSynonyms(ctx, req)handler.HandleResponse(ctx, err, resp)diff --git a/internal/service/rank/rank_service.go b/internal/service/rank/rank_service.goindex 4b105ea7..f11f707c 100644--- a/internal/service/rank/rank_service.go+++ b/internal/service/rank/rank_service.go@@ -93,7 +93,7 @@ func (rs *RankService) CheckOperationPermission(ctx context.Context, userID stri}// CheckOperationPermissions verify that the user has permission-func (rs *RankService) CheckOperationPermissions(ctx context.Context, userID string, actions []string, objectID string) (+func (rs *RankService) CheckOperationPermissions(ctx context.Context, userID string, actions []string) (can []bool, err error) {can = make([]bool, len(actions))if len(userID) == 0 {@@ -109,23 +109,9 @@ func (rs *RankService) CheckOperationPermissions(ctx context.Context, userID strreturn can, nil}- objectOwner := false- if len(objectID) > 0 {- objectInfo, err := rs.objectInfoService.GetInfo(ctx, objectID)- if err != nil {- return can, err- }- // if the user is this object creator, the user can operate this object.- if objectInfo != nil &&- objectInfo.ObjectCreatorUserID == userID {- objectOwner = true- }- }-powerMapping := rs.getUserPowerMapping(ctx, userID)-for idx, action := range actions {- if powerMapping[action] || objectOwner {+ if powerMapping[action] {can[idx] = truecontinue}@@ -135,6 +121,21 @@ func (rs *RankService) CheckOperationPermissions(ctx context.Context, userID strreturn can, nil}+// CheckOperationObjectOwner check operation object owner+func (rs *RankService) CheckOperationObjectOwner(ctx context.Context, userID, objectID string) bool {+ objectInfo, err := rs.objectInfoService.GetInfo(ctx, objectID)+ if err != nil {+ log.Error(err)+ return false+ }+ // if the user is this object creator, the user can operate this object.+ if objectInfo != nil &&+ objectInfo.ObjectCreatorUserID == userID {+ return true+ }+ return false+}+// CheckVotePermission verify that the user has vote permissionfunc (rs *RankService) CheckVotePermission(ctx context.Context, userID, objectID string, voteUp bool) (can bool, err error) {