A Q&A platform software for teams at any scales. Whether it's a community forum, help center, or knowledge management platform, you can always count on Apache Answer.
Sanitize input from contributor fork workflows.
Adam Vollrath3b00da932ba5
diff --git a/.github/workflows/uffizzi-build.yml b/.github/workflows/uffizzi-build.ymlindex 1d6709fa..be4ec951 100644--- a/.github/workflows/uffizzi-build.yml+++ b/.github/workflows/uffizzi-build.yml@@ -36,7 +36,7 @@ jobs:- name: Generate UUID image nameid: uuid- run: echo "UUID_WORKER=$(uuidgen)" >> $GITHUB_ENV+ run: echo "UUID_WORKER=answer-$(uuidgen --time)" >> $GITHUB_ENV- name: Docker metadataid: meta@@ -44,7 +44,7 @@ jobs:with:images: registry.uffizzi.com/${{ env.UUID_WORKER }}tags: |- type=raw,value=60d+ type=raw,value=30d- name: Build and Push Image to registry.uffizzi.com - Uffizzi's ephemeral Registryuses: docker/build-push-action@v3diff --git a/.github/workflows/uffizzi-preview.yml b/.github/workflows/uffizzi-preview.ymlindex bbe0e937..c7a38f33 100644--- a/.github/workflows/uffizzi-preview.yml+++ b/.github/workflows/uffizzi-preview.yml@@ -30,8 +30,10 @@ jobs:runs-on: ubuntu-latestif: ${{ github.event.workflow_run.conclusion == 'success' }}outputs:- compose-file-cache-key: ${{ env.HASH }}- pr-number: ${{ env.PR_NUMBER }}+ compose-file-cache-key: ${{ steps.hash.outputs.COMPOSE_FILE_HASH }}+ git-ref: ${{ steps.event.outputs.GIT_REF }}+ pr-number: ${{ steps.event.outputs.PR_NUMBER }}+ action: ${{ steps.event.outputs.ACTION }}steps:- name: Download artifacts# Fetch output (zip archive) from the workflow run that triggered this workflow.@@ -46,6 +48,9 @@ jobs:let matchArtifact = allArtifacts.data.artifacts.filter((artifact) => {return artifact.name == "preview-spec"})[0];+ if (matchArtifact === undefined) {+ throw TypeError('Build Artifact not found!');+ }let download = await github.rest.actions.downloadArtifact({owner: context.repo.owner,repo: context.repo.repo,@@ -55,34 +60,38 @@ jobs:let fs = require('fs');fs.writeFileSync(`${process.env.GITHUB_WORKSPACE}/preview-spec.zip`, Buffer.from(download.data));- - name: Unzip artifact- run: unzip preview-spec.zip+ - name: 'Accept event from first stage'+ run: unzip preview-spec.zip event.json+- name: Read Event into ENV+ id: eventrun: |- echo 'EVENT_JSON<<EOF' >> $GITHUB_ENV- cat event.json >> $GITHUB_ENV- echo 'EOF' >> $GITHUB_ENV+ echo PR_NUMBER=$(jq '.number | tonumber' < event.json) >> $GITHUB_OUTPUT+ echo ACTION=$(jq --raw-output '.action | tostring | [scan("\\w+")][0]' < event.json) >> $GITHUB_OUTPUT+ echo GIT_REF=$(jq --raw-output '.pull_request.head.sha | tostring | [scan("\\w+")][0]' < event.json) >> $GITHUB_OUTPUT- name: Hash Rendered Compose Fileid: hash# If the previous workflow was triggered by a PR close event, we will not have a compose file artifact.- if: ${{ fromJSON(env.EVENT_JSON).action != 'closed' }}- run: echo "HASH=$(md5sum docker-compose.rendered.yml | awk '{ print $1 }')" >> $GITHUB_ENV+ if: ${{ steps.event.outputs.ACTION != 'closed' }}+ run: |+ unzip preview-spec.zip docker-compose.rendered.yml+ echo "COMPOSE_FILE_HASH=$(md5sum docker-compose.rendered.yml | awk '{ print $1 }')" >> $GITHUB_OUTPUT+- name: Cache Rendered Compose File- if: ${{ fromJSON(env.EVENT_JSON).action != 'closed' }}+ if: ${{ steps.event.outputs.ACTION != 'closed' }}uses: actions/cache@v3with:path: docker-compose.rendered.yml- key: ${{ env.HASH }}+ key: ${{ steps.hash.outputs.COMPOSE_FILE_HASH }}- - name: Read PR Number From Event Object- id: pr- run: echo "PR_NUMBER=${{ fromJSON(env.EVENT_JSON).number }}" >> $GITHUB_ENV- name: DEBUG - Print Job Outputsif: ${{ runner.debug }}run: |- echo "PR number: ${{ env.PR_NUMBER }}"- echo "Compose file hash: ${{ env.HASH }}"+ echo "PR number: ${{ steps.event.outputs.PR_NUMBER }}"+ echo "Git Ref: ${{ steps.event.outputs.GIT_REF }}"+ echo "Action: ${{ steps.event.outputs.ACTION }}"+ echo "Compose file hash: ${{ steps.hash.outputs.COMPOSE_FILE_HASH }}"cat event.jsondeploy-uffizzi-preview: