Skip to content

A Q&A platform software for teams at any scales. Whether it's a community forum, help center, or knowledge management platform, you can always count on Apache Answer.

fix: immediately remove debounced save

shuai3fe58c784aae
diff --git a/ui/src/pages/Questions/Ask/index.tsx b/ui/src/pages/Questions/Ask/index.tsx
index ac973634..a743ecf1 100644
--- a/ui/src/pages/Questions/Ask/index.tsx
+++ b/ui/src/pages/Questions/Ask/index.tsx
@@ -103,6 +103,7 @@ const Ask = () => {
);
const removeDraft = () => {
+ saveDraft.save.cancel();
saveDraft.remove();
setHasDraft(false);
};
@@ -149,20 +150,18 @@ const Ask = () => {
}
return;
}
-
- // save draft
- saveDraft.save({
- params: {
- title: title.value,
- tags: tags.value,
- content: content.value,
- answer: answer.value,
- },
- callback: () => setHasDraft(true),
- });
-
// write
if (title.value || tags.value.length > 0 || content.value || answer.value) {
+ // save draft
+ saveDraft.save({
+ params: {
+ title: title.value,
+ tags: tags.value,
+ content: content.value,
+ answer: answer.value,
+ },
+ callback: () => setHasDraft(true),
+ });
setContentChanged(true);
} else {
removeDraft();
diff --git a/ui/src/pages/Questions/Detail/components/WriteAnswer/index.tsx b/ui/src/pages/Questions/Detail/components/WriteAnswer/index.tsx
index 18dec7df..4b717ba1 100644
--- a/ui/src/pages/Questions/Detail/components/WriteAnswer/index.tsx
+++ b/ui/src/pages/Questions/Detail/components/WriteAnswer/index.tsx
@@ -45,6 +45,8 @@ const Index: FC<Props> = ({ visible = false, data, callback }) => {
});
const removeDraft = () => {
+ // immediately remove debounced save
+ saveDraft.save.cancel();
saveDraft.remove();
setHasDraft(false);
};
@@ -67,13 +69,13 @@ const Index: FC<Props> = ({ visible = false, data, callback }) => {
useEffect(() => {
const { content } = formData;
- // save Draft
- saveDraft.save({
- questionId: data?.qid,
- content: content.value,
- });
-
if (content.value) {
+ // save Draft
+ saveDraft.save({
+ questionId: data?.qid,
+ content: content.value,
+ });
+
setHasDraft(true);
} else {
removeDraft();
diff --git a/ui/src/utils/saveDraft.ts b/ui/src/utils/saveDraft.ts
index a6dc03e1..65a3df12 100644
--- a/ui/src/utils/saveDraft.ts
+++ b/ui/src/utils/saveDraft.ts
@@ -45,29 +45,16 @@ class SaveDraft {
}
if (this.type === 'question') {
const { params, callback } = data as QuestionDraft;
- if (
- !params.title &&
- !params.content &&
- !params.tags.length &&
- !params.answer
- ) {
- this.remove();
- return;
- }
this.storeDraft(params, callback);
}
if (this.type === 'answer') {
const { content, questionId, callback } = data as AnswerDraft;
- if (!questionId) {
+ if (!questionId || !content) {
return;
}
- if (!content) {
- this.remove();
- return;
- }
this.storeDraft({ content, questionId }, callback);
}
}, 3000);