A Q&A platform software for teams at any scales. Whether it's a community forum, help center, or knowledge management platform, you can always count on Apache Answer.
fix: accept answer fails when short links enabled (#1541)
hgaol4aa52a6b521c
diff --git a/internal/service/content/answer_service.go b/internal/service/content/answer_service.goindex d7506d6a..25b0050e 100644--- a/internal/service/content/answer_service.go+++ b/internal/service/content/answer_service.go@@ -471,7 +471,7 @@ func (as *AnswerService) AcceptAnswer(ctx context.Context, req *schema.AcceptAns}// check answer belong to question- if acceptedAnswerInfo.QuestionID != req.QuestionID {+ if !sameObjectID(acceptedAnswerInfo.QuestionID, req.QuestionID) {return errors.BadRequest(reason.AnswerNotFound)}acceptedAnswerInfo.ID = uid.DeShortID(acceptedAnswerInfo.ID)@@ -513,6 +513,12 @@ func (as *AnswerService) AcceptAnswer(ctx context.Context, req *schema.AcceptAnsreturn nil}+// sameObjectID reports whether two object ids refer to the same row,+// regardless of whether each is in short-id or long-id form.+func sameObjectID(a, b string) bool {+ return uid.DeShortID(a) == uid.DeShortID(b)+}+func (as *AnswerService) updateAnswerRank(ctx context.Context, userID string,questionInfo *entity.Question, newAnswerInfo *entity.Answer, oldAnswerInfo *entity.Answer,) {diff --git a/internal/service/content/answer_service_test.go b/internal/service/content/answer_service_test.gonew file mode 100644index 00000000..3cfcb105--- /dev/null+++ b/internal/service/content/answer_service_test.go@@ -0,0 +1,81 @@+/*+ * Licensed to the Apache Software Foundation (ASF) under one+ * or more contributor license agreements. See the NOTICE file+ * distributed with this work for additional information+ * regarding copyright ownership. The ASF licenses this file+ * to you under the Apache License, Version 2.0 (the+ * "License"); you may not use this file except in compliance+ * with the License. You may obtain a copy of the License at+ *+ * http://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing,+ * software distributed under the License is distributed on an+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY+ * KIND, either express or implied. See the License for the+ * specific language governing permissions and limitations+ * under the License.+ */++package content++import (+ "testing"++ "github.com/apache/answer/pkg/uid"+)++// TestSameObjectID guards the AcceptAnswer ownership check (issue #1541).+//+// When short links are enabled, answerRepo.GetByID re-encodes the answer's+// QuestionID to its short form while the controller de-shorts req.QuestionID+// to its long form. The two encodings of the same question must be treated as+// equal, or accepting any answer fails with "Answer do not found".+func TestSameObjectID(t *testing.T) {+ const longQID = "10010000000000001"+ shortQID := uid.EnShortID(longQID) // e.g. "D1D1"+ if shortQID == "" || shortQID == longQID {+ t.Fatalf("precondition failed: EnShortID(%q)=%q, want a distinct short id", longQID, shortQID)+ }+ otherLongQID := "10010000000000002"++ tests := []struct {+ name string+ a string+ b string+ want bool+ }{+ {+ name: "short answer-side id vs long request-side id, same question (the bug)",+ a: shortQID,+ b: longQID,+ want: true,+ },+ {+ name: "both long, same question (default permalink)",+ a: longQID,+ b: longQID,+ want: true,+ },+ {+ name: "both short, same question",+ a: shortQID,+ b: shortQID,+ want: true,+ },+ {+ name: "different questions must stay rejected (privilege-escalation guard)",+ a: shortQID,+ b: otherLongQID,+ want: false,+ },+ }++ for _, tt := range tests {+ t.Run(tt.name, func(t *testing.T) {+ if got := sameObjectID(tt.a, tt.b); got != tt.want {+ t.Errorf("sameObjectID(%q, %q) = %v, want %v", tt.a, tt.b, got, tt.want)+ }+ })+ }+}