Skip to content

A Q&A platform software for teams at any scales. Whether it's a community forum, help center, or knowledge management platform, you can always count on Apache Answer.

fix(ui): fix the exception prompt of uncontrolled components in form

robin4db12501937e
diff --git a/ui/src/components/SchemaForm/index.tsx b/ui/src/components/SchemaForm/index.tsx
index 0ce80d20..3f4c2b7e 100644
--- a/ui/src/components/SchemaForm/index.tsx
+++ b/ui/src/components/SchemaForm/index.tsx
@@ -294,12 +294,7 @@ const SchemaForm: ForwardRefRenderFunction<IRef, IProps> = (
return (
<Form noValidate onSubmit={handleSubmit}>
{keys.map((key) => {
- const {
- title,
- description,
- label,
- default: defaultValue,
- } = properties[key];
+ const { title, description, label } = properties[key];
const { 'ui:widget': widget = 'input', 'ui:options': options = {} } =
uiSchema[key] || {};
if (widget === 'select') {
@@ -312,11 +307,7 @@ const SchemaForm: ForwardRefRenderFunction<IRef, IProps> = (
<Form.Select
aria-label={description}
name={key}
- value={
- formData[key]?.value !== undefined
- ? formData[key]?.value
- : defaultValue
- }
+ value={formData[key]?.value || ''}
onChange={handleSelectChange}
isInvalid={formData[key].isInvalid}>
{properties[key].enum?.map((item, index) => {
@@ -354,11 +345,7 @@ const SchemaForm: ForwardRefRenderFunction<IRef, IProps> = (
name={key}
id={`form-${String(item)}`}
label={properties[key].enumNames?.[index]}
- checked={
- (formData[key]?.value !== undefined
- ? formData[key]?.value
- : defaultValue) === item
- }
+ checked={(formData[key]?.value || '') === item}
feedback={formData[key]?.errorMsg}
feedbackType="invalid"
isInvalid={formData[key].isInvalid}
@@ -390,11 +377,7 @@ const SchemaForm: ForwardRefRenderFunction<IRef, IProps> = (
name={key}
type="switch"
label={label}
- checked={
- formData[key]?.value !== undefined
- ? formData[key]?.value
- : defaultValue
- }
+ checked={formData[key]?.value || ''}
feedback={formData[key]?.errorMsg}
feedbackType="invalid"
isInvalid={formData[key].isInvalid}
@@ -417,11 +400,7 @@ const SchemaForm: ForwardRefRenderFunction<IRef, IProps> = (
controlId={key}>
<Form.Label>{title}</Form.Label>
<TimeZonePicker
- value={
- formData[key]?.value !== undefined
- ? formData[key]?.value
- : defaultValue
- }
+ value={formData[key]?.value || ''}
name={key}
onChange={handleSelectChange}
/>
@@ -480,11 +459,7 @@ const SchemaForm: ForwardRefRenderFunction<IRef, IProps> = (
name={key}
placeholder={options?.placeholder || ''}
type={options?.type || 'text'}
- value={
- formData[key]?.value !== undefined
- ? formData[key]?.value
- : defaultValue
- }
+ value={formData[key]?.value || ''}
onChange={handleInputChange}
isInvalid={formData[key].isInvalid}
rows={options?.rows || 3}
@@ -510,11 +485,7 @@ const SchemaForm: ForwardRefRenderFunction<IRef, IProps> = (
name={key}
placeholder={options?.placeholder || ''}
type={options?.type || 'text'}
- value={
- formData[key]?.value !== undefined
- ? formData[key]?.value
- : defaultValue
- }
+ value={formData[key]?.value || ''}
onChange={handleInputChange}
style={options?.type === 'color' ? { width: '6rem' } : {}}
isInvalid={formData[key].isInvalid}
diff --git a/ui/src/pages/Admin/Login/index.tsx b/ui/src/pages/Admin/Login/index.tsx
index 540b8bfc..4e3b93e2 100644
--- a/ui/src/pages/Admin/Login/index.tsx
+++ b/ui/src/pages/Admin/Login/index.tsx
@@ -21,7 +21,7 @@ const Index: FC = () => {
title: t('membership.title'),
label: t('membership.label'),
description: t('membership.text'),
- default: true,
+ default: false,
},
login_required: {
type: 'boolean',