Skip to content

A Q&A platform software for teams at any scales. Whether it's a community forum, help center, or knowledge management platform, you can always count on Apache Answer.

fix(EditAnswer): Update content correctly when editing answers

haitaoo612b0d6348d6
diff --git a/ui/src/pages/Questions/EditAnswer/index.tsx b/ui/src/pages/Questions/EditAnswer/index.tsx
index 680547f0..5c8e9798 100644
--- a/ui/src/pages/Questions/EditAnswer/index.tsx
+++ b/ui/src/pages/Questions/EditAnswer/index.tsx
@@ -1,4 +1,4 @@
-import React, { useState, useRef, useEffect } from 'react';
+import React, { useState, useRef, useEffect, useLayoutEffect } from 'react';
import { Container, Row, Col, Form, Button, Card } from 'react-bootstrap';
import { useParams, useNavigate } from 'react-router-dom';
import { useTranslation } from 'react-i18next';
@@ -23,18 +23,7 @@ interface FormDataItem {
content: Type.FormValue<string>;
description: Type.FormValue<string>;
}
-const initFormData = {
- content: {
- value: '',
- isInvalid: false,
- errorMsg: '',
- },
- description: {
- value: '',
- isInvalid: false,
- errorMsg: '',
- },
-};
+
const Index = () => {
const { aid = '', qid = '' } = useParams();
const [focusType, setForceType] = useState('');
@@ -42,12 +31,36 @@ const Index = () => {
const { t } = useTranslation('translation', { keyPrefix: 'edit_answer' });
const navigate = useNavigate();
+ const initFormData = {
+ content: {
+ value: '',
+ isInvalid: false,
+ errorMsg: '',
+ },
+ description: {
+ value: '',
+ isInvalid: false,
+ errorMsg: '',
+ },
+ };
+
const { data } = useQueryAnswerInfo(aid);
const [formData, setFormData] = useState<FormDataItem>(initFormData);
const [immData, setImmData] = useState(initFormData);
const [contentChanged, setContentChanged] = useState(false);
- initFormData.content.value = data?.info.content || '';
+ useLayoutEffect(() => {
+ if (data?.info?.content) {
+ setFormData({
+ ...formData,
+ content: {
+ value: data.info.content,
+ isInvalid: false,
+ errorMsg: '',
+ },
+ });
+ }
+ }, [data?.info?.content]);
const { data: revisions = [] } = useQueryRevisions(aid);
@@ -147,9 +160,11 @@ const Index = () => {
const handleSelectedRevision = (e) => {
const index = e.target.value;
const revision = revisions[index];
- formData.content.value = revision.content.content;
- setImmData({ ...formData });
- setFormData({ ...formData });
+ if (revision?.content) {
+ formData.content.value = revision.content.content;
+ setImmData({ ...formData });
+ setFormData({ ...formData });
+ }
};
const backPage = () => {
@@ -192,7 +207,7 @@ const Index = () => {
<Form noValidate onSubmit={handleSubmit}>
<Form.Group controlId="revision" className="mb-3">
<Form.Label>{t('form.fields.revision.label')}</Form.Label>
- <Form.Select onChange={handleSelectedRevision}>
+ <Form.Select onChange={handleSelectedRevision} defaultValue={0}>
{revisions.map(({ create_at, reason, user_info }, index) => {
const date = dayjs(create_at * 1000)
.tz()