Skip to content

A Q&A platform software for teams at any scales. Whether it's a community forum, help center, or knowledge management platform, you can always count on Apache Answer.

fix(Question): Handle unexpected state handling issues when CAPTCHA and draft functions are mixed together.

haitaoo9184b9b416b5
diff --git a/ui/src/components/Comment/index.tsx b/ui/src/components/Comment/index.tsx
index f9b8d75e..ce3f008b 100644
--- a/ui/src/components/Comment/index.tsx
+++ b/ui/src/components/Comment/index.tsx
@@ -192,7 +192,7 @@ const Comment = ({ objectId, mode, commentId }) => {
if (ex.isError) {
const captchaErr = addCaptcha.handleCaptchaError(ex.list);
// If it is not a CAPTCHA error, leave it to the subsequent error handling logic to continue processing.
- if (!captchaErr || captchaErr.error_msg !== ex.msg) {
+ if (!(captchaErr && ex.list.length === 1)) {
return Promise.reject(ex);
}
}
diff --git a/ui/src/pages/Questions/Ask/index.tsx b/ui/src/pages/Questions/Ask/index.tsx
index 0b823ac7..0f139d2f 100644
--- a/ui/src/pages/Questions/Ask/index.tsx
+++ b/ui/src/pages/Questions/Ask/index.tsx
@@ -244,7 +244,6 @@ const Ask = () => {
};
const handleSubmit = async (event: React.FormEvent<HTMLFormElement>) => {
- contentChangedRef.current = false;
event.preventDefault();
event.stopPropagation();
@@ -256,6 +255,7 @@ const Ask = () => {
if (isEdit) {
editCaptcha.check(() => {
+ contentChangedRef.current = false;
const ep = {
...params,
id: qid,
@@ -283,6 +283,7 @@ const Ask = () => {
});
} else {
saveCaptcha.check(async () => {
+ contentChangedRef.current = false;
const imgCode = saveCaptcha.getCaptcha();
if (imgCode.verify) {
params.captcha_code = imgCode.captcha_code;
@@ -295,25 +296,21 @@ const Ask = () => {
answer_content: formData.answer_content.value,
}).catch((err) => {
if (err.isError) {
- saveCaptcha.handleCaptchaError(err.list);
- const data = handleFormError(err, formData);
- if (data.keys.includes('captcha')) {
- delete data.captcha_code;
- delete data.captcha_id;
+ const captchaErr = saveCaptcha.handleCaptchaError(err.list);
+ if (!(captchaErr && err.list.length === 1)) {
+ const data = handleFormError(err, formData);
+ setFormData({ ...data });
}
- setFormData({ ...data });
}
});
} else {
res = await saveQuestion(params).catch((err) => {
if (err.isError) {
- saveCaptcha.handleCaptchaError(err.list);
- const data = handleFormError(err, formData);
- if (data.keys.includes('captcha')) {
- delete data.captcha_code;
- delete data.captcha_id;
+ const captchaErr = saveCaptcha.handleCaptchaError(err.list);
+ if (!(captchaErr && err.list.length === 1)) {
+ const data = handleFormError(err, formData);
+ setFormData({ ...data });
}
- setFormData({ ...data });
}
});
}