Skip to content

A Q&A platform software for teams at any scales. Whether it's a community forum, help center, or knowledge management platform, you can always count on Apache Answer.

chore: align asset-check comments with the DOM-tolerant parser

Xan Torresace02c499a0c
diff --git a/internal/controller/template_controller.go b/internal/controller/template_controller.go
index 4343738a..0f2f5b68 100644
--- a/internal/controller/template_controller.go
+++ b/internal/controller/template_controller.go
@@ -94,11 +94,11 @@ func GetStyle() (script []string, css []string) {
return
}
- // The frontend build tool controls attribute order, attribute set (e.g.
- // module vs classic scripts), and quoting for the emitted tags, and that
- // shape has already changed once. Walk the parsed DOM instead of matching
- // a literal tag shape so the next bundler change fails a test instead of
- // silently shipping pages with no JS or CSS.
+ // Script and stylesheet tags are read from the parsed document, so
+ // attribute order, attribute set (module vs classic scripts), and
+ // quoting do not matter. That shape has already changed once; a
+ // bundler change that breaks it now fails the guarding test instead
+ // of silently shipping pages with no JS or CSS.
doc, err := html.Parse(bytes.NewReader(file))
if err != nil {
return