A Q&A platform software for teams at any scales. Whether it's a community forum, help center, or knowledge management platform, you can always count on Apache Answer.
fix(answer): update QuestionID handling in answer update process
LinkinStarsd15d55abe35c
diff --git a/internal/controller/answer_controller.go b/internal/controller/answer_controller.goindex 7c5aca1d..0e43121c 100644--- a/internal/controller/answer_controller.go+++ b/internal/controller/answer_controller.go@@ -318,7 +318,6 @@ func (ac *AnswerController) UpdateAnswer(ctx *gin.Context) {handler.HandleResponse(ctx, err, nil)return}- req.QuestionID = uid.DeShortID(req.QuestionID)linkUrlLimitUser := canList[2]isAdmin := middleware.GetUserIsAdminModerator(ctx)if !isAdmin || !linkUrlLimitUser {diff --git a/internal/schema/answer_schema.go b/internal/schema/answer_schema.goindex 015e26ac..9ac4bcad 100644--- a/internal/schema/answer_schema.go+++ b/internal/schema/answer_schema.go@@ -78,7 +78,6 @@ type GetAnswerInfoResp struct {type AnswerUpdateReq struct {ID string `json:"id"`- QuestionID string `json:"question_id"`Title string `json:"title"`Content string `validate:"required,notblank,gte=6,lte=65535" json:"content"`EditSummary string `validate:"omitempty" json:"edit_summary"`diff --git a/internal/service/content/answer_service.go b/internal/service/content/answer_service.goindex b9d45b52..982bbf88 100644--- a/internal/service/content/answer_service.go+++ b/internal/service/content/answer_service.go@@ -346,24 +346,23 @@ func (as *AnswerService) Update(ctx context.Context, req *schema.AnswerUpdateReqreturn "", errors.BadRequest(reason.AnswerCannotUpdate)}- questionInfo, exist, err := as.questionRepo.GetQuestion(ctx, req.QuestionID)+ answerInfo, exist, err := as.answerRepo.GetByID(ctx, req.ID)if err != nil {return "", err}if !exist {- return "", errors.BadRequest(reason.QuestionNotFound)+ return "", errors.BadRequest(reason.AnswerNotFound)+ }+ if answerInfo.Status == entity.AnswerStatusDeleted {+ return "", errors.BadRequest(reason.AnswerCannotUpdate)}- answerInfo, exist, err := as.answerRepo.GetByID(ctx, req.ID)+ questionInfo, exist, err := as.questionRepo.GetQuestion(ctx, answerInfo.QuestionID)if err != nil {return "", err}if !exist {- return "", errors.BadRequest(reason.AnswerNotFound)- }-- if answerInfo.Status == entity.AnswerStatusDeleted {- return "", errors.BadRequest(reason.AnswerCannotUpdate)+ return "", errors.BadRequest(reason.QuestionNotFound)}//If the content is the same, ignore it@@ -374,7 +373,7 @@ func (as *AnswerService) Update(ctx context.Context, req *schema.AnswerUpdateReqinsertData := &entity.Answer{}insertData.ID = req.IDinsertData.UserID = answerInfo.UserID- insertData.QuestionID = req.QuestionID+ insertData.QuestionID = questionInfo.IDinsertData.OriginalText = req.ContentinsertData.ParsedText = req.HTMLinsertData.UpdatedAt = time.Now()@@ -403,7 +402,7 @@ func (as *AnswerService) Update(ctx context.Context, req *schema.AnswerUpdateReqif err = as.answerRepo.UpdateAnswer(ctx, insertData, []string{"original_text", "parsed_text", "updated_at", "last_edit_user_id"}); err != nil {return "", err}- err = as.questionCommon.UpdatePostTime(ctx, req.QuestionID)+ err = as.questionCommon.UpdatePostTime(ctx, questionInfo.ID)if err != nil {return insertData.ID, err}