Skip to content

A Q&A platform software for teams at any scales. Whether it's a community forum, help center, or knowledge management platform, you can always count on Apache Answer.

update no_enough_rank_to_operate

aichy126fc94d667b7c8
diff --git a/internal/controller/question_controller.go b/internal/controller/question_controller.go
index b7e254a9..a0c35be6 100644
--- a/internal/controller/question_controller.go
+++ b/internal/controller/question_controller.go
@@ -5,6 +5,7 @@ import (
"github.com/answerdev/answer/internal/base/middleware"
"github.com/answerdev/answer/internal/base/pager"
"github.com/answerdev/answer/internal/base/reason"
+ "github.com/answerdev/answer/internal/base/translator"
"github.com/answerdev/answer/internal/base/validator"
"github.com/answerdev/answer/internal/entity"
"github.com/answerdev/answer/internal/schema"
@@ -306,13 +307,14 @@ func (qc *QuestionController) AddQuestion(ctx *gin.Context) {
}
req.UserID = middleware.GetLoginUserIDFromContext(ctx)
- canList, err := qc.rankService.CheckOperationPermissions(ctx, req.UserID, []string{
+ canList, requireRanks, err := qc.rankService.CheckOperationPermissionsForRanks(ctx, req.UserID, []string{
permission.QuestionAdd,
permission.QuestionEdit,
permission.QuestionDelete,
permission.QuestionClose,
permission.QuestionReopen,
permission.TagUseReservedTag,
+ permission.TagAdd,
})
if err != nil {
handler.HandleResponse(ctx, err, nil)
@@ -324,11 +326,25 @@ func (qc *QuestionController) AddQuestion(ctx *gin.Context) {
req.CanClose = canList[3]
req.CanReopen = canList[4]
req.CanUseReservedTag = canList[5]
+ req.CanAddTag = canList[6]
if !req.CanAdd {
handler.HandleResponse(ctx, errors.Forbidden(reason.RankFailToMeetTheCondition), nil)
return
}
+ // can add tag
+ hasNewTag, err := qc.questionService.HasNewTag(ctx, req.Tags)
+ if err != nil {
+ handler.HandleResponse(ctx, err, nil)
+ return
+ }
+ if !req.CanAddTag && hasNewTag {
+ lang := handler.GetLang(ctx)
+ msg := translator.TrWithData(lang, reason.NoEnoughRankToOperate, &schema.PermissionTrTplData{Rank: requireRanks[6]})
+ handler.HandleResponse(ctx, errors.Forbidden(reason.NoEnoughRankToOperate).WithMsg(msg), nil)
+ return
+ }
+
errList, err := qc.questionService.CheckAddQuestion(ctx, req)
if err != nil {
errlist, ok := errList.([]*validator.FormErrorField)
@@ -480,11 +496,12 @@ func (qc *QuestionController) UpdateQuestion(ctx *gin.Context) {
req.ID = uid.DeShortID(req.ID)
req.UserID = middleware.GetLoginUserIDFromContext(ctx)
- canList, err := qc.rankService.CheckOperationPermissions(ctx, req.UserID, []string{
+ canList, requireRanks, err := qc.rankService.CheckOperationPermissionsForRanks(ctx, req.UserID, []string{
permission.QuestionEdit,
permission.QuestionDelete,
permission.QuestionEditWithoutReview,
permission.TagUseReservedTag,
+ permission.TagAdd,
})
if err != nil {
handler.HandleResponse(ctx, err, nil)
@@ -496,6 +513,7 @@ func (qc *QuestionController) UpdateQuestion(ctx *gin.Context) {
req.CanDelete = canList[1]
req.NoNeedReview = canList[2] || objectOwner
req.CanUseReservedTag = canList[3]
+ req.CanAddTag = canList[4]
if !req.CanEdit {
handler.HandleResponse(ctx, errors.Forbidden(reason.RankFailToMeetTheCondition), nil)
return
@@ -511,6 +529,19 @@ func (qc *QuestionController) UpdateQuestion(ctx *gin.Context) {
return
}
+ // can add tag
+ hasNewTag, err := qc.questionService.HasNewTag(ctx, req.Tags)
+ if err != nil {
+ handler.HandleResponse(ctx, err, nil)
+ return
+ }
+ if !req.CanAddTag && hasNewTag {
+ lang := handler.GetLang(ctx)
+ msg := translator.TrWithData(lang, reason.NoEnoughRankToOperate, &schema.PermissionTrTplData{Rank: requireRanks[4]})
+ handler.HandleResponse(ctx, errors.Forbidden(reason.NoEnoughRankToOperate).WithMsg(msg), nil)
+ return
+ }
+
resp, err := qc.questionService.UpdateQuestion(ctx, req)
if err != nil {
handler.HandleResponse(ctx, err, resp)
diff --git a/internal/schema/question_schema.go b/internal/schema/question_schema.go
index 859dde54..acabc0d2 100644
--- a/internal/schema/question_schema.go
+++ b/internal/schema/question_schema.go
@@ -124,6 +124,7 @@ type QuestionPermission struct {
CanUseReservedTag bool `json:"-"`
// whether user can invite other user to answer this question
CanInviteOtherToAnswer bool `json:"-"`
+ CanAddTag bool `json:"-"`
}
type CheckCanQuestionUpdate struct {
diff --git a/internal/service/question_service.go b/internal/service/question_service.go
index 3c738485..b456d473 100644
--- a/internal/service/question_service.go
+++ b/internal/service/question_service.go
@@ -200,6 +200,11 @@ func (qs *QuestionService) CheckAddQuestion(ctx context.Context, req *schema.Que
return nil, nil
}
+// HasNewTag
+func (qs *QuestionService) HasNewTag(ctx context.Context, tags []*schema.TagItem) (bool, error) {
+ return qs.tagCommon.HasNewTag(ctx, tags)
+}
+
// AddQuestion add question
func (qs *QuestionService) AddQuestion(ctx context.Context, req *schema.QuestionAdd) (questionInfo any, err error) {
if len(req.Tags) == 0 {
diff --git a/internal/service/tag_common/tag_common.go b/internal/service/tag_common/tag_common.go
index 41350b14..7332ab80 100644
--- a/internal/service/tag_common/tag_common.go
+++ b/internal/service/tag_common/tag_common.go
@@ -247,6 +247,32 @@ func (ts *TagCommonService) ExistRecommend(ctx context.Context, tags []*schema.T
return false, nil
}
+func (ts *TagCommonService) HasNewTag(ctx context.Context, tags []*schema.TagItem) (bool, error) {
+ tagNames := make([]string, 0)
+ tagMap := make(map[string]bool)
+ for _, item := range tags {
+ item.SlugName = strings.ReplaceAll(item.SlugName, " ", "-")
+ tagNames = append(tagNames, item.SlugName)
+ tagMap[item.SlugName] = false
+ }
+ list, err := ts.GetTagListByNames(ctx, tagNames)
+ if err != nil {
+ return true, err
+ }
+ for _, item := range list {
+ _, ok := tagMap[item.SlugName]
+ if ok {
+ tagMap[item.SlugName] = true
+ }
+ }
+ for _, has := range tagMap {
+ if !has {
+ return true, nil
+ }
+ }
+ return false, nil
+}
+
// GetObjectTag get object tag
func (ts *TagCommonService) GetObjectTag(ctx context.Context, objectId string) (objTags []*schema.TagResp, err error) {
tagsInfoList, err := ts.GetObjectEntityTag(ctx, objectId)