Modern Docker Management, Designed for Everyone
Go composecontainer-managementcontainersdockerdocker-composedocker-managementgoself-hostedsveltekittypescriptweb-ui
fix: oidc insecure tls not working for self signed CA (#1448)
Kyle Mendell0256bdebe132
diff --git a/backend/internal/services/oidc_service.go b/backend/internal/services/oidc_service.goindex d4e0c14ff..1605baf67 100644--- a/backend/internal/services/oidc_service.go+++ b/backend/internal/services/oidc_service.go@@ -98,24 +98,34 @@ func (s *OidcService) getInsecureHttpClient() *http.Client {// Create insecure clientinsecureClient := *s.httpClient++ var insecureTransport *http.Transportif transport, ok := insecureClient.Transport.(*http.Transport); ok {- insecureTransport := transport.Clone()- if insecureTransport.TLSClientConfig == nil {- // #nosec G402 - This is explicitly an insecure client for OIDC discovery when TLS verification is skipped- insecureTransport.TLSClientConfig = &tls.Config{- MinVersion: tls.VersionTLS12,- }+ insecureTransport = transport.Clone()+ } else {+ // Transport is nil or not *http.Transport - create a new default transport+ if defaultTransport, ok := http.DefaultTransport.(*http.Transport); ok {+ insecureTransport = defaultTransport.Clone()+ } else {+ insecureTransport = &http.Transport{}}- insecureTransport.TLSClientConfig.InsecureSkipVerify = true- // Force HTTP/2 even with custom TLS config to avoid "malformed HTTP response" errors- // when the server speaks HTTP/2 but the client disabled it due to custom TLS config.- if err := http2.ConfigureTransport(insecureTransport); err != nil {- slog.Warn("getInsecureHttpClient: failed to configure http2 transport", "error", err)+ }++ if insecureTransport.TLSClientConfig == nil {+ // #nosec G402 - This is explicitly an insecure client for OIDC discovery when TLS verification is skipped+ insecureTransport.TLSClientConfig = &tls.Config{+ MinVersion: tls.VersionTLS12,+ InsecureSkipVerify: true,}- insecureClient.Transport = insecureTransport} else {- slog.Warn("getInsecureHttpClient: Transport is not *http.Transport, cannot skip TLS verification")+ insecureTransport.TLSClientConfig.InsecureSkipVerify = true+ }+ // Force HTTP/2 even with custom TLS config to avoid "malformed HTTP response" errors+ // when the server speaks HTTP/2 but the client disabled it due to custom TLS config.+ if err := http2.ConfigureTransport(insecureTransport); err != nil {+ slog.Warn("getInsecureHttpClient: failed to configure http2 transport", "error", err)}+ insecureClient.Transport = insecureTransports.insecureHttpClient = &insecureClientreturn s.insecureHttpClient}