Skip to content

Modern Docker Management, Designed for Everyone

fix: check for updates only checking the current page of images

Kyle Mendell0da46a046aab
diff --git a/backend/internal/api/environment_handler.go b/backend/internal/api/environment_handler.go
index d89942d16..e70077a90 100644
--- a/backend/internal/api/environment_handler.go
+++ b/backend/internal/api/environment_handler.go
@@ -123,7 +123,6 @@ func NewEnvironmentHandler(
apiGroup.GET("/:id/image-updates/check", handler.CheckImageUpdate)
apiGroup.GET("/:id/image-updates/check/:imageId", handler.CheckImageUpdateByID)
- apiGroup.POST("/:id/image-updates/check-batch", handler.CheckMultipleImages)
apiGroup.GET("/:id/image-updates/check-all", handler.CheckAllImages)
apiGroup.GET("/:id/image-updates/summary", handler.GetUpdateSummary)
apiGroup.GET("/:id/image-updates/versions", handler.GetImageVersions)
@@ -246,9 +245,6 @@ func (h *EnvironmentHandler) handleImageUpdateEndpoints(c *gin.Context, endpoint
case strings.HasPrefix(endpoint, "/image-updates/check/") && c.Request.Method == http.MethodGet:
imageUpdateHandler.CheckImageUpdateByID(c)
return true
- case endpoint == "/image-updates/check-batch" && c.Request.Method == http.MethodPost:
- imageUpdateHandler.CheckMultipleImages(c)
- return true
case endpoint == "/image-updates/check-all" && c.Request.Method == http.MethodGet:
imageUpdateHandler.CheckAllImages(c)
return true
@@ -274,10 +270,6 @@ func (h *EnvironmentHandler) CheckImageUpdateByID(c *gin.Context) {
h.routeRequest(c, "/image-updates/check/"+imageID)
}
-func (h *EnvironmentHandler) CheckMultipleImages(c *gin.Context) {
- h.routeRequest(c, "/image-updates/check-batch")
-}
-
func (h *EnvironmentHandler) CheckAllImages(c *gin.Context) {
h.routeRequest(c, "/image-updates/check-all")
}
diff --git a/backend/internal/api/image_update_handler.go b/backend/internal/api/image_update_handler.go
index 23e32d506..0a6e3e929 100644
--- a/backend/internal/api/image_update_handler.go
+++ b/backend/internal/api/image_update_handler.go
@@ -117,17 +117,7 @@ func (h *ImageUpdateHandler) CheckMultipleImages(c *gin.Context) {
}
func (h *ImageUpdateHandler) CheckAllImages(c *gin.Context) {
- limitStr := c.DefaultQuery("limit", "50")
- limit, err := strconv.Atoi(limitStr)
- if err != nil {
- c.JSON(http.StatusBadRequest, gin.H{
- "success": false,
- "error": "Invalid limit parameter",
- })
- return
- }
-
- results, err := h.imageUpdateService.CheckAllImages(c.Request.Context(), limit)
+ results, err := h.imageUpdateService.CheckAllImages(c.Request.Context(), 0)
if err != nil {
c.JSON(http.StatusInternalServerError, gin.H{
"success": false,
diff --git a/frontend/src/lib/services/api/environment-api-service.ts b/frontend/src/lib/services/api/environment-api-service.ts
index c0e06c841..3c3886dd2 100644
--- a/frontend/src/lib/services/api/environment-api-service.ts
+++ b/frontend/src/lib/services/api/environment-api-service.ts
@@ -327,14 +327,9 @@ export class EnvironmentAPIService extends BaseAPIService {
return this.handleResponse(this.api.get(`/environments/${envId}/image-updates/check/${imageId}`));
}
- async checkMultipleImages(imageRefs: string[]): Promise<Record<string, ImageUpdateInfoDto>> {
+ async checkAllImages(): Promise<Record<string, ImageUpdateInfoDto>> {
const envId = await this.getCurrentEnvironmentId();
- return this.handleResponse(this.api.post(`/environments/${envId}/image-updates/check-batch`, { imageRefs }));
- }
-
- async checkAllImages(limit = 50): Promise<Record<string, ImageUpdateInfoDto>> {
- const envId = await this.getCurrentEnvironmentId();
- return this.handleResponse(this.api.get(`/environments/${envId}/image-updates/check-all`, { params: { limit } }));
+ return this.handleResponse(this.api.get(`/environments/${envId}/image-updates/check-all`));
}
async getUpdateSummary(): Promise<ImageUpdateSummary> {
diff --git a/frontend/src/routes/images/+page.svelte b/frontend/src/routes/images/+page.svelte
index 14267e168..a6dd70660 100644
--- a/frontend/src/routes/images/+page.svelte
+++ b/frontend/src/routes/images/+page.svelte
@@ -48,8 +48,7 @@
async function handleTriggerBulkUpdateCheck() {
isLoading.checking = true;
try {
- const imageRefs = images.data.map((img) => img.repoTags?.[0] || `image:${img.id}`);
- await environmentAPI.checkMultipleImages(imageRefs);
+ await environmentAPI.checkAllImages();
toast.success(m.images_update_check_completed());
images = await environmentAPI.getImages(requestOptions);
} catch (error) {