Modern Docker Management, Designed for Everyone
Go composecontainer-managementcontainersdockerdocker-composedocker-managementgoself-hostedsveltekittypescriptweb-ui
fix: use in-memory trivy DB backend on 32-bit architectures to prevent mmap allocation failure (#2529)
Kyle Mendell182da44f948b
diff --git a/backend/internal/services/vulnerability_service.go b/backend/internal/services/vulnerability_service.goindex d6ea69c79..81ec59f95 100644--- a/backend/internal/services/vulnerability_service.go+++ b/backend/internal/services/vulnerability_service.go@@ -14,6 +14,7 @@ import ("net/url""os""path/filepath"+ "runtime""sort""strconv""strings"@@ -1397,8 +1398,12 @@ func (s *VulnerabilityService) execTrivyScanInContainer(ctx context.Context, conoutputPath := newTrivyOutputPathInternal()defer cleanupTrivyOutputFileInContainerInternal(ctx, dockerClient, containerID, outputPath)+ execCmd := []string{"trivy", "image", "--format", "json", "--quiet", "--output", outputPath, "--timeout", trivyTimeout}+ execCmd = append(execCmd, trivyDBBackendArgsInternal()...)+ execCmd = append(execCmd, imageName)+execCfg := client.ExecCreateOptions{- Cmd: []string{"trivy", "image", "--format", "json", "--quiet", "--output", outputPath, "--timeout", trivyTimeout, imageName},+ Cmd: execCmd,AttachStdout: true,AttachStderr: true,}@@ -2113,6 +2118,23 @@ func cleanupTempFiles(ctx context.Context, tempFiles []string) {}}+// trivyDBBackendArgsForArchInternal returns extra Trivy flags that switch the+// vulnerability DB to an in-memory backend on 32-bit architectures. bbolt's+// default mmap-based backend can fail with ENOMEM on arm/v7 and 386 because+// Go's heap reservations fragment the limited 32-bit virtual address space.+func trivyDBBackendArgsForArchInternal(arch string) []string {+ switch arch {+ case "arm", "386", "mips", "mipsle":+ return []string{"--db-backend", "memory"}+ default:+ return nil+ }+}++func trivyDBBackendArgsInternal() []string {+ return trivyDBBackendArgsForArchInternal(runtime.GOARCH)+}+func (s *VulnerabilityService) buildTrivyCommandArgs(ctx context.Context,imageName string,@@ -2122,6 +2144,7 @@ func (s *VulnerabilityService) buildTrivyCommandArgs(outputPath string,) ([]string, []string) {cmdArgs := []string{"image", "--format", "json", "--quiet", "--timeout", s.getTrivyScanTimeoutArg()}+ cmdArgs = append(cmdArgs, trivyDBBackendArgsInternal()...)var tempFiles []stringif strings.TrimSpace(configContent) != "" {diff --git a/backend/internal/services/vulnerability_service_test.go b/backend/internal/services/vulnerability_service_test.goindex e5968564b..0a49275f9 100644--- a/backend/internal/services/vulnerability_service_test.go+++ b/backend/internal/services/vulnerability_service_test.go@@ -290,6 +290,31 @@ func TestBuildTrivyCommandArgs_WithoutCacheDir(t *testing.T) {require.Equal(t, "alpine:3.20", cmdArgs[len(cmdArgs)-1])}+func TestTrivyDBBackendArgsForArch(t *testing.T) {+ memoryBackend := []string{"--db-backend", "memory"}++ tests := []struct {+ arch string+ want []string+ }{+ {"arm", memoryBackend},+ {"386", memoryBackend},+ {"mips", memoryBackend},+ {"mipsle", memoryBackend},+ {"amd64", nil},+ {"arm64", nil},+ {"ppc64le", nil},+ {"s390x", nil},+ {"", nil},+ }++ for _, tt := range tests {+ t.Run(tt.arch, func(t *testing.T) {+ require.Equal(t, tt.want, trivyDBBackendArgsForArchInternal(tt.arch))+ })+ }+}+func TestBuildTrivyContainerConfig_IncludesEnv(t *testing.T) {config := buildTrivyContainerConfig(DefaultTrivyImage,