Skip to content

Modern Docker Management, Designed for Everyone

feat: add mobile sorting to shared table view menu (#4225)

Kyle Mendell18977ca97f06
diff --git a/frontend/src/lib/components/arcane-table/arcane-table-toolbar.svelte b/frontend/src/lib/components/arcane-table/arcane-table-toolbar.svelte
index 4b60c1edc..55c348067 100644
--- a/frontend/src/lib/components/arcane-table/arcane-table-toolbar.svelte
+++ b/frontend/src/lib/components/arcane-table/arcane-table-toolbar.svelte
@@ -243,9 +243,9 @@
</div>
<div class="order-3 shrink-0 md:hidden">
{#if mobileFields.length > 0 && onToggleMobileField}
- <DataTableViewOptions fields={mobileFields} onToggleField={onToggleMobileField} {customViewOptions} />
+ <DataTableViewOptions {table} fields={mobileFields} onToggleField={onToggleMobileField} {customViewOptions} showSorting />
{:else}
- <DataTableViewOptions {table} {customViewOptions} />
+ <DataTableViewOptions {table} {customViewOptions} showSorting />
{/if}
</div>
</div>
diff --git a/frontend/src/lib/components/arcane-table/arcane-table-view-options.svelte b/frontend/src/lib/components/arcane-table/arcane-table-view-options.svelte
index 3827459c5..d98fd5a2d 100644
--- a/frontend/src/lib/components/arcane-table/arcane-table-view-options.svelte
+++ b/frontend/src/lib/components/arcane-table/arcane-table-view-options.svelte
@@ -4,7 +4,7 @@
import * as DropdownMenu from '#lib/components/ui/dropdown-menu/index.js';
import { m } from '#lib/paraglide/messages.js';
import type { Snippet } from 'svelte';
- import { EyeOnIcon } from '#lib/icons/index.js';
+ import { EyeOnIcon, ArrowUpIcon, ArrowDownIcon } from '#lib/icons/index.js';
let {
table,
@@ -12,7 +12,8 @@
onToggleField,
customViewOptions,
wrapText = false,
- onToggleWrapText
+ onToggleWrapText,
+ showSorting = false
}: {
table?: ArcaneSvelteTable<TData>;
fields?: { id: string; label: string; visible: boolean }[];
@@ -20,7 +21,28 @@
customViewOptions?: Snippet;
wrapText?: boolean;
onToggleWrapText?: () => void;
+ showSorting?: boolean;
} = $props();
+
+ // Mobile cards have no column headers, so the menu exposes the same column sorts.
+ // Cards follow mobile field visibility, not desktop column visibility.
+ function isSortVisible(columnId: string, visible: boolean): boolean {
+ if (!fields) return visible;
+ return fields.find((field) => field.id === columnId)?.visible ?? true;
+ }
+ const sortableColumns = $derived(
+ showSorting && table
+ ? table.getAllColumns().filter((col) => col.getCanSort() && isSortVisible(col.id, col.getIsVisible()))
+ : []
+ );
+ const activeSort = $derived(table?.atoms.sorting.get()[0]);
+ const activeSortColumn = $derived(activeSort ? sortableColumns.find((col) => col.id === String(activeSort.id)) : undefined);
+
+ function selectSortColumn(columnId: string) {
+ const column = sortableColumns.find((col) => col.id === columnId);
+ if (!column) return;
+ column.toggleSorting(activeSort?.desc ?? false);
+ }
</script>
<DropdownMenu.Root>
@@ -52,11 +74,45 @@
</DropdownMenu.Group>
<DropdownMenu.Separator />
{/if}
+ {#if sortableColumns.length > 0}
+ <DropdownMenu.Group>
+ <DropdownMenu.Label>{m.common_sort_by()}</DropdownMenu.Label>
+ <DropdownMenu.Separator />
+ <DropdownMenu.RadioGroup value={activeSortColumn?.id ?? ''} onValueChange={selectSortColumn}>
+ {#each sortableColumns as column (column.id)}
+ <DropdownMenu.RadioItem value={column.id} closeOnSelect={false}>
+ {column.columnDef.meta?.title ?? column.id}
+ </DropdownMenu.RadioItem>
+ {/each}
+ </DropdownMenu.RadioGroup>
+ <DropdownMenu.Separator />
+ <DropdownMenu.RadioGroup
+ value={activeSortColumn ? (activeSort?.desc ? 'desc' : 'asc') : ''}
+ onValueChange={(value) => activeSortColumn?.toggleSorting(value === 'desc')}
+ >
+ <DropdownMenu.RadioItem value="asc" disabled={!activeSortColumn} closeOnSelect={false}>
+ <ArrowUpIcon class="size-4 text-muted-foreground/70" />
+ {m.common_sort_asc()}
+ </DropdownMenu.RadioItem>
+ <DropdownMenu.RadioItem value="desc" disabled={!activeSortColumn} closeOnSelect={false}>
+ <ArrowDownIcon class="size-4 text-muted-foreground/70" />
+ {m.common_sort_desc()}
+ </DropdownMenu.RadioItem>
+ </DropdownMenu.RadioGroup>
+ </DropdownMenu.Group>
+ <DropdownMenu.Separator />
+ {/if}
<DropdownMenu.Group>
<DropdownMenu.Label>{m.common_toggle_columns()}</DropdownMenu.Label>
<DropdownMenu.Separator />
- {#if table}
+ {#if fields && onToggleField}
+ {#each fields as field (field.id)}
+ <DropdownMenu.CheckboxItem checked={field.visible} onCheckedChange={() => onToggleField(field.id)}>
+ {field.label}
+ </DropdownMenu.CheckboxItem>
+ {/each}
+ {:else if table}
{#each table
.getAllColumns()
.filter((col) => typeof col.accessorFn !== 'undefined' && col.getCanHide()) as column (column)}
@@ -68,12 +124,6 @@
{headerText}
</DropdownMenu.CheckboxItem>
{/each}
- {:else if fields && onToggleField}
- {#each fields as field (field.id)}
- <DropdownMenu.CheckboxItem checked={field.visible} onCheckedChange={() => onToggleField(field.id)}>
- {field.label}
- </DropdownMenu.CheckboxItem>
- {/each}
{/if}
</DropdownMenu.Group>
</DropdownMenu.Content>