Skip to content

Modern Docker Management, Designed for Everyone

fix(frontend): improve login form autofill compatibility (#2514)

MikeO71bd83e56d678
diff --git a/frontend/src/lib/components/ui/input-group/input-group-addon.svelte b/frontend/src/lib/components/ui/input-group/input-group-addon.svelte
index 9469afc5b..cab74b790 100644
--- a/frontend/src/lib/components/ui/input-group/input-group-addon.svelte
+++ b/frontend/src/lib/components/ui/input-group/input-group-addon.svelte
@@ -26,6 +26,7 @@
class: className,
children,
align = 'inline-start',
+ role = 'group',
...restProps
}: HTMLAttributes<HTMLDivElement> & {
align?: InputGroupAddonAlign;
@@ -33,8 +34,8 @@
</script>
<div
- role="group"
data-slot="input-group-addon"
+ {role}
data-align={align}
class={cn(inputGroupAddonVariants({ align }), className)}
onclick={(e) => {
diff --git a/frontend/src/lib/components/ui/input-group/input-group.svelte b/frontend/src/lib/components/ui/input-group/input-group.svelte
index 4fa856771..97959252e 100644
--- a/frontend/src/lib/components/ui/input-group/input-group.svelte
+++ b/frontend/src/lib/components/ui/input-group/input-group.svelte
@@ -2,12 +2,12 @@
import { cn } from '$lib/utils.js';
import type { HTMLAttributes } from 'svelte/elements';
- let { class: className, children, ...props }: HTMLAttributes<HTMLDivElement> = $props();
+ let { class: className, children, role = 'group', ...props }: HTMLAttributes<HTMLDivElement> = $props();
</script>
<div
data-slot="input-group"
- role="group"
+ {role}
class={cn(
'group/input-group bg-input/80 relative flex w-full items-center overflow-hidden rounded-lg border shadow-xs backdrop-blur-sm transition-all outline-none',
'h-9 has-[>textarea]:h-auto',
diff --git a/frontend/src/routes/(auth)/login/+page.svelte b/frontend/src/routes/(auth)/login/+page.svelte
index c32a59cd3..b2933f804 100644
--- a/frontend/src/routes/(auth)/login/+page.svelte
+++ b/frontend/src/routes/(auth)/login/+page.svelte
@@ -225,11 +225,11 @@
{/if}
{#if showLocalLoginForm}
- <form onsubmit={handleLogin} class="space-y-4">
+ <form id="login-form" name="login" action="" method="post" onsubmit={handleLogin} class="space-y-4" autocomplete="on">
<div class="space-y-2">
<Label for="username" class="text-xs">{m.common_username()}</Label>
- <InputGroup.Root>
- <InputGroup.Addon>
+ <InputGroup.Root role={undefined}>
+ <InputGroup.Addon role={undefined}>
<UserIcon />
</InputGroup.Addon>
<InputGroup.Input
@@ -237,6 +237,7 @@
name="username"
type="text"
autocomplete="username"
+ aria-label={m.common_username()}
required
bind:value={username}
placeholder={m.auth_username_placeholder()}
@@ -246,8 +247,8 @@
</div>
<div class="space-y-2">
<Label for="password" class="text-xs">{m.common_password()}</Label>
- <InputGroup.Root>
- <InputGroup.Addon>
+ <InputGroup.Root role={undefined}>
+ <InputGroup.Addon role={undefined}>
<LockIcon />
</InputGroup.Addon>
<InputGroup.Input
@@ -255,6 +256,7 @@
name="password"
type="password"
autocomplete="current-password"
+ aria-label={m.common_password()}
required
bind:value={password}
placeholder={m.auth_password_placeholder()}