Modern Docker Management, Designed for Everyone
Go composecontainer-managementcontainersdockerdocker-composedocker-managementgoself-hostedsveltekittypescriptweb-ui
fix: git clone failures with Azure DevOps repositories (#3197)
Kyle Mendell28e4a1071d83
diff --git a/backend/pkg/gitutil/git.go b/backend/pkg/gitutil/git.goindex 60c3f488d..b2dff5370 100644--- a/backend/pkg/gitutil/git.go+++ b/backend/pkg/gitutil/git.go@@ -20,6 +20,7 @@ import ("github.com/go-git/go-git/v5""github.com/go-git/go-git/v5/config""github.com/go-git/go-git/v5/plumbing"+ "github.com/go-git/go-git/v5/plumbing/protocol/packp/capability""github.com/go-git/go-git/v5/plumbing/transport""github.com/go-git/go-git/v5/plumbing/transport/client"githttp "github.com/go-git/go-git/v5/plumbing/transport/http"@@ -33,6 +34,15 @@ import (// distroless image. Unregister it so a repository URL can never reach it.func init() {client.InstallProtocol("file", nil)++ // go-git strips multi_ack/multi_ack_detailed from pack negotiation by+ // default, which Azure DevOps rejects by sending an incomplete pack+ // ("invalid reset option: object not found" on clone). Advertise them and+ // keep only thin-pack disabled, matching Flux/ArgoCD; other hosts are+ // unaffected.+ transport.UnsupportedCapabilities = []capability.Capability{+ capability.ThinPack,+ }}// Client handles git operationsdiff --git a/backend/pkg/gitutil/git_test.go b/backend/pkg/gitutil/git_test.goindex 8fed14694..d6867b7d2 100644--- a/backend/pkg/gitutil/git_test.go+++ b/backend/pkg/gitutil/git_test.go@@ -12,9 +12,20 @@ import ("testing""time"+ "github.com/go-git/go-git/v5/plumbing/protocol/packp/capability"+ "github.com/go-git/go-git/v5/plumbing/transport"gossh "golang.org/x/crypto/ssh")+// Azure DevOps requires multi_ack/multi_ack_detailed in pack negotiation;+// go-git's default UnsupportedCapabilities strips them and clones fail with+// "invalid reset option: object not found" (#3168).+func TestInitAllowsMultiAckCapabilities(t *testing.T) {+ if len(transport.UnsupportedCapabilities) != 1 || transport.UnsupportedCapabilities[0] != capability.ThinPack {+ t.Errorf("expected UnsupportedCapabilities to contain only thin-pack, got %v", transport.UnsupportedCapabilities)+ }+}+func TestGetKnownHostsPath(t *testing.T) {t.Run("returns SSH_KNOWN_HOSTS env var when set", func(t *testing.T) {customPath := "/custom/path/known_hosts"