Modern Docker Management, Designed for Everyone
Go composecontainer-managementcontainersdockerdocker-composedocker-managementgoself-hostedsveltekittypescriptweb-ui
fix: cleanup of orphaned image update records after applying updates
Kyle Mendell31155c5ca8ae
diff --git a/backend/internal/services/image_service.go b/backend/internal/services/image_service.goindex 3e4f6ae25..cfb7b5df4 100644--- a/backend/internal/services/image_service.go+++ b/backend/internal/services/image_service.go@@ -345,6 +345,13 @@ func (s *ImageService) syncImagesToDatabase(ctx context.Context, dockerImages []lastErr = err}+ if err := s.imageUpdateService.CleanupOrphanedRecords(ctx); err != nil {+ fmt.Printf("Warning: failed to cleanup orphaned image update records: %v\n", err)+ if lastErr == nil {+ lastErr = err+ }+ }+return lastErr}diff --git a/backend/internal/services/updater_service.go b/backend/internal/services/updater_service.goindex cb236325d..c60414139 100644--- a/backend/internal/services/updater_service.go+++ b/backend/internal/services/updater_service.go@@ -229,10 +229,31 @@ func (s *UpdaterService) ApplyPending(ctx context.Context, dryRun bool) (*dto.Up}}- // Refresh image_updates by re-checking- for oldRef := range oldRefToNewRef {- if _, err := s.imageUpdateService.CheckImageUpdate(ctx, oldRef); err != nil {- log.Printf("refresh update record failed for %s: %v", oldRef, err)+ // After applying updates, clear has_update locally if no containers still use old image IDs.+ if !dryRun {+ for _, p := range plans {+ if len(p.oldIDs) == 0 {+ continue+ }+ stillUsed, _ := s.anyImageIDsStillInUse(ctx, p.oldIDs)+ if stillUsed {+ continue+ }+ repo, tag := s.parseRepoAndTag(p.oldRef)+ if repo == "" || tag == "" {+ continue+ }+ if err := s.clearImageUpdateRecord(ctx, repo, tag); err == nil {+ s.logAutoUpdate(ctx, models.EventSeverityInfo, models.JSON{+ "phase": "record_clear",+ "imageOld": p.oldRef,+ "status": "cleared",+ })+ }+ }++ if err := s.imageUpdateService.CleanupOrphanedRecords(ctx); err != nil {+ log.Printf("cleanup orphaned update records failed: %v", err)}}@@ -781,3 +802,60 @@ func (s *UpdaterService) severityFromStatus(status string) models.EventSeverityreturn models.EventSeverityInfo}}++func (s *UpdaterService) anyImageIDsStillInUse(ctx context.Context, ids []string) (bool, error) {+ if len(ids) == 0 {+ return false, nil+ }+ set := make(map[string]struct{}, len(ids))+ for _, id := range ids {+ if id != "" {+ set[id] = struct{}{}+ }+ }++ dcli, err := s.dockerService.CreateConnection(ctx)+ if err != nil {+ return false, fmt.Errorf("docker connect: %w", err)+ }+ defer dcli.Close()++ list, err := dcli.ContainerList(ctx, container.ListOptions{All: false})+ if err != nil {+ return false, fmt.Errorf("list containers: %w", err)+ }+ for _, c := range list {+ inspect, ierr := dcli.ContainerInspect(ctx, c.ID)+ if ierr != nil {+ continue+ }+ if _, ok := set[inspect.Image]; ok {+ return true, nil+ }+ }+ return false, nil+}++func (s *UpdaterService) clearImageUpdateRecord(ctx context.Context, repository, tag string) error {+ return s.db.WithContext(ctx).+ Model(&models.ImageUpdateRecord{}).+ Where("repository = ? AND tag = ?", repository, tag).+ Update("has_update", false).Error+}++// parseRepoAndTag extracts repository and tag from a reference like "registry/repo:tag".+// Uses the last ":" occurring after the last "/" as the tag separator. Defaults tag to "latest".+func (s *UpdaterService) parseRepoAndTag(ref string) (string, string) {+ // strip digest if present+ ref = s.stripDigest(ref)++ tag := "latest"+ slash := strings.LastIndex(ref, "/")+ colon := strings.LastIndex(ref, ":")+ if colon > slash && colon != -1 {+ tag = ref[colon+1:]+ ref = ref[:colon]+ }+ // Keep registry in repository as stored in records (they store Repository without tag)+ return ref, tag+}